{"id":805791,"url":"http://patchwork.ozlabs.org/api/patches/805791/?format=json","web_url":"http://patchwork.ozlabs.org/project/openbmc/patch/20170825065244.488-5-andrew@aj.id.au/","project":{"id":56,"url":"http://patchwork.ozlabs.org/api/projects/56/?format=json","name":"OpenBMC development","link_name":"openbmc","list_id":"openbmc.lists.ozlabs.org","list_email":"openbmc@lists.ozlabs.org","web_url":"http://github.com/openbmc/","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170825065244.488-5-andrew@aj.id.au>","list_archive_url":null,"date":"2017-08-25T06:52:43","name":"[linux,dev-4.10,4/5] aspeed: witherspoon: Tidy and unify LED nodes","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"4bfd9c1b7c95d631cbc3e25fe73a101afd177c16","submitter":{"id":68332,"url":"http://patchwork.ozlabs.org/api/people/68332/?format=json","name":"Andrew Jeffery","email":"andrew@aj.id.au"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openbmc/patch/20170825065244.488-5-andrew@aj.id.au/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/805791/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/805791/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xdsNg64SVz9sDB\n\tfor ;\n\tFri, 25 Aug 2017 16:54:59 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xdsNg4qLJzDrWK\n\tfor ;\n\tFri, 25 Aug 2017 16:54:59 +1000 (AEST)","from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com\n\t[66.111.4.26])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xdsMF6cKNzDrL5\n\tfor ; Fri, 25 Aug 2017 16:53:45 +1000 (AEST)","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id A271920DE9;\n\tFri, 25 Aug 2017 02:53:43 -0400 (EDT)","from frontend2 ([10.202.2.161])\n\tby compute4.internal (MEProxy); Fri, 25 Aug 2017 02:53:43 -0400","from keelia.aj.id.au\n\t(ppp118-210-176-216.bras2.adl6.internode.on.net [118.210.176.216])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 7B65F240B1;\n\tFri, 25 Aug 2017 02:53:40 -0400 (EDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"orP6YaWF\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"CT6A4kUT\"; \n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"orP6YaWF\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"CT6A4kUT\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"orP6YaWF\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"CT6A4kUT\"; dkim-atps=neutral"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:date:from:in-reply-to:message-id:references:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=dJGPMa\n\tfibcacdFnlKxFoDDiqQZjOPcK3jl/f7YBLQqc=; b=orP6YaWFjqKfZi4WL86D/S\n\tOWwYiYJu1kTpi/JVevnxqzrGJZYBNCLLOAb0xhmSLLPfFfUkqeF9S5LFVTniGHrv\n\tpSHCI7fEG4m7+SYX4DkKMQkEbcYtaUEq3uDSUS75qbmr+Ju//W1ocAojXP462RSc\n\tvi32F2rULHS/1IW9BRFSxidzU0ihG3esygeJK5zJiEDCmoVISfUDDL402/Cs5fzY\n\t6X9JgKpx1jKKMu8Tdu7MtpjcgcrYtEr6GAZ78y8xuMgcUa1AIro3mkE5cd2rWf4H\n\tm1N0RO/UR+zKOvsKfSdpLbOCdZRlIMHGefbNqMfdusj6Meqox7wQkMvbSPCv3H1A\n\t==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:in-reply-to:message-id\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=fm1; bh=dJGPMafibcacdFnlKxFoDDiqQZjOPcK3jl/f7YBLQ\n\tqc=; b=CT6A4kUTGlz+HJ9dJNTbOxxXDskpi4x8WCcoQK1roB59Z3i/8/inaloyD\n\tGfqriCh0SWz3YX0HjhUmLdZIHMihaLPfzNcZTPXAvh0095cCjQKa2LadSUYOdruJ\n\tMKzTY71CxKF9ofX0ECGy/4MuopkSR2qJv85x3tQCJ4e9ntt9GymuGZrmpLqzqLRW\n\tUfulA861vWhqsMh26XB+aV+pQ3UOfLIzO5rZjz7HhtepzTaF153CwAUMf7j+WCV1\n\tqrVT//3NtFX+Qcs/1u2VYnrVkkIHYmTDTKpXXTR1GjBx5booM0KRIRCaRJ/VafT/\n\tX5CCc3H3p+xxug6yq4L5NSHE4HIkQ=="],"X-ME-Sender":"","X-Sasl-enc":"w0DXJxJAOQ+N/FbexWKAgJIERGDuA2wOgeE7+5GGYl7l 1503644022","From":"Andrew Jeffery ","To":"joel@jms.id.au","Subject":"[PATCH linux dev-4.10 4/5] aspeed: witherspoon: Tidy and unify LED\n\tnodes","Date":"Fri, 25 Aug 2017 16:22:43 +0930","Message-Id":"<20170825065244.488-5-andrew@aj.id.au>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170825065244.488-1-andrew@aj.id.au>","References":"<20170825065244.488-1-andrew@aj.id.au>","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , eajames@linux.vnet.ibm.com,\n\topenbmc@lists.ozlabs.org, clg@kaod.org, bjwyman@gmail.com","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"},"content":"There's no reason for these to be separate, the gpios property defines\nthe controller needed for each LED. Also fix the node names so we can\ndrop the label property.\n\nSigned-off-by: Andrew Jeffery \n---\n arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 25 ++++++++++--------------\n 1 file changed, 10 insertions(+), 15 deletions(-)","diff":"diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts\nindex dd30c20c9fb2..81996f070818 100644\n--- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts\n+++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts\n@@ -87,48 +87,43 @@\n \t\t};\n \t};\n \n-\tpca_leds {\n+\tleds {\n \t\tcompatible = \"gpio-leds\";\n \n \t\tfan0 {\n-\t\t\tlabel = \"fan0\";\n \t\t\tdefault-state = \"keep\";\n \t\t\tgpios = <&pca0 0 GPIO_ACTIVE_LOW>;\n \t\t};\n+\n \t\tfan1 {\n-\t\t\tlabel = \"fan1\";\n \t\t\tdefault-state = \"keep\";\n \t\t\tgpios = <&pca0 1 GPIO_ACTIVE_LOW>;\n \t\t};\n+\n \t\tfan2 {\n-\t\t\tlabel = \"fan2\";\n \t\t\tdefault-state = \"keep\";\n \t\t\tgpios = <&pca0 2 GPIO_ACTIVE_LOW>;\n \t\t};\n+\n \t\tfan3 {\n-\t\t\tlabel = \"fan3\";\n \t\t\tdefault-state = \"keep\";\n \t\t\tgpios = <&pca0 3 GPIO_ACTIVE_LOW>;\n \t\t};\n-\t\tfront_fault {\n-\t\t\tlabel = \"front-fault\";\n+\n+\t\tfront-fault {\n \t\t\tdefault-state = \"keep\";\n \t\t\tgpios = <&pca0 13 GPIO_ACTIVE_LOW>;\n \t\t};\n-\t\tfront_power {\n-\t\t\tlabel = \"front-power\";\n+\n+\t\tfront-power {\n \t\t\tdefault-state = \"keep\";\n \t\t\tgpios = <&pca0 14 GPIO_ACTIVE_LOW>;\n \t\t};\n-\t\tfront_id {\n-\t\t\tlabel = \"front-id\";\n+\n+\t\tfront-id {\n \t\t\tdefault-state = \"keep\";\n \t\t\tgpios = <&pca0 15 GPIO_ACTIVE_LOW>;\n \t\t};\n-\t};\n-\n-\tleds {\n-\t\tcompatible = \"gpio-leds\";\n \n \t\trear-fault {\n \t\t\tgpios = <&gpio ASPEED_GPIO(N, 2) GPIO_ACTIVE_LOW>;\n","prefixes":["linux","dev-4.10","4/5"]}