{"id":804935,"url":"http://patchwork.ozlabs.org/api/patches/804935/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170823101901.33961-2-aik@ozlabs.ru/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20170823101901.33961-2-aik@ozlabs.ru>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20170823101901.33961-2-aik@ozlabs.ru/","date":"2017-08-23T10:18:57","name":"[kernel,1/5] powerpc/pci: Remove unused parameter from add_one_dev_pci_data()","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"462d848dabfde77daa982772ef7122b2a0b50798","submitter":{"id":7621,"url":"http://patchwork.ozlabs.org/api/people/7621/?format=json","name":"Alexey Kardashevskiy","email":"aik@ozlabs.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170823101901.33961-2-aik@ozlabs.ru/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/804935/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/804935/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xckCb2KRPz9s7h\n\tfor ;\n\tWed, 23 Aug 2017 20:28:11 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xckCb1VH0zDrVj\n\tfor ;\n\tWed, 23 Aug 2017 20:28:11 +1000 (AEST)","from ozlabs.ru (ozlabs.ru [107.173.13.209])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xck1k6mXGzDrVn\n\tfor ;\n\tWed, 23 Aug 2017 20:19:38 +1000 (AEST)","from vpl1.ozlabs.ibm.com (localhost [IPv6:::1])\n\tby ozlabs.ru (Postfix) with ESMTP id 2761F3A6004F;\n\tWed, 23 Aug 2017 06:20:11 -0400 (EDT)"],"From":"Alexey Kardashevskiy ","To":"linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH kernel 1/5] powerpc/pci: Remove unused parameter from\n\tadd_one_dev_pci_data()","Date":"Wed, 23 Aug 2017 20:18:57 +1000","Message-Id":"<20170823101901.33961-2-aik@ozlabs.ru>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170823101901.33961-1-aik@ozlabs.ru>","References":"<20170823101901.33961-1-aik@ozlabs.ru>","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy ,\n\tAlistair Popple ,\n\tDavid Gibson ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"pdev is always NULL, remove it.\n\nTo make checkpatch.pl happy, this also removes the \"out of memory\"\nmessage.\n\nSigned-off-by: Alexey Kardashevskiy \n---\n arch/powerpc/kernel/pci_dn.c | 14 ++------------\n 1 file changed, 2 insertions(+), 12 deletions(-)","diff":"diff --git a/arch/powerpc/kernel/pci_dn.c b/arch/powerpc/kernel/pci_dn.c\nindex 592693437070..0256372b72de 100644\n--- a/arch/powerpc/kernel/pci_dn.c\n+++ b/arch/powerpc/kernel/pci_dn.c\n@@ -139,7 +139,6 @@ struct pci_dn *pci_get_pdn(struct pci_dev *pdev)\n \n #ifdef CONFIG_PCI_IOV\n static struct pci_dn *add_one_dev_pci_data(struct pci_dn *parent,\n-\t\t\t\t\t struct pci_dev *pdev,\n \t\t\t\t\t int vf_index,\n \t\t\t\t\t int busno, int devfn)\n {\n@@ -150,10 +149,8 @@ static struct pci_dn *add_one_dev_pci_data(struct pci_dn *parent,\n \t\treturn NULL;\n \n \tpdn = kzalloc(sizeof(*pdn), GFP_KERNEL);\n-\tif (!pdn) {\n-\t\tdev_warn(&pdev->dev, \"%s: Out of memory!\\n\", __func__);\n+\tif (!pdn)\n \t\treturn NULL;\n-\t}\n \n \tpdn->phb = parent->phb;\n \tpdn->parent = parent;\n@@ -167,13 +164,6 @@ static struct pci_dn *add_one_dev_pci_data(struct pci_dn *parent,\n \tINIT_LIST_HEAD(&pdn->list);\n \tlist_add_tail(&pdn->list, &parent->child_list);\n \n-\t/*\n-\t * If we already have PCI device instance, lets\n-\t * bind them.\n-\t */\n-\tif (pdev)\n-\t\tpdev->dev.archdata.pci_data = pdn;\n-\n \treturn pdn;\n }\n #endif\n@@ -201,7 +191,7 @@ struct pci_dn *add_dev_pci_data(struct pci_dev *pdev)\n \tfor (i = 0; i < pci_sriov_get_totalvfs(pdev); i++) {\n \t\tstruct eeh_dev *edev __maybe_unused;\n \n-\t\tpdn = add_one_dev_pci_data(parent, NULL, i,\n+\t\tpdn = add_one_dev_pci_data(parent, i,\n \t\t\t\t\t pci_iov_virtfn_bus(pdev, i),\n \t\t\t\t\t pci_iov_virtfn_devfn(pdev, i));\n \t\tif (!pdn) {\n","prefixes":["kernel","1/5"]}