{"id":804736,"url":"http://patchwork.ozlabs.org/api/patches/804736/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/1503464171-6471-5-git-send-email-okaya@codeaurora.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1503464171-6471-5-git-send-email-okaya@codeaurora.org>","list_archive_url":null,"date":"2017-08-23T04:56:11","name":"[V12,5/5] PCI: Warn periodically while waiting for device to become ready","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"df22d47dcfd69e58263fd28ad49688f81d8430b0","submitter":{"id":67496,"url":"http://patchwork.ozlabs.org/api/people/67496/?format=json","name":"Sinan Kaya","email":"okaya@codeaurora.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/1503464171-6471-5-git-send-email-okaya@codeaurora.org/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/804736/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/804736/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"es1wXNh6\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"es1wXNh6\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=okaya@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xcZsD1djxz9s8V\n\tfor ;\n\tWed, 23 Aug 2017 14:56:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751436AbdHWE4e (ORCPT );\n\tWed, 23 Aug 2017 00:56:34 -0400","from smtp.codeaurora.org ([198.145.29.96]:53398 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753311AbdHWE4W (ORCPT\n\t); Wed, 23 Aug 2017 00:56:22 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 9E64760725; Wed, 23 Aug 2017 04:56:21 +0000 (UTC)","from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com\n\t[129.46.232.65])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\t(Authenticated sender: okaya@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id 82EAB60722;\n\tWed, 23 Aug 2017 04:56:20 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1503464181;\n\tbh=JQM9CWR6QUnkPdTtXqrc+jSkfOz/XPcx6pydBYpfI+A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=es1wXNh6B3SAnjzfIsc1VrHRI89mDavbiW383uBZ4Ye5rs+kgtgWi/J9LpTl5nQfo\n\t0nP43w7fTaqAMv5hjl/LP1301f84xIaCqAcEg4kG+XeCJrcPXf+bTVhicTjrnJW8uN\n\t1s+ubrlly6Sg9oJvQEuZnHqnS+Tz6QWDUm4fQNbM=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1503464181;\n\tbh=JQM9CWR6QUnkPdTtXqrc+jSkfOz/XPcx6pydBYpfI+A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=es1wXNh6B3SAnjzfIsc1VrHRI89mDavbiW383uBZ4Ye5rs+kgtgWi/J9LpTl5nQfo\n\t0nP43w7fTaqAMv5hjl/LP1301f84xIaCqAcEg4kG+XeCJrcPXf+bTVhicTjrnJW8uN\n\t1s+ubrlly6Sg9oJvQEuZnHqnS+Tz6QWDUm4fQNbM="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org 82EAB60722","From":"Sinan Kaya ","To":"linux-pci@vger.kernel.org, timur@codeaurora.org,\n\talex.williamson@redhat.com","Cc":"linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tSinan Kaya , Bjorn Helgaas ,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH V12 5/5] PCI: Warn periodically while waiting for device to\n\tbecome ready","Date":"Wed, 23 Aug 2017 00:56:11 -0400","Message-Id":"<1503464171-6471-5-git-send-email-okaya@codeaurora.org>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1503464171-6471-1-git-send-email-okaya@codeaurora.org>","References":"<1503464171-6471-1-git-send-email-okaya@codeaurora.org>","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"},"content":"Add a print statement in pci_bus_wait_crs() so that user observes the\nprogress of device polling instead of silently waiting for timeout to be\nreached.\n\nSigned-off-by: Sinan Kaya \n[bhelgaas: check for timeout first so we don't print \"waiting, giving up\",\nalways print time we've slept (not the actual timeout, print a \"ready\"\nmessage if we've printed a \"waiting\" message]\nSigned-off-by: Bjorn Helgaas \n---\n drivers/pci/probe.c | 16 +++++++++++++---\n 1 file changed, 13 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c\nindex 93b89dd..4b30df7 100644\n--- a/drivers/pci/probe.c\n+++ b/drivers/pci/probe.c\n@@ -1841,11 +1841,16 @@ bool pci_bus_wait_crs(struct pci_bus *bus, int devfn, u32 l, int timeout)\n \t */\n \twhile ((l & 0xffff) == 0x0001) {\n \t\tif (delay > timeout) {\n-\t\t\tprintk(KERN_WARNING \"pci %04x:%02x:%02x.%d: not responding\\n\",\n-\t\t\t pci_domain_nr(bus), bus->number, PCI_SLOT(devfn),\n-\t\t\t PCI_FUNC(devfn));\n+\t\t\tpr_warn(\"pci %04x:%02x:%02x.%d: not ready after %dms; giving up\\n\",\n+\t\t\t\tpci_domain_nr(bus), bus->number,\n+\t\t\t\tPCI_SLOT(devfn), PCI_FUNC(devfn), delay - 1);\n+\n \t\t\treturn false;\n \t\t}\n+\t\tif (delay >= 1000)\n+\t\t\tpr_info(\"pci %04x:%02x:%02x.%d: not ready after %dms; waiting\\n\",\n+\t\t\t\tpci_domain_nr(bus), bus->number,\n+\t\t\t\tPCI_SLOT(devfn), PCI_FUNC(devfn), delay - 1);\n \n \t\tmsleep(delay);\n \t\tdelay *= 2;\n@@ -1854,6 +1859,11 @@ bool pci_bus_wait_crs(struct pci_bus *bus, int devfn, u32 l, int timeout)\n \t\t\treturn false;\n \t}\n \n+\tif (delay >= 1000)\n+\t\tpr_info(\"pci %04x:%02x:%02x.%d: ready after %dms\\n\",\n+\t\t\tpci_domain_nr(bus), bus->number,\n+\t\t\tPCI_SLOT(devfn), PCI_FUNC(devfn), delay - 1);\n+\n \treturn true;\n }\n \n","prefixes":["V12","5/5"]}