{"id":803984,"url":"http://patchwork.ozlabs.org/api/patches/803984/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/patch/1503317524-21276-1-git-send-email-bhumirks@gmail.com/","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1503317524-21276-1-git-send-email-bhumirks@gmail.com>","list_archive_url":null,"date":"2017-08-21T12:12:04","name":"i2c: busses: make i2c_adapter_quirks const","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"badc901bd3ba46ab076b86728151206e296324ff","submitter":{"id":69882,"url":"http://patchwork.ozlabs.org/api/people/69882/?format=json","name":"Bhumika Goyal","email":"bhumirks@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/1503317524-21276-1-git-send-email-bhumirks@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/803984/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/803984/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XOHBedcd\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xbXd10NVsz9sR8\n\tfor ;\n\tMon, 21 Aug 2017 22:12:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752787AbdHUMMV (ORCPT );\n\tMon, 21 Aug 2017 08:12:21 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:34872 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752462AbdHUMMU (ORCPT\n\t); Mon, 21 Aug 2017 08:12:20 -0400","by mail-pg0-f65.google.com with SMTP id m133so4205036pga.2;\n\tMon, 21 Aug 2017 05:12:19 -0700 (PDT)","from gmail.com ([117.196.124.142])\n\tby smtp.gmail.com with ESMTPSA id\n\ta21sm14577437pfg.18.2017.08.21.05.12.11\n\t(version=TLS1 cipher=AES128-SHA bits=128/128);\n\tMon, 21 Aug 2017 05:12:18 -0700 (PDT)","by gmail.com (sSMTP sendmail emulation);\n\tMon, 21 Aug 2017 17:42:08 +0530"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=owuDdvIGIWFnKW+lI43QGcauT+SPGsue7IkvK8sbNtA=;\n\tb=XOHBedcdpKMkaZ1sdz/h/OT8BeaviuvwphfxsNF2s42YRAV2+iA/DarTgLAdRePIbe\n\twjFLY5ztRDVriRSN2xjwPhgyJCMKVlRz/JL58HREay3z4/wBcO37zoKUm/W61P/XRoCY\n\tEBnzZdoTPfYWjoZ6NN/IUHTqAWB3It2N1nx9x5nStp0qbkc5kHFqNwQMKA7Dx1AXFIbn\n\tKbkLQ6tCTgwaH1r6xQV2uRtdqMZtRyXxZWGq6K8N+wo/7XDPC/Fy2oY8SutSlxthaXs9\n\t4cJlN4n4PgYyXT8/og0vqRbysNGDpfn+6Jj7ttSJnOUJiK3uZtFN/6R878MavZWwqOLO\n\tjrIQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=owuDdvIGIWFnKW+lI43QGcauT+SPGsue7IkvK8sbNtA=;\n\tb=CTkbef0mckskqaU1JlVzIkAtn7oESwfCVC4lPi+bswsk/YMtjHFSwhVoChNgI4dx08\n\t2KO1hDNGwAHWNLISQQH35Jz/FEm+gT1hA5ubJZVVAlMW0eA0WJg5yB21jgvaQDzuUB0i\n\t0KaUXwNee92Eva1lL0HCz6PdhMhL9eO6DmJaDSgeNwmwwBB5IGynqwYFTLpMUHPKMrI0\n\tqC29vHLZtukf7lyG27+wguxNScZYUc34kmb3Kvwbd8u9uthSGZUUIapc1L9Ig74A+wsY\n\tlYGTwlOEukxbzblZuID60733308NSUGIUBOijTaaG9fXZhu8NeL8Yyzhc33Lew449llo\n\tv1YA==","X-Gm-Message-State":"AHYfb5iuCAazgK4zU5MD8cSgqvDVKS3opuvF6Xf7UyC6tg2WW9xfWO2b\n\tKdVoMjHUetPwWA==","X-Received":"by 10.98.158.133 with SMTP id f5mr1757691pfk.295.1503317539252; \n\tMon, 21 Aug 2017 05:12:19 -0700 (PDT)","From":"Bhumika Goyal ","To":"julia.lawall@lip6.fr, ludovic.desroches@microchip.com,\n\twsa@the-dreams.de, jochen@scram.de, vadimp@mellanox.com,\n\tmichaelsh@mellanox.com, benh@kernel.crashing.org, paulus@samba.org,\n\tmpe@ellerman.id.au, andy.gross@linaro.org, david.brown@linaro.org,\n\tldewangan@nvidia.com, thierry.reding@gmail.com,\n\tjonathanh@nvidia.com, linux-i2c@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org","Cc":"Bhumika Goyal ","Subject":"[PATCH] i2c: busses: make i2c_adapter_quirks const","Date":"Mon, 21 Aug 2017 17:42:04 +0530","Message-Id":"<1503317524-21276-1-git-send-email-bhumirks@gmail.com>","X-Mailer":"git-send-email 1.9.1","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"},"content":"Make these const as they are only stored as a reference in the quirks\nfield of an i2c_adapter structure, which is const.\n\nDone using Coccinelle:\n@match disable optional_qualifier@\nidentifier s;\n@@\nstatic struct i2c_adapter_quirks s = {...};\n\n@ref@\nposition p;\nidentifier match.s;\n@@\ns@p\n\n@good1@\nidentifier y;\nposition ref.p;\nidentifier match.s;\n@@\nstruct i2c_adapter y = {...,.quirks=&s@p,...};\n\n@good2@\nstruct i2c_adapter y;\nidentifier match.s;\nposition ref.p;\n@@\ny.quirks = &s@p\n\n@bad depends on !good1 && !good2@\nposition ref.p;\nidentifier match.s;\n@@\ns@p\n\n@depends on forall !bad disable optional_qualifier@\nidentifier match.s;\n@@\nstatic\n+ const\nstruct i2c_adapter_quirks s;\n\nSigned-off-by: Bhumika Goyal \n---\n drivers/i2c/busses/i2c-at91.c | 2 +-\n drivers/i2c/busses/i2c-cpm.c | 2 +-\n drivers/i2c/busses/i2c-mlxcpld.c | 2 +-\n drivers/i2c/busses/i2c-opal.c | 2 +-\n drivers/i2c/busses/i2c-powermac.c | 2 +-\n drivers/i2c/busses/i2c-qup.c | 2 +-\n drivers/i2c/busses/i2c-tegra.c | 2 +-\n 7 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c\nindex 38dd61d..bfd1fdf 100644\n--- a/drivers/i2c/busses/i2c-at91.c\n+++ b/drivers/i2c/busses/i2c-at91.c\n@@ -809,7 +809,7 @@ static int at91_twi_xfer(struct i2c_adapter *adap, struct i2c_msg *msg, int num)\n * The hardware can handle at most two messages concatenated by a\n * repeated start via it's internal address feature.\n */\n-static struct i2c_adapter_quirks at91_twi_quirks = {\n+static const struct i2c_adapter_quirks at91_twi_quirks = {\n \t.flags = I2C_AQ_COMB | I2C_AQ_COMB_WRITE_FIRST | I2C_AQ_COMB_SAME_ADDR,\n \t.max_comb_1st_msg_len = 3,\n };\ndiff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c\nindex d89bde2..8a8ca94 100644\n--- a/drivers/i2c/busses/i2c-cpm.c\n+++ b/drivers/i2c/busses/i2c-cpm.c\n@@ -413,7 +413,7 @@ static u32 cpm_i2c_func(struct i2c_adapter *adap)\n };\n \n /* CPM_MAX_READ is also limiting writes according to the code! */\n-static struct i2c_adapter_quirks cpm_i2c_quirks = {\n+static const struct i2c_adapter_quirks cpm_i2c_quirks = {\n \t.max_num_msgs = CPM_MAXBD,\n \t.max_read_len = CPM_MAX_READ,\n \t.max_write_len = CPM_MAX_READ,\ndiff --git a/drivers/i2c/busses/i2c-mlxcpld.c b/drivers/i2c/busses/i2c-mlxcpld.c\nindex d271e6a..4c28fa2 100644\n--- a/drivers/i2c/busses/i2c-mlxcpld.c\n+++ b/drivers/i2c/busses/i2c-mlxcpld.c\n@@ -433,7 +433,7 @@ static u32 mlxcpld_i2c_func(struct i2c_adapter *adap)\n \t.functionality\t= mlxcpld_i2c_func\n };\n \n-static struct i2c_adapter_quirks mlxcpld_i2c_quirks = {\n+static const struct i2c_adapter_quirks mlxcpld_i2c_quirks = {\n \t.flags = I2C_AQ_COMB_WRITE_THEN_READ,\n \t.max_read_len = MLXCPLD_I2C_DATA_REG_SZ - MLXCPLD_I2C_MAX_ADDR_LEN,\n \t.max_write_len = MLXCPLD_I2C_DATA_REG_SZ,\ndiff --git a/drivers/i2c/busses/i2c-opal.c b/drivers/i2c/busses/i2c-opal.c\nindex 11e2a1f..0aabb7e 100644\n--- a/drivers/i2c/busses/i2c-opal.c\n+++ b/drivers/i2c/busses/i2c-opal.c\n@@ -204,7 +204,7 @@ static u32 i2c_opal_func(struct i2c_adapter *adapter)\n * For two messages, we basically support simple smbus transactions of a\n * write-then-anything.\n */\n-static struct i2c_adapter_quirks i2c_opal_quirks = {\n+static const struct i2c_adapter_quirks i2c_opal_quirks = {\n \t.flags = I2C_AQ_COMB | I2C_AQ_COMB_WRITE_FIRST | I2C_AQ_COMB_SAME_ADDR,\n \t.max_comb_1st_msg_len = 4,\n };\ndiff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c\nindex ef9c858..f2a2067 100644\n--- a/drivers/i2c/busses/i2c-powermac.c\n+++ b/drivers/i2c/busses/i2c-powermac.c\n@@ -197,7 +197,7 @@ static u32 i2c_powermac_func(struct i2c_adapter * adapter)\n \t.functionality\t= i2c_powermac_func,\n };\n \n-static struct i2c_adapter_quirks i2c_powermac_quirks = {\n+static const struct i2c_adapter_quirks i2c_powermac_quirks = {\n \t.max_num_msgs = 1,\n };\n \ndiff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c\nindex 1902d8a..08f8e01 100644\n--- a/drivers/i2c/busses/i2c-qup.c\n+++ b/drivers/i2c/busses/i2c-qup.c\n@@ -1396,7 +1396,7 @@ static u32 qup_i2c_func(struct i2c_adapter *adap)\n * the end of the read, the length of the read is specified as one byte\n * which limits the possible read to 256 (QUP_READ_LIMIT) bytes.\n */\n-static struct i2c_adapter_quirks qup_i2c_quirks = {\n+static const struct i2c_adapter_quirks qup_i2c_quirks = {\n \t.max_read_len = QUP_READ_LIMIT,\n };\n \ndiff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c\nindex a238844..60292d2 100644\n--- a/drivers/i2c/busses/i2c-tegra.c\n+++ b/drivers/i2c/busses/i2c-tegra.c\n@@ -793,7 +793,7 @@ static void tegra_i2c_parse_dt(struct tegra_i2c_dev *i2c_dev)\n };\n \n /* payload size is only 12 bit */\n-static struct i2c_adapter_quirks tegra_i2c_quirks = {\n+static const struct i2c_adapter_quirks tegra_i2c_quirks = {\n \t.max_read_len = 4096,\n \t.max_write_len = 4096,\n };\n","prefixes":[]}