{"id":800942,"url":"http://patchwork.ozlabs.org/api/patches/800942/?format=json","web_url":"http://patchwork.ozlabs.org/project/kvm-ppc/patch/20170813013346.14002-1-npiggin@gmail.com/","project":{"id":23,"url":"http://patchwork.ozlabs.org/api/projects/23/?format=json","name":"KVM PowerPC development","link_name":"kvm-ppc","list_id":"kvm-ppc.vger.kernel.org","list_email":"kvm-ppc@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170813013346.14002-1-npiggin@gmail.com>","list_archive_url":null,"date":"2017-08-13T01:33:38","name":"[v2,1/9] KVM: PPC: Book3S HV: Fix H_REGISTER_VPA VPA size validation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"2b21e4884f9c0a24a0ceb91a99936ec796e070a0","submitter":{"id":69518,"url":"http://patchwork.ozlabs.org/api/people/69518/?format=json","name":"Nicholas Piggin","email":"npiggin@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/kvm-ppc/patch/20170813013346.14002-1-npiggin@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/800942/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/800942/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=kvm-ppc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lgG3RVp9\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xVLr65r6qz9t2h\n\tfor ;\n\tSun, 13 Aug 2017 11:34:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752221AbdHMBeN (ORCPT );\n\tSat, 12 Aug 2017 21:34:13 -0400","from mail-pf0-f193.google.com ([209.85.192.193]:36009 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752207AbdHMBeN (ORCPT\n\t); Sat, 12 Aug 2017 21:34:13 -0400","by mail-pf0-f193.google.com with SMTP id t83so6796015pfj.3\n\tfor ; Sat, 12 Aug 2017 18:34:12 -0700 (PDT)","from roar.local0.net (203-219-56-202.tpgi.com.au. [203.219.56.202])\n\tby smtp.gmail.com with ESMTPSA id\n\tu69sm7776237pfa.70.2017.08.12.18.34.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 12 Aug 2017 18:34:11 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=UnRL5Cao+Y9WhJ1E2YctDlj7HJYrL5YenbulIdlo9jU=;\n\tb=lgG3RVp9i4koqFXylqiLCAuozg+51oCqW1c/+i2mrfo2ACg8Pe0ZDSDCvJssI90xmU\n\tzSZ6f81AOU4z6sM+GDHuv82GBzIwdxY6GM3zj9i0VeqpVdFFWMZb9Fir4n8S3rN4XRMU\n\tEV4LRd8Hf3OdgXE0QCaeQdYSlMFf7dYiccxtYdufT+C1R6DvzbpJKAolLlmpua2oLUps\n\tndsp4anPywwBTLBKTUGsdqTpX1HKdRLhMbN3tVzXziQ2sWieWGKnfuxXWaM7JRBlvT9C\n\tbs9AfjukXVJRVv3zcZ64AdrKGsNql7zB6+z5Xw2s5IwAt5dcSmeb0p9r1ff+CHCCLeSw\n\tJ3XA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=UnRL5Cao+Y9WhJ1E2YctDlj7HJYrL5YenbulIdlo9jU=;\n\tb=CDNoquUottnBmpQ6jrJlFvOIdF0cWLzTTavYJywuaV+aHH95rtHzkWqQsQMz77OpXG\n\tE33hg1/qA9JwMCEltKuoxYSEO9M+JB+hSY7A7LJKd/4Ri5A2VPhOZOUzgn5PnhJ8xbsv\n\tqMh6fYIKUqduszkyung+U7PbNKqINQ9ElVLYADmShs7vp75pjTl4B13t2tlA9lis6SUB\n\tdtByoOv+oyhD5OauiB31Zb/XDc2P2yUJdkNjNQzDh6H1fQb2gHqA+PC2U2q/tav1AJyS\n\tFjraCWIGL2kexnZrbKAF7CIcix2Qpo2FuBEYa+hpQIVNAPb5nESMrinwmZas1eCb5AeZ\n\tzlqQ==","X-Gm-Message-State":"AHYfb5gzsocXYNDmAZ9ow7XyGfGwDSKjaBK1ub13MzGAtUvCkiyrLOGl\n\tVUg4cYyTcACrKA==","X-Received":"by 10.99.101.132 with SMTP id z126mr19624373pgb.64.1502588052558;\n\tSat, 12 Aug 2017 18:34:12 -0700 (PDT)","From":"Nicholas Piggin ","To":"linuxppc-dev@lists.ozlabs.org","Cc":"Nicholas Piggin , kvm-ppc@vger.kernel.org","Subject":"[PATCH v2 1/9] KVM: PPC: Book3S HV: Fix H_REGISTER_VPA VPA size\n\tvalidation","Date":"Sun, 13 Aug 2017 11:33:38 +1000","Message-Id":"<20170813013346.14002-1-npiggin@gmail.com>","X-Mailer":"git-send-email 2.13.3","In-Reply-To":"<20170812113416.15978-1-npiggin@gmail.com>","References":"<20170812113416.15978-1-npiggin@gmail.com>","Sender":"kvm-ppc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"kvm-ppc@vger.kernel.org"},"content":"KVM currently validates the size of the VPA registered by the client\nagainst sizeof(struct lppaca), however we align (and therefore size)\nthat struct to 1kB to avoid crossing a 4kB boundary in the client.\n\nPAPR calls for sizes >= 640 bytes to be accepted. Hard code this with\na comment.\n\nSigned-off-by: Nicholas Piggin \n---\n arch/powerpc/kvm/book3s_hv.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c\nindex 359c79cdf0cc..1182cfd79857 100644\n--- a/arch/powerpc/kvm/book3s_hv.c\n+++ b/arch/powerpc/kvm/book3s_hv.c\n@@ -485,7 +485,13 @@ static unsigned long do_h_register_vpa(struct kvm_vcpu *vcpu,\n \n \tswitch (subfunc) {\n \tcase H_VPA_REG_VPA:\t\t/* register VPA */\n-\t\tif (len < sizeof(struct lppaca))\n+\t\t/*\n+\t\t * The size of our lppaca is 1kB because of the way we align\n+\t\t * it for the guest to avoid crossing a 4kB boundary. We only\n+\t\t * use 640 bytes of the structure though, so we should accept\n+\t\t * clients that set a size of 640.\n+\t\t */\n+\t\tif (len < 640)\n \t\t\tbreak;\n \t\tvpap = &tvcpu->arch.vpa;\n \t\terr = 0;\n","prefixes":["v2","1/9"]}