{"id":800420,"url":"http://patchwork.ozlabs.org/api/patches/800420/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1502432577-5911-1-git-send-email-alistair@popple.id.au/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<1502432577-5911-1-git-send-email-alistair@popple.id.au>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/1502432577-5911-1-git-send-email-alistair@popple.id.au/","date":"2017-08-11T06:22:56","name":"[1/2] powerpc/powernv/npu: Move tlb flush before launching ATSD","commit_ref":"bab9f954aaf352127725a9b7920226abdb65b604","pull_url":null,"state":"accepted","archived":false,"hash":"ae634e465f14956eb4464cc8f5b51662b8f6e5a7","submitter":{"id":24781,"url":"http://patchwork.ozlabs.org/api/people/24781/?format=json","name":"Alistair Popple","email":"alistair@popple.id.au"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1502432577-5911-1-git-send-email-alistair@popple.id.au/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/800420/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/800420/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xTFPd6q1Pz9t16\n\tfor ;\n\tFri, 11 Aug 2017 16:25:57 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xTFPd5ydVzDrGk\n\tfor ;\n\tFri, 11 Aug 2017 16:25:57 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xTFM023bFzDr38\n\tfor ;\n\tFri, 11 Aug 2017 16:23:40 +1000 (AEST)","by ozlabs.org (Postfix)\n\tid 3xTFM003fVz9t36; Fri, 11 Aug 2017 16:23:40 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xTFLz5RQWz9t16;\n\tFri, 11 Aug 2017 16:23:39 +1000 (AEST)"],"From":"Alistair Popple ","To":"mpe@ellerman.id.au","Subject":"[PATCH 1/2] powerpc/powernv/npu: Move tlb flush before launching\n\tATSD","Date":"Fri, 11 Aug 2017 16:22:56 +1000","Message-Id":"<1502432577-5911-1-git-send-email-alistair@popple.id.au>","X-Mailer":"git-send-email 2.1.4","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alistair Popple , stable@vger.kernel.org,\n\tarbab@linux.vnet.ibm.com, linuxppc-dev@ozlabs.org, sbaskaran@nvidia.com, \n\tfbarrat@linux.vnet.ibm.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"The nest mmu tlb flush needs to happen before the GPU translation shootdown\nis launched to avoid the GPU refilling its tlb with stale nmmu translations\nprior to the nmmu flush completing.\n\nSigned-off-by: Alistair Popple \nCc: stable@vger.kernel.org\n---\n arch/powerpc/platforms/powernv/npu-dma.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/arch/powerpc/platforms/powernv/npu-dma.c b/arch/powerpc/platforms/powernv/npu-dma.c\nindex b5d960d..3d4f879 100644\n--- a/arch/powerpc/platforms/powernv/npu-dma.c\n+++ b/arch/powerpc/platforms/powernv/npu-dma.c\n@@ -546,6 +546,12 @@ static void mmio_invalidate(struct npu_context *npu_context, int va,\n \tunsigned long pid = npu_context->mm->context.id;\n \n \t/*\n+\t * Unfortunately the nest mmu does not support flushing specific\n+\t * addresses so we have to flush the whole mm.\n+\t */\n+\tflush_tlb_mm(npu_context->mm);\n+\n+\t/*\n \t * Loop over all the NPUs this process is active on and launch\n \t * an invalidate.\n \t */\n@@ -576,12 +582,6 @@ static void mmio_invalidate(struct npu_context *npu_context, int va,\n \t\t}\n \t}\n \n-\t/*\n-\t * Unfortunately the nest mmu does not support flushing specific\n-\t * addresses so we have to flush the whole mm.\n-\t */\n-\tflush_tlb_mm(npu_context->mm);\n-\n \tmmio_invalidate_wait(mmio_atsd_reg, flush);\n \tif (flush)\n \t\t/* Wait for the flush to complete */\n","prefixes":["1/2"]}