{"id":798433,"url":"http://patchwork.ozlabs.org/api/patches/798433/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170806181009.30129-1-robdclark@gmail.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170806181009.30129-1-robdclark@gmail.com>","list_archive_url":null,"date":"2017-08-06T18:10:07","name":"[U-Boot,v2] efi_loader: LocateHandle should return EFI_NOT_FOUND if none found","commit_ref":"796a78cbe5676fc7562b50c7a0191fa56c8c4772","pull_url":null,"state":"accepted","archived":false,"hash":"a96c4d966075a4463ed311c99cbe383eb3e450ac","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/?format=json","name":"Rob Clark","email":"robdclark@gmail.com"},"delegate":{"id":3400,"url":"http://patchwork.ozlabs.org/api/users/3400/?format=json","username":"agraf","first_name":"Alexander","last_name":"Graf","email":"agraf@suse.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170806181009.30129-1-robdclark@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/798433/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/798433/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SNNsN+EO\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xQTGr3pMTz9tWn\n\tfor ;\n\tMon, 7 Aug 2017 04:10:28 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1DC4CC22007; Sun, 6 Aug 2017 18:10:19 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 07157C21FBC;\n\tSun, 6 Aug 2017 18:10:17 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 06FB9C21FBC; Sun, 6 Aug 2017 18:10:14 +0000 (UTC)","from mail-qk0-f194.google.com (mail-qk0-f194.google.com\n\t[209.85.220.194])\n\tby lists.denx.de (Postfix) with ESMTPS id 7A10CC21DD4\n\tfor ; Sun, 6 Aug 2017 18:10:14 +0000 (UTC)","by mail-qk0-f194.google.com with SMTP id x77so5894634qka.4\n\tfor ; Sun, 06 Aug 2017 11:10:14 -0700 (PDT)","from localhost ([2601:184:4780:aac0:25f8:dd96:a084:785a])\n\tby smtp.gmail.com with ESMTPSA id\n\tl47sm4675124qtc.64.2017.08.06.11.10.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 06 Aug 2017 11:10:11 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=VtY+DeZh0DCUBrZvIBR7X+Lc6E+ZenwI3ue3zbdHav4=;\n\tb=SNNsN+EO6N/HtwzUlULNsZukpScMlhX4ecVUrk7XaLWGZyTeJgnLXCWSEjq2y7md2r\n\tC+wK9lyet1tAQwIBfy+PkK1a7EmoHziZNMDODkmspMVAcuwJ/FYjgeDsO+/viqWO499g\n\tKOI+zewfTOACajDfV/e0CFZtwXmemCUiVd7kTVIqRRl3kwYwNFdCBLj17BcLLw0M+81r\n\tRfQDetDOmHmhqnSQUGB0LjR2DMx7DmoAoCovLeSQu40TgKOnWmQEs4gJQfoTBQKJT4V4\n\td1qw1Eo1fEhl2SSAM6m2+vbyLSPkrS82j28QL/0W2Wa1s7lfODWoMd3re/1H3s29lzp6\n\t9oMA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=VtY+DeZh0DCUBrZvIBR7X+Lc6E+ZenwI3ue3zbdHav4=;\n\tb=m2ZLUBuWBsBQvWJtyqKsAxUjMfgrd5LHr3/wrQI+xhWaE7lUqy5To6/somtPtvjiII\n\tsLnNzE8yqIs8wQm8wp9x2K5vP6Ue9aCUrNUybY3tSozL3CqJ4ZeccOuzV+dmiI0I2ssL\n\taN1rWqBA6xV6kQS38sCwDesuO/CE0K5/9/aucIyZ661qc09eYJt6J3hzfXHUiabYvuXO\n\tO9Acg7VPHfRGrUbxvUdu7quRXR2925b6FUwigr0+qzQpmxNBoDFGgxEkgJVxqKkExo+u\n\t2aImIL+ylt8szcQsMZH3FqhbSsM08+f6fXDdjr1oAFGb/bKY0tZTTJOx559YSaA7TWOs\n\tQsSQ==","X-Gm-Message-State":"AHYfb5hgmUNd9PagkPxEkDOyZhbq6HCLVQTyGW4v7dokmTWq3O4d643t\n\tkcOCu8Cz6jHltjXdtf0=","X-Received":"by 10.55.2.132 with SMTP id v4mr11013812qkg.313.1502043012844;\n\tSun, 06 Aug 2017 11:10:12 -0700 (PDT)","From":"Rob Clark ","To":"U-Boot Mailing List ","Date":"Sun, 6 Aug 2017 14:10:07 -0400","Message-Id":"<20170806181009.30129-1-robdclark@gmail.com>","X-Mailer":"git-send-email 2.13.0","Subject":"[U-Boot] [PATCH v2] efi_loader: LocateHandle should return\n\tEFI_NOT_FOUND if none found","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"Spotted this debugging OpenBSD's bootloader in qemu. (Wouldn't really\nfix anything, the problem was not having any disks, but we should\nprobably return the correct error code.)\n\nSigned-off-by: Rob Clark \n---\nv2: early-return in the EFI_NOT_FOUND case, as suggested by Heinrich\n\n lib/efi_loader/efi_boottime.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\nindex 5ff2d2d4b0..93ca05f3ef 100644\n--- a/lib/efi_loader/efi_boottime.c\n+++ b/lib/efi_loader/efi_boottime.c\n@@ -633,6 +633,10 @@ static efi_status_t EFIAPI efi_locate_handle(\n \t\treturn EFI_BUFFER_TOO_SMALL;\n \t}\n \n+\t*buffer_size = size;\n+\tif (size == 0)\n+\t\treturn EFI_NOT_FOUND;\n+\n \t/* Then fill the array */\n \tlist_for_each(lhandle, &efi_obj_list) {\n \t\tstruct efi_object *efiobj;\n@@ -642,7 +646,6 @@ static efi_status_t EFIAPI efi_locate_handle(\n \t\t}\n \t}\n \n-\t*buffer_size = size;\n \treturn EFI_SUCCESS;\n }\n \n","prefixes":["U-Boot","v2"]}