{"id":797747,"url":"http://patchwork.ozlabs.org/api/patches/797747/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170804115209.18732-1-robdclark@gmail.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170804115209.18732-1-robdclark@gmail.com>","list_archive_url":null,"date":"2017-08-04T11:52:03","name":"[U-Boot] efi_loader: GOP fix for no display","commit_ref":"3d9880784ed5cd503b0d69128ea1841102ff522e","pull_url":null,"state":"accepted","archived":false,"hash":"3aa6ee3211346109a8601adc645719761a1cb442","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/?format=json","name":"Rob Clark","email":"robdclark@gmail.com"},"delegate":{"id":3400,"url":"http://patchwork.ozlabs.org/api/users/3400/?format=json","username":"agraf","first_name":"Alexander","last_name":"Graf","email":"agraf@suse.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170804115209.18732-1-robdclark@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/797747/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/797747/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MEDvNJZm\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xP4zX0NWdz9s8P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  4 Aug 2017 21:52:24 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C0DABC21DB5; Fri,  4 Aug 2017 11:52:19 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D0587C21C2B;\n\tFri,  4 Aug 2017 11:52:17 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid B7439C21C2B; Fri,  4 Aug 2017 11:52:16 +0000 (UTC)","from mail-qt0-f196.google.com (mail-qt0-f196.google.com\n\t[209.85.216.196])\n\tby lists.denx.de (Postfix) with ESMTPS id 3AF14C21C26\n\tfor <u-boot@lists.denx.de>; Fri,  4 Aug 2017 11:52:16 +0000 (UTC)","by mail-qt0-f196.google.com with SMTP id u19so1310858qtc.0\n\tfor <u-boot@lists.denx.de>; Fri, 04 Aug 2017 04:52:16 -0700 (PDT)","from localhost ([2601:184:4780:aac0:25f8:dd96:a084:785a])\n\tby smtp.gmail.com with ESMTPSA id\n\ts7sm147886qks.44.2017.08.04.04.52.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 04 Aug 2017 04:52:13 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=iNp9y7GbvnYQrVe4tYjClqujrPrX/1mRWtCkjmPGFQ0=;\n\tb=MEDvNJZmaRc1D03Iai7GGmlxag5nVIFeA/4FGn3NIbeHHMMbfIo+dlJ9STIxf9l503\n\tjz1RQWhqs4QR3pMiI7jwP4YMZf5NGasR8ToJG1Ribc8735RDzZU7KnsUujEJCMHigQW+\n\tivDNJfiTAcohrerGTZssROSZs1+5rY0VOU4ov1ftlNCJyU/PMBhZpN7BuGcdZuzcqALl\n\t61jPeKtuKj67jXjMPzgnTceJTzvXiUaJPsnwsW0qPoKbiMW1YhSVcClUZLa3uhOHVNwX\n\tPrDrhQ/fywQBn7Rh5aWCDDjC7PIPfT2/CCR3KegqWLWXvBNuSUY3gnZqZCnGSAoH/3uV\n\tzxjA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=iNp9y7GbvnYQrVe4tYjClqujrPrX/1mRWtCkjmPGFQ0=;\n\tb=V20bCo6TwGXxbFC+g2/jGt8ytLy485Gkn7RWIzfjZHbB2IqS+gcdCeW5oG2QPz9JOb\n\t7tsLSPpm3RM0m8aJh0EVRqcISWGoeMXOMO8YpQ1HpzJsX6ayHCff18i54lktZIhBsv33\n\txoXLDM/9e/M/yPPEJu0H4Da9o70oJOt2toMZvH1820tuJ8inUHHBPfBThQidLGJKmV1T\n\tX0S2yXOawXNMgYPTTi3WqUyaRNpWMyJuSCF/F7c5yn5lep6frZxJpzB1XiOyDbXCbM1i\n\toDS9S4SvpxTAfyUoR+K8v6v/pjBiudSDvB1w54FgmBa22itt95ejKfb4vWPbLNXwDWkz\n\tQZgA==","X-Gm-Message-State":"AHYfb5hj/SMbWrFiXuycLqQdjrv8KHrbuGr9zARv/aGah6uKNfN60ksa\n\tQPIXXboLsLm1TU6AZ2Y=","X-Received":"by 10.200.36.156 with SMTP id s28mr2534648qts.277.1501847534746; \n\tFri, 04 Aug 2017 04:52:14 -0700 (PDT)","From":"Rob Clark <robdclark@gmail.com>","To":"U-Boot Mailing List <u-boot@lists.denx.de>","Date":"Fri,  4 Aug 2017 07:52:03 -0400","Message-Id":"<20170804115209.18732-1-robdclark@gmail.com>","X-Mailer":"git-send-email 2.13.0","Subject":"[U-Boot] [PATCH] efi_loader: GOP fix for no display","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"},"content":"uclass_first_device() returns 0 if there is no device, but error if\nthere is a device that failed to probe.\n\nSigned-off-by: Rob Clark <robdclark@gmail.com>\n---\n lib/efi_loader/efi_gop.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c\nindex e063e0c79b..411a8c9226 100644\n--- a/lib/efi_loader/efi_gop.c\n+++ b/lib/efi_loader/efi_gop.c\n@@ -137,7 +137,7 @@ int efi_gop_register(void)\n \tstruct udevice *vdev;\n \n \t/* We only support a single video output device for now */\n-\tif (uclass_first_device(UCLASS_VIDEO, &vdev))\n+\tif (uclass_first_device(UCLASS_VIDEO, &vdev) || !vdev)\n \t\treturn -1;\n \n \tstruct video_priv *priv = dev_get_uclass_priv(vdev);\n","prefixes":["U-Boot"]}