{"id":787541,"url":"http://patchwork.ozlabs.org/api/patches/787541/?format=json","web_url":"http://patchwork.ozlabs.org/project/kvm-ppc/patch/20170713073849.tj6jqmhliyjmn3zi@mwanda/","project":{"id":23,"url":"http://patchwork.ozlabs.org/api/projects/23/?format=json","name":"KVM PowerPC development","link_name":"kvm-ppc","list_id":"kvm-ppc.vger.kernel.org","list_email":"kvm-ppc@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170713073849.tj6jqmhliyjmn3zi@mwanda>","list_archive_url":null,"date":"2017-07-13T07:38:49","name":"[2/2] KVM: PPC: e500mc: Fix a NULL dereference","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"63bc6d79ccef76e5ef269de780e28fbc3781ad75","submitter":{"id":9327,"url":"http://patchwork.ozlabs.org/api/people/9327/?format=json","name":"Dan Carpenter","email":"dan.carpenter@oracle.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/kvm-ppc/patch/20170713073849.tj6jqmhliyjmn3zi@mwanda/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/787541/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/787541/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3x7SPm2Cwjz9s74\n\tfor ;\n\tThu, 13 Jul 2017 17:39:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751197AbdGMHjV (ORCPT );\n\tThu, 13 Jul 2017 03:39:21 -0400","from aserp1040.oracle.com ([141.146.126.69]:24852 \"EHLO\n\taserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751165AbdGMHjU (ORCPT\n\t); Thu, 13 Jul 2017 03:39:20 -0400","from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v6D7cxsr007818\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 13 Jul 2017 07:38:59 GMT","from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n\tby userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv6D7cwMW015395\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 13 Jul 2017 07:38:58 GMT","from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7])\n\tby aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v6D7cwj4001182; \n\tThu, 13 Jul 2017 07:38:58 GMT","from mwanda (/197.254.35.146)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 13 Jul 2017 00:38:57 -0700"],"Date":"Thu, 13 Jul 2017 10:38:49 +0300","From":"Dan Carpenter ","To":"Alexander Graf ","Cc":"Paolo Bonzini ,\n\tRadim =?utf-8?B?S3LEjW3DocWZ?= ,\n\tBenjamin Herrenschmidt ,\n\tPaul Mackerras ,\n\tMichael Ellerman , kvm-ppc@vger.kernel.org,\n\tkvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tkernel-janitors@vger.kernel.org","Subject":"[PATCH 2/2] KVM: PPC: e500mc: Fix a NULL dereference","Message-ID":"<20170713073849.tj6jqmhliyjmn3zi@mwanda>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","X-Mailer":"git-send-email haha only kidding","User-Agent":"NeoMutt/20170113 (1.7.2)","X-Source-IP":"userv0021.oracle.com [156.151.31.71]","Sender":"kvm-ppc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"kvm-ppc@vger.kernel.org"},"content":"We should set \"err = -ENOMEM;\", otherwise it means we're returning\nERR_PTR(0) which is NULL. It results in a NULL pointer dereference in\nthe caller.\n\nSigned-off-by: Dan Carpenter \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe kvm-ppc\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","diff":"diff --git a/arch/powerpc/kvm/e500mc.c b/arch/powerpc/kvm/e500mc.c\nindex f48a0c22e8f9..d0b6b5788afc 100644\n--- a/arch/powerpc/kvm/e500mc.c\n+++ b/arch/powerpc/kvm/e500mc.c\n@@ -331,8 +331,10 @@ static struct kvm_vcpu *kvmppc_core_vcpu_create_e500mc(struct kvm *kvm,\n \t\tgoto uninit_vcpu;\n \n \tvcpu->arch.shared = (void *)__get_free_page(GFP_KERNEL | __GFP_ZERO);\n-\tif (!vcpu->arch.shared)\n+\tif (!vcpu->arch.shared) {\n+\t\terr = -ENOMEM;\n \t\tgoto uninit_tlb;\n+\t}\n \n \treturn vcpu;\n \n","prefixes":["2/2"]}