{"id":787390,"url":"http://patchwork.ozlabs.org/api/patches/787390/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170712094614.76501-7-alice.michael@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170712094614.76501-7-alice.michael@intel.com>","list_archive_url":null,"date":"2017-07-12T09:46:10","name":"[next,S75-V3,07/11] i40e: Use correct flag to enable egress traffic for unicast promisc","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f4e4d8f667943177f2c02cb2cd4c54f4e697c7a0","submitter":{"id":71123,"url":"http://patchwork.ozlabs.org/api/people/71123/?format=json","name":"Michael, Alice","email":"alice.michael@intel.com"},"delegate":{"id":68,"url":"http://patchwork.ozlabs.org/api/users/68/?format=json","username":"jtkirshe","first_name":"Jeff","last_name":"Kirsher","email":"jeffrey.t.kirsher@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170712094614.76501-7-alice.michael@intel.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/787390/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/787390/checks/","tags":{},"related":[],"headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x761l6lZJz9s3T\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 13 Jul 2017 03:50:51 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E654A30939;\n\tWed, 12 Jul 2017 17:50:49 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hK-iP2P3qu6o; Wed, 12 Jul 2017 17:50:47 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id DB9AA30916;\n\tWed, 12 Jul 2017 17:50:46 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 874311C4121\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:43 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 81D1987ECD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:43 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JquoANDcesSR for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:42 +0000 (UTC)","from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 87EFA87EC9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:42 +0000 (UTC)","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga104.jf.intel.com with ESMTP; 12 Jul 2017 10:50:41 -0700","from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby FMSMGA003.fm.intel.com with ESMTP; 12 Jul 2017 10:50:41 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.40,350,1496127600\"; d=\"scan'208\";a=\"878118680\"","From":"Alice Michael <alice.michael@intel.com>","To":"alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org","Date":"Wed, 12 Jul 2017 05:46:10 -0400","Message-Id":"<20170712094614.76501-7-alice.michael@intel.com>","X-Mailer":"git-send-email 2.9.3","In-Reply-To":"<20170712094614.76501-1-alice.michael@intel.com>","References":"<20170712094614.76501-1-alice.michael@intel.com>","Cc":"Akeem G Abodunrin <akeem.g.abodunrin@intel.com>","Subject":"[Intel-wired-lan] [next PATCH S75-V3 07/11] i40e: Use correct flag\n\tto enable egress traffic for unicast promisc","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"},"content":"From: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>\n\nAlbeit, we usually set true promiscuous mode for both multicast and\nunicast at the same time - however, it is possible to set it\nindividually, so using allmulti flag which is only for allmulticast might\ncaused unwanted behavior in mirroring egress traffic promiscuous for\nunicast in VF.\n\nSigned-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 3ef67dc..aa8d30b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1758,7 +1758,7 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf,\n \t\t}\n \t} else {\n \t\taq_ret = i40e_aq_set_vsi_unicast_promiscuous(hw, vsi->seid,\n-\t\t\t\t\t\t\t     allmulti, NULL,\n+\t\t\t\t\t\t\t     alluni, NULL,\n \t\t\t\t\t\t\t     true);\n \t\taq_err = pf->hw.aq.asq_last_status;\n \t\tif (aq_ret) {\n","prefixes":["next","S75-V3","07/11"]}