{"id":781593,"url":"http://patchwork.ozlabs.org/api/patches/781593/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170628114907.kf3t65mrdbq7rsfm@mwanda/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20170628114907.kf3t65mrdbq7rsfm@mwanda>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20170628114907.kf3t65mrdbq7rsfm@mwanda/","date":"2017-06-28T11:49:07","name":"powerpc: remapping too much memory","commit_ref":"c65540453e150844367ffe98e45d5175181b2ec1","pull_url":null,"state":"accepted","archived":false,"hash":"cd0013e110fee44d819612b8594c412f08ebd357","submitter":{"id":9327,"url":"http://patchwork.ozlabs.org/api/people/9327/?format=json","name":"Dan Carpenter","email":"dan.carpenter@oracle.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170628114907.kf3t65mrdbq7rsfm@mwanda/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/781593/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/781593/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wyLhl70TBz9s0m\n\tfor ;\n\tWed, 28 Jun 2017 21:50:47 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3wyLhl5xsXzDr5m\n\tfor ;\n\tWed, 28 Jun 2017 21:50:47 +1000 (AEST)","from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3wyLgb1hv2zDr3l\n\tfor ;\n\tWed, 28 Jun 2017 21:49:47 +1000 (AEST)","from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v5SBnJnc023105\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Wed, 28 Jun 2017 11:49:20 GMT","from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v5SBnJkJ026500\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Wed, 28 Jun 2017 11:49:19 GMT","from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25])\n\tby userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv5SBnGAq032527; Wed, 28 Jun 2017 11:49:16 GMT","from mwanda (/105.166.14.53) by default (Oracle Beehive Gateway\n\tv4.0) with ESMTP ; Wed, 28 Jun 2017 04:49:15 -0700"],"Date":"Wed, 28 Jun 2017 14:49:07 +0300","From":"Dan Carpenter ","To":"Scott Wood ","Subject":"[PATCH] powerpc: remapping too much memory","Message-ID":"<20170628114907.kf3t65mrdbq7rsfm@mwanda>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","X-Mailer":"git-send-email haha only kidding","User-Agent":"NeoMutt/20170113 (1.7.2)","X-Source-IP":"userv0022.oracle.com [156.151.31.74]","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel-janitors@vger.kernel.org, Paul Mackerras ,\n\tlinuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"There is a cut and paste error here so we use \"sizeof(struct mpc83xx_pmc)\"\nto remap the memory for \"clock_regs\". That sizeof() is 20 bytes and we\nonly need to remap 12 bytes. It presumably doesn't affect run time too\nmuch...\n\nI changed them to both use \"sizeof(*variable_name)\" because that's the\nprefered kernel style these days.\n\nFixes: d49747bdfb2d (\"powerpc/mpc83xx: Power Management support\")\nSigned-off-by: Dan Carpenter ","diff":"diff --git a/arch/powerpc/platforms/83xx/suspend.c b/arch/powerpc/platforms/83xx/suspend.c\nindex 978b85bb3233..7fa3e197871a 100644\n--- a/arch/powerpc/platforms/83xx/suspend.c\n+++ b/arch/powerpc/platforms/83xx/suspend.c\n@@ -361,7 +361,7 @@ static int pmc_probe(struct platform_device *ofdev)\n \t\t\treturn -EBUSY;\n \t}\n \n-\tpmc_regs = ioremap(res.start, sizeof(struct mpc83xx_pmc));\n+\tpmc_regs = ioremap(res.start, sizeof(*pmc_regs));\n \n \tif (!pmc_regs) {\n \t\tret = -ENOMEM;\n@@ -374,7 +374,7 @@ static int pmc_probe(struct platform_device *ofdev)\n \t\tgoto out_pmc;\n \t}\n \n-\tclock_regs = ioremap(res.start, sizeof(struct mpc83xx_pmc));\n+\tclock_regs = ioremap(res.start, sizeof(*clock_regs));\n \n \tif (!clock_regs) {\n \t\tret = -ENOMEM;\n","prefixes":[]}