{"id":765763,"url":"http://patchwork.ozlabs.org/api/patches/765763/?format=json","web_url":"http://patchwork.ozlabs.org/project/snowpatch/patch/20170523055333.12435-1-andrew.donnellan@au1.ibm.com/","project":{"id":51,"url":"http://patchwork.ozlabs.org/api/projects/51/?format=json","name":"Snowpatch development","link_name":"snowpatch","list_id":"snowpatch.lists.ozlabs.org","list_email":"snowpatch@lists.ozlabs.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170523055333.12435-1-andrew.donnellan@au1.ibm.com>","list_archive_url":null,"date":"2017-05-23T05:53:33","name":"main: Use SSL connector for non-proxied connections","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"552f3e3b81dd9b4d9ce923b832305d80965a8440","submitter":{"id":66955,"url":"http://patchwork.ozlabs.org/api/people/66955/?format=json","name":"Andrew Donnellan","email":"andrew.donnellan@au1.ibm.com"},"delegate":{"id":58490,"url":"http://patchwork.ozlabs.org/api/users/58490/?format=json","username":"ruscur","first_name":"Russell","last_name":"Currey","email":"ruscur@russell.cc"},"mbox":"http://patchwork.ozlabs.org/project/snowpatch/patch/20170523055333.12435-1-andrew.donnellan@au1.ibm.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/765763/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/765763/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","snowpatch@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","snowpatch@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wX4Vf61lhz9sP5\n\tfor ;\n\tTue, 23 May 2017 15:54:50 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3wX4Vf58kjzDqZk\n\tfor ;\n\tTue, 23 May 2017 15:54:50 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3wX4VY0jxpzDqKy\n\tfor ;\n\tTue, 23 May 2017 15:54:44 +1000 (AEST)","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id\n\tv4N5n5tr054747\n\tfor ; Tue, 23 May 2017 01:54:41 -0400","from e23smtp02.au.ibm.com (e23smtp02.au.ibm.com [202.81.31.144])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2am9y6bkh1-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 23 May 2017 01:54:41 -0400","from localhost\n\tby e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ; \n\tTue, 23 May 2017 15:54:38 +1000","from d23relay06.au.ibm.com (202.81.31.225)\n\tby e23smtp02.au.ibm.com (202.81.31.208) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tTue, 23 May 2017 15:54:36 +1000","from d23av05.au.ibm.com (d23av05.au.ibm.com [9.190.234.119])\n\tby d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv4N5sR2b53149888\n\tfor ; Tue, 23 May 2017 15:54:35 +1000","from d23av05.au.ibm.com (localhost [127.0.0.1])\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv4N5s3Jq021191\n\tfor ; Tue, 23 May 2017 15:54:03 +1000","from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14])\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv4N5s2WS020530\n\tfor ; Tue, 23 May 2017 15:54:03 +1000","from ajd.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114])\n\t(using TLSv1.2 with cipher AES128-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby ozlabs.au.ibm.com (Postfix) with ESMTPSA id 31D94A0196\n\tfor ;\n\tTue, 23 May 2017 15:53:38 +1000 (AEST)"],"From":"Andrew Donnellan ","To":"snowpatch@lists.ozlabs.org","Date":"Tue, 23 May 2017 15:53:33 +1000","X-Mailer":"git-send-email 2.11.0","X-TM-AS-MML":"disable","x-cbid":"17052305-0004-0000-0000-00000205D7ED","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17052305-0005-0000-0000-000009FB6B7D","Message-Id":"<20170523055333.12435-1-andrew.donnellan@au1.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-05-23_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000\n\tdefinitions=main-1705230030","Subject":"[snowpatch] [PATCH] main: Use SSL connector for non-proxied\n\tconnections","X-BeenThere":"snowpatch@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Continuous Integration for patch-based workflows\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"snowpatch-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"snowpatch\"\n\t"},"content":"We currently create an HttpsConnector so we can use HTTPS with hyper, but\nwe only actually use it in the case where an HTTP proxy is used.\n\nFix the non-proxy case so the hyper client uses the HttpsConnector.\n\nSigned-off-by: Andrew Donnellan \n---\n src/main.rs | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/main.rs b/src/main.rs\nindex a0e6576..9b24385 100644\n--- a/src/main.rs\n+++ b/src/main.rs\n@@ -263,9 +263,9 @@ fn main() {\n let settings = settings::parse(&args.arg_config_file);\n \n // The HTTP client we'll use to access the APIs\n- // TODO: HTTPS support, not yet implemented in Hyper as of 0.9.6\n let ssl = OpensslClient::new().unwrap();\n let connector = HttpsConnector::new(ssl.clone());\n+ // TODO: Handle https_proxy\n let client = Arc::new(match env::var(\"http_proxy\") {\n Ok(proxy_url) => {\n debug!(\"snowpatch is using HTTP proxy {}\", proxy_url);\n@@ -286,7 +286,7 @@ fn main() {\n },\n _ => {\n debug!(\"snowpatch starting without a HTTP proxy\");\n- let mut c = Client::new();\n+ let mut c = Client::with_connector(connector);\n c.set_redirect_policy(RedirectPolicy::FollowAll);\n c\n }\n","prefixes":[]}