{"id":762328,"url":"http://patchwork.ozlabs.org/api/patches/762328/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1494839745-20351-1-git-send-email-patrick.delaunay@st.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1494839745-20351-1-git-send-email-patrick.delaunay@st.com>","list_archive_url":null,"date":"2017-05-15T09:15:45","name":"[U-Boot] cmd: usb: check usb_stor_curr_dev in usb dev with no parameter","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"178e537b1b5d7e6bd90dfeecd2f8172ac6e53744","submitter":{"id":70437,"url":"http://patchwork.ozlabs.org/api/people/70437/?format=json","name":"Patrick DELAUNAY","email":"patrick.delaunay@st.com"},"delegate":{"id":1699,"url":"http://patchwork.ozlabs.org/api/users/1699/?format=json","username":"marex","first_name":"Marek","last_name":"Vasut","email":"marek.vasut@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1494839745-20351-1-git-send-email-patrick.delaunay@st.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/762328/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/762328/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3wRFLV21Lxz9s5L\n\tfor ;\n\tMon, 15 May 2017 19:16:02 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 6743EC21CCA; Mon, 15 May 2017 09:15:55 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 32516C21C77;\n\tMon, 15 May 2017 09:15:53 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 2D697C21C77; Mon, 15 May 2017 09:15:52 +0000 (UTC)","from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com\n\t[62.209.51.94]) by lists.denx.de (Postfix) with ESMTPS id CFAB5C21C33\n\tfor ; Mon, 15 May 2017 09:15:51 +0000 (UTC)","from pps.filterd (m0046037.ppops.net [127.0.0.1])\n\tby mx07-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv4F9EP1A003047; Mon, 15 May 2017 11:15:49 +0200","from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35])\n\tby mx07-.pphosted.com with ESMTP id 2adqwpsu4e-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tMon, 15 May 2017 11:15:49 +0200","from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9])\n\tby beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B556038;\n\tMon, 15 May 2017 09:15:48 +0000 (GMT)","from Webmail-eu.st.com (Safex1hubcas23.st.com [10.75.90.46])\n\tby zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 910F01328;\n\tMon, 15 May 2017 09:15:48 +0000 (GMT)","from localhost (10.201.23.85) by webmail-ga.st.com (10.75.90.48)\n\twith Microsoft SMTP Server (TLS) id 14.3.339.0;\n\tMon, 15 May 2017 11:15:48 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=unavailable autolearn_force=no version=3.4.0","From":"Patrick Delaunay ","To":"","Date":"Mon, 15 May 2017 11:15:45 +0200","Message-ID":"<1494839745-20351-1-git-send-email-patrick.delaunay@st.com>","X-Mailer":"git-send-email 1.9.1","MIME-Version":"1.0","X-Originating-IP":"[10.201.23.85]","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-05-15_05:, , signatures=0","Cc":"Yann Gautier ,\n\tMichal Simek , \n\tHans de Goede ","Subject":"[U-Boot] [PATCH] cmd: usb: check usb_stor_curr_dev in usb dev with\n\tno parameter","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"If 'usb start' does not find devices, the command 'usb dev'\nwithout parameter will lead to error= USB device -1: data abort\nA check on usb_stor_curr_dev avoid the issue\n\nSigned-off-by: Patrick Delaunay \n---\n\n cmd/usb.c | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/cmd/usb.c b/cmd/usb.c\nindex 4fa456e..bc90553 100644\n--- a/cmd/usb.c\n+++ b/cmd/usb.c\n@@ -803,6 +803,10 @@ static int do_usb(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])\n \t\t\tprintf(\"... is now current device\\n\");\n \t\t\treturn 0;\n \t\t} else {\n+\t\t\tif (usb_stor_curr_dev < 0) {\n+\t\t\t\tprintf(\"no current device selected\\n\");\n+\t\t\t\treturn 1;\n+\t\t\t}\n \t\t\tprintf(\"\\nUSB device %d: \", usb_stor_curr_dev);\n \t\t\tstor_dev = blk_get_devnum_by_type(IF_TYPE_USB,\n \t\t\t\t\t\t\t usb_stor_curr_dev);\n","prefixes":["U-Boot"]}