{"id":718707,"url":"http://patchwork.ozlabs.org/api/patches/718707/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1485192364-2840-1-git-send-email-bhumirks@gmail.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<1485192364-2840-1-git-send-email-bhumirks@gmail.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/1485192364-2840-1-git-send-email-bhumirks@gmail.com/","date":"2017-01-23T17:26:04","name":"usb: gadget: udc: constify usb_ep_ops structures","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"f16e3647d8a87336445161cdc5fe62aee601f457","submitter":{"id":69882,"url":"http://patchwork.ozlabs.org/api/people/69882/?format=json","name":"Bhumika Goyal","email":"bhumirks@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1485192364-2840-1-git-send-email-bhumirks@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/718707/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/718707/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3v6dYg0HQHz9s3v\n\tfor ;\n\tTue, 24 Jan 2017 04:27:51 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3v6dYf6L58zDqRS\n\tfor ;\n\tTue, 24 Jan 2017 04:27:50 +1100 (AEDT)","from mail-pg0-x242.google.com (mail-pg0-x242.google.com\n\t[IPv6:2607:f8b0:400e:c05::242])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3v6dWz2JqDzDqJ4\n\tfor ;\n\tTue, 24 Jan 2017 04:26:23 +1100 (AEDT)","by mail-pg0-x242.google.com with SMTP id 75so14207443pgf.3\n\tfor ;\n\tMon, 23 Jan 2017 09:26:23 -0800 (PST)","from gmail.com ([2405:204:540c:52df:c9ba:932c:541d:cc0e])\n\tby smtp.gmail.com with ESMTPSA id\n\tr21sm38237757pfd.95.2017.01.23.09.26.13\n\t(version=TLS1 cipher=AES128-SHA bits=128/128);\n\tMon, 23 Jan 2017 09:26:19 -0800 (PST)","by gmail.com (sSMTP sendmail emulation);\n\tMon, 23 Jan 2017 22:56:10 +0530"],"Authentication-Results":["ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"a3WoEnVB\"; dkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"a3WoEnVB\"; dkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"a3WoEnVB\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=Tt3gxiZ8ncTxcBQwep2JcgSV/iQkzIC/SC8j2GF86no=;\n\tb=a3WoEnVBWqNYoxatBHLy6exkOS2GBCGX33mnuLE4/smjwXI0jM12EAF/pFLsCphWl7\n\tv4q9p/z+I+TiIn/XNpOhQMiLcSqkZHIAnNvM37AZUfGtk9BXjLIMrryfaCZ1RDxCx4O8\n\tHK9YBVIMPkxPgzQpD/6hve46/3j5smjMPrvBrkULTrtyNGfqgisEkomIBQBmJBpzWj5t\n\tTGrWNXFp2ux7bWZaQD6l81FkgPEDk1rkf5CqUqlX++Hc/TFqWb3p3RoYZVbKtQzatqZm\n\tVGQWiNd7XJtAwP378Q0DYd1tOjvPl3VlztLnF7yooz6EHAk0igot7kmueN9/RAjhHA62\n\t4TrQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=Tt3gxiZ8ncTxcBQwep2JcgSV/iQkzIC/SC8j2GF86no=;\n\tb=Sr7uDhnQFPeIuyKK4AhyUcrdZBl0zKzZ6WhvnlN9qlVHWeLHjy6BWGGeeAdYwa33x6\n\tJHH8BO4hMHMxjixgu5SsRQ/m3n6dTE//iywAfGd4mj+wYEpi5kGd0FPQMjQXRDFfuHGo\n\tHM2Odddejmkj0ek5ymE++9nDA97UxZekcKUkmQFGKr5K8G5DUZWLnc2qtHmDxjjcELAo\n\t8Dw88kN9HCvffCCn2yfnYaahMoTHTvsh7brJDOQ0z2l/lt5m7Lrwt9g8PBSMbd3+eTZx\n\t4RquqepzOWQgzEvg3SupATHYWExFjQgSw5izQrpYtiQJWRXzuKRKmzywNSf5tfCzYLbI\n\tq3FA==","X-Gm-Message-State":"AIkVDXLKMQ7jUSCGPUL3n/8h0qVBXtnAqEWDYw5A1MBbdZQN5BiOEgCL3zvMzIAINSx3WQ==","X-Received":"by 10.99.219.21 with SMTP id e21mr34302236pgg.29.1485192380570; \n\tMon, 23 Jan 2017 09:26:20 -0800 (PST)","From":"Bhumika Goyal ","To":"julia.lawall@lip6.fr, balbi@kernel.org, gregkh@linuxfoundation.org,\n\tleoli@freescale.com, daniel@zonque.org, haojian.zhuang@gmail.com,\n\trobert.jarzmik@free.fr, linux-usb@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-arm-kernel@lists.infradead.org","Subject":"[PATCH] usb: gadget: udc: constify usb_ep_ops structures","Date":"Mon, 23 Jan 2017 22:56:04 +0530","Message-Id":"<1485192364-2840-1-git-send-email-bhumirks@gmail.com>","X-Mailer":"git-send-email 1.9.1","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Bhumika Goyal ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"Declare usb_ep_ops structures as const as they are only stored in the\nops field of an usb_ep structure. This field is of type const, so\nusb_ep_ops structures having this property can be made const too.\nDone using Coccinelle( A smaller version of the script)\n\n@r disable optional_qualifier@\nidentifier i;\nposition p;\n@@\nstatic struct usb_ep_ops i@p={...};\n\n@ok@\nidentifier r.i;\nposition p;\nstruct mv_ep a;\nstruct mv_u3d_ep b;\nstruct omap_ep c;\n\n@@\n(\na.ep.ops=&i@p;\n|\nb.ep.ops=&i@p;\n|\nc.ep.ops=&i@p;\n\n)\n\n@bad@\nposition p!={r.p,ok.p};\nidentifier r.i;\n@@\ni@p\n\n@depends on !bad disable optional_qualifier@\nidentifier r.i;\n@@\n+const\nstruct usb_ep_ops i;\n\nFile size details before and after applying the patch.\nFirst line of every .o file shows the file size before patching and\nsecond line shows the file size after patching.\n\n text\t data\t bss\t dec\t hex\tfilename\n\n 7782\t 384\t 8\t 8174\t 1fee\tusb/gadget/udc/fotg210-udc.o\n 7878\t 296\t 8\t 8182\t 1ff6\tusb/gadget/udc/fotg210-udc.o\n\n 17866\t 992\t 40\t 18898\t 49d2\tusb/gadget/udc/fsl_udc_core.o\n 17954\t 896\t 40\t 18890\t 49ca\tusb/gadget/udc/fsl_udc_core.o\n\n 9646\t 288\t 8\t 9942\t 26d6\tusb/gadget/udc/fusb300_udc.o\n 9742\t 192\t 8\t 9942\t 26d6\tusb/gadget/udc/fusb300_udc.o\n\n 12752\t 416\t 8\t 13176\t 3378\tdrivers/usb/gadget/udc/goku_udc.o\n 12832\t 328\t 8\t 13168\t 3370\tdrivers/usb/gadget/udc/goku_udc.o\n\n 16541\t 1696\t 8\t 18245\t 4745\tdrivers/usb/gadget/udc/gr_udc.o\n 16637\t 1600\t 8\t 18245\t 4745\tdrivers/usb/gadget/udc/gr_udc.o\n\n 15798\t 288\t 16\t 16102\t 3ee6\tdrivers/usb/gadget/udc/m66592-udc.o\n 15894\t 192\t 16\t 16102\t 3ee6\tdrivers/usb/gadget/udc/m66592-udc.o\n\n 17751\t 3808\t 16\t 21575\t 5447\tusb/gadget/udc/mv_u3d_core.o\n 17839\t 3712\t 16\t 21567\t 543f\tusb/gadget/udc/mv_u3d_core.o\n\n 17348\t 1112\t 24\t 18484\t 4834\tusb/gadget/udc/mv_udc_core.o\n 17436\t 1016\t 24\t 18476\t 482c\tusb/gadget/udc/mv_udc_core.o\n\n 25990\t 2620\t 13\t 28623\t 6fcf\tdrivers/usb/gadget/udc/net2272.o\n 26086\t 2524\t 13\t 28623\t 6fcf\tdrivers/usb/gadget/udc/net2272.o\n\n 18409\t 7312\t 8\t 25729\t 6481\tdrivers/usb/gadget/udc/pxa27x_udc.o\n 18505\t 7208\t 8\t 25721\t 6479\tdrivers/usb/gadget/udc/pxa27x_udc.o\n\n 18644\t 288\t 16\t 18948\t 4a04\tusb/gadget/udc/r8a66597-udc.o\n 18740\t 192\t 16\t 18948\t 4a04\tusb/gadget/udc/r8a66597-udc.o\n\nFiles: drivers/usb/gadget/udc/{s3c-hsudc.o/omap_udc.o/fsl_qe_udc.o} did\nnot complie.\n\nSigned-off-by: Bhumika Goyal \n---\n drivers/usb/gadget/udc/fotg210-udc.c | 2 +-\n drivers/usb/gadget/udc/fsl_qe_udc.c | 2 +-\n drivers/usb/gadget/udc/fsl_udc_core.c | 2 +-\n drivers/usb/gadget/udc/fusb300_udc.c | 2 +-\n drivers/usb/gadget/udc/goku_udc.c | 2 +-\n drivers/usb/gadget/udc/gr_udc.c | 2 +-\n drivers/usb/gadget/udc/m66592-udc.c | 2 +-\n drivers/usb/gadget/udc/mv_u3d_core.c | 2 +-\n drivers/usb/gadget/udc/mv_udc_core.c | 2 +-\n drivers/usb/gadget/udc/net2272.c | 4 ++--\n drivers/usb/gadget/udc/omap_udc.c | 2 +-\n drivers/usb/gadget/udc/pxa27x_udc.c | 2 +-\n drivers/usb/gadget/udc/r8a66597-udc.c | 2 +-\n drivers/usb/gadget/udc/s3c-hsudc.c | 2 +-\n 14 files changed, 15 insertions(+), 15 deletions(-)","diff":"diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/udc/fotg210-udc.c\nindex 6ba122c..966637d 100644\n--- a/drivers/usb/gadget/udc/fotg210-udc.c\n+++ b/drivers/usb/gadget/udc/fotg210-udc.c\n@@ -527,7 +527,7 @@ static void fotg210_ep_fifo_flush(struct usb_ep *_ep)\n {\n }\n \n-static struct usb_ep_ops fotg210_ep_ops = {\n+static const struct usb_ep_ops fotg210_ep_ops = {\n \t.enable\t\t= fotg210_ep_enable,\n \t.disable\t= fotg210_ep_disable,\n \ndiff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c\nindex 4fff51b..303328ce 100644\n--- a/drivers/usb/gadget/udc/fsl_qe_udc.c\n+++ b/drivers/usb/gadget/udc/fsl_qe_udc.c\n@@ -1847,7 +1847,7 @@ static int qe_ep_set_halt(struct usb_ep *_ep, int value)\n \treturn status;\n }\n \n-static struct usb_ep_ops qe_ep_ops = {\n+static const struct usb_ep_ops qe_ep_ops = {\n \t.enable = qe_ep_enable,\n \t.disable = qe_ep_disable,\n \ndiff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c\nindex 71094e4..f518727 100644\n--- a/drivers/usb/gadget/udc/fsl_udc_core.c\n+++ b/drivers/usb/gadget/udc/fsl_udc_core.c\n@@ -1118,7 +1118,7 @@ static void fsl_ep_fifo_flush(struct usb_ep *_ep)\n \t} while (fsl_readl(&dr_regs->endptstatus) & bits);\n }\n \n-static struct usb_ep_ops fsl_ep_ops = {\n+static const struct usb_ep_ops fsl_ep_ops = {\n \t.enable = fsl_ep_enable,\n \t.disable = fsl_ep_disable,\n \ndiff --git a/drivers/usb/gadget/udc/fusb300_udc.c b/drivers/usb/gadget/udc/fusb300_udc.c\nindex 42ff308..e0c1b00 100644\n--- a/drivers/usb/gadget/udc/fusb300_udc.c\n+++ b/drivers/usb/gadget/udc/fusb300_udc.c\n@@ -518,7 +518,7 @@ static void fusb300_fifo_flush(struct usb_ep *_ep)\n {\n }\n \n-static struct usb_ep_ops fusb300_ep_ops = {\n+static const struct usb_ep_ops fusb300_ep_ops = {\n \t.enable\t\t= fusb300_enable,\n \t.disable\t= fusb300_disable,\n \ndiff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c\nindex 5107987..8433c22 100644\n--- a/drivers/usb/gadget/udc/goku_udc.c\n+++ b/drivers/usb/gadget/udc/goku_udc.c\n@@ -968,7 +968,7 @@ static void goku_fifo_flush(struct usb_ep *_ep)\n \t\tcommand(regs, COMMAND_FIFO_CLEAR, ep->num);\n }\n \n-static struct usb_ep_ops goku_ep_ops = {\n+static const struct usb_ep_ops goku_ep_ops = {\n \t.enable\t\t= goku_ep_enable,\n \t.disable\t= goku_ep_disable,\n \ndiff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c\nindex b16f8af..1f99411 100644\n--- a/drivers/usb/gadget/udc/gr_udc.c\n+++ b/drivers/usb/gadget/udc/gr_udc.c\n@@ -1841,7 +1841,7 @@ static void gr_fifo_flush(struct usb_ep *_ep)\n \tspin_unlock(&ep->dev->lock);\n }\n \n-static struct usb_ep_ops gr_ep_ops = {\n+static const struct usb_ep_ops gr_ep_ops = {\n \t.enable\t\t= gr_ep_enable,\n \t.disable\t= gr_ep_disable,\n \ndiff --git a/drivers/usb/gadget/udc/m66592-udc.c b/drivers/usb/gadget/udc/m66592-udc.c\nindex de3e034..46ce7bc 100644\n--- a/drivers/usb/gadget/udc/m66592-udc.c\n+++ b/drivers/usb/gadget/udc/m66592-udc.c\n@@ -1436,7 +1436,7 @@ static void m66592_fifo_flush(struct usb_ep *_ep)\n \tspin_unlock_irqrestore(&ep->m66592->lock, flags);\n }\n \n-static struct usb_ep_ops m66592_ep_ops = {\n+static const struct usb_ep_ops m66592_ep_ops = {\n \t.enable\t\t= m66592_enable,\n \t.disable\t= m66592_disable,\n \ndiff --git a/drivers/usb/gadget/udc/mv_u3d_core.c b/drivers/usb/gadget/udc/mv_u3d_core.c\nindex 8d726bd..d365449 100644\n--- a/drivers/usb/gadget/udc/mv_u3d_core.c\n+++ b/drivers/usb/gadget/udc/mv_u3d_core.c\n@@ -995,7 +995,7 @@ static int mv_u3d_ep_set_wedge(struct usb_ep *_ep)\n \treturn mv_u3d_ep_set_halt_wedge(_ep, 1, 1);\n }\n \n-static struct usb_ep_ops mv_u3d_ep_ops = {\n+static const struct usb_ep_ops mv_u3d_ep_ops = {\n \t.enable\t\t= mv_u3d_ep_enable,\n \t.disable\t= mv_u3d_ep_disable,\n \ndiff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c\nindex d82a91b..27ebb0d 100644\n--- a/drivers/usb/gadget/udc/mv_udc_core.c\n+++ b/drivers/usb/gadget/udc/mv_udc_core.c\n@@ -946,7 +946,7 @@ static int mv_ep_set_wedge(struct usb_ep *_ep)\n \treturn mv_ep_set_halt_wedge(_ep, 1, 1);\n }\n \n-static struct usb_ep_ops mv_ep_ops = {\n+static const struct usb_ep_ops mv_ep_ops = {\n \t.enable\t\t= mv_ep_enable,\n \t.disable\t= mv_ep_disable,\n \ndiff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c\nindex 078c91d..7dc0102 100644\n--- a/drivers/usb/gadget/udc/net2272.c\n+++ b/drivers/usb/gadget/udc/net2272.c\n@@ -181,7 +181,7 @@ static void net2272_dequeue_all(struct net2272_ep *);\n static int net2272_kick_dma(struct net2272_ep *, struct net2272_request *);\n static int net2272_fifo_status(struct usb_ep *);\n \n-static struct usb_ep_ops net2272_ep_ops;\n+static const struct usb_ep_ops net2272_ep_ops;\n \n /*---------------------------------------------------------------------------*/\n \n@@ -1067,7 +1067,7 @@ net2272_fifo_flush(struct usb_ep *_ep)\n \tnet2272_ep_write(ep, EP_STAT1, 1 << BUFFER_FLUSH);\n }\n \n-static struct usb_ep_ops net2272_ep_ops = {\n+static const struct usb_ep_ops net2272_ep_ops = {\n \t.enable = net2272_enable,\n \t.disable = net2272_disable,\n \ndiff --git a/drivers/usb/gadget/udc/omap_udc.c b/drivers/usb/gadget/udc/omap_udc.c\nindex a8709f9..f05ba68 100644\n--- a/drivers/usb/gadget/udc/omap_udc.c\n+++ b/drivers/usb/gadget/udc/omap_udc.c\n@@ -1112,7 +1112,7 @@ static int omap_ep_set_halt(struct usb_ep *_ep, int value)\n \treturn status;\n }\n \n-static struct usb_ep_ops omap_ep_ops = {\n+static const struct usb_ep_ops omap_ep_ops = {\n \t.enable\t\t= omap_ep_enable,\n \t.disable\t= omap_ep_disable,\n \ndiff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c\nindex 7fa60f5..e1335ad 100644\n--- a/drivers/usb/gadget/udc/pxa27x_udc.c\n+++ b/drivers/usb/gadget/udc/pxa27x_udc.c\n@@ -1473,7 +1473,7 @@ static int pxa_ep_disable(struct usb_ep *_ep)\n \treturn 0;\n }\n \n-static struct usb_ep_ops pxa_ep_ops = {\n+static const struct usb_ep_ops pxa_ep_ops = {\n \t.enable\t\t= pxa_ep_enable,\n \t.disable\t= pxa_ep_disable,\n \ndiff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/udc/r8a66597-udc.c\nindex f2c8862..118ad70 100644\n--- a/drivers/usb/gadget/udc/r8a66597-udc.c\n+++ b/drivers/usb/gadget/udc/r8a66597-udc.c\n@@ -1706,7 +1706,7 @@ static void r8a66597_fifo_flush(struct usb_ep *_ep)\n \tspin_unlock_irqrestore(&ep->r8a66597->lock, flags);\n }\n \n-static struct usb_ep_ops r8a66597_ep_ops = {\n+static const struct usb_ep_ops r8a66597_ep_ops = {\n \t.enable\t\t= r8a66597_enable,\n \t.disable\t= r8a66597_disable,\n \ndiff --git a/drivers/usb/gadget/udc/s3c-hsudc.c b/drivers/usb/gadget/udc/s3c-hsudc.c\nindex 82a9e2a..42587b7 100644\n--- a/drivers/usb/gadget/udc/s3c-hsudc.c\n+++ b/drivers/usb/gadget/udc/s3c-hsudc.c\n@@ -954,7 +954,7 @@ static int s3c_hsudc_dequeue(struct usb_ep *_ep, struct usb_request *_req)\n \treturn 0;\n }\n \n-static struct usb_ep_ops s3c_hsudc_ep_ops = {\n+static const struct usb_ep_ops s3c_hsudc_ep_ops = {\n \t.enable = s3c_hsudc_ep_enable,\n \t.disable = s3c_hsudc_ep_disable,\n \t.alloc_request = s3c_hsudc_alloc_request,\n","prefixes":[]}