{"id":655675,"url":"http://patchwork.ozlabs.org/api/patches/655675/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20160804053525.GM775@mwanda/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20160804053525.GM775@mwanda>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20160804053525.GM775@mwanda/","date":"2016-08-04T05:35:25","name":"powerpc/fsl_rio: fix a missing error code","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cd3558b097b4d230dd048179d97c0812990b8364","submitter":{"id":9327,"url":"http://patchwork.ozlabs.org/api/people/9327/?format=json","name":"Dan Carpenter","email":"dan.carpenter@oracle.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20160804053525.GM775@mwanda/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/655675/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/655675/checks/","tags":{},"related":[],"headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3s4dxQ69xcz9t0t\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  4 Aug 2016 15:37:30 +1000 (AEST)","from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3s4dxQ5Q95zDqdb\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  4 Aug 2016 15:37:30 +1000 (AEST)","from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3s4dwG4YhczDqRt\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tThu,  4 Aug 2016 15:36:30 +1000 (AEST)","from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id u745ZbFd021481\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 4 Aug 2016 05:35:37 GMT","from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n\tby userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tu745Zaxo021585\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);\n\tThu, 4 Aug 2016 05:35:36 GMT","from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17])\n\tby aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id\n\tu745ZXnc017215; Thu, 4 Aug 2016 05:35:34 GMT","from mwanda (/154.0.139.178) by default (Oracle Beehive Gateway\n\tv4.0) with ESMTP ; Wed, 03 Aug 2016 22:35:33 -0700"],"Date":"Thu, 4 Aug 2016 08:35:25 +0300","From":"Dan Carpenter <dan.carpenter@oracle.com>","To":"Benjamin Herrenschmidt <benh@kernel.crashing.org>","Subject":"[patch] powerpc/fsl_rio: fix a missing error code","Message-ID":"<20160804053525.GM775@mwanda>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","User-Agent":"Mutt/1.6.0 (2016-04-01)","X-Source-IP":"userv0022.oracle.com [156.151.31.74]","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.22","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"kernel-janitors@vger.kernel.org,\n\tAlexandre Bounine <alexandre.bounine@idt.com>,\n\tPaul Mackerras <paulus@samba.org>,\n\tAndrew Morton <akpm@linux-foundation.org>, linuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"},"content":"We should set the error code here.  Otherwise static checkers complain.\n\nSigned-off-by: Dan Carpenter <dan.carpenter@oracle.com>","diff":"diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c\nindex 984e816..68e7c0d 100644\n--- a/arch/powerpc/sysdev/fsl_rio.c\n+++ b/arch/powerpc/sysdev/fsl_rio.c\n@@ -491,6 +491,7 @@ int fsl_rio_setup(struct platform_device *dev)\n \trmu_node = of_parse_phandle(dev->dev.of_node, \"fsl,srio-rmu-handle\", 0);\n \tif (!rmu_node) {\n \t\tdev_err(&dev->dev, \"No valid fsl,srio-rmu-handle property\\n\");\n+\t\trc = -ENOENT;\n \t\tgoto err_rmu;\n \t}\n \trc = of_address_to_resource(rmu_node, 0, &rmu_regs);\n","prefixes":[]}