{"id":648293,"url":"http://patchwork.ozlabs.org/api/patches/648293/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20160714101545.GB18175@mwanda/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20160714101545.GB18175@mwanda>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20160714101545.GB18175@mwanda/","date":"2016-07-14T10:15:46","name":"KVM: PPC: fix a sanity check","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3f5503b0a61607a4ba1903f1d7aff0fd2f000c1d","submitter":{"id":9327,"url":"http://patchwork.ozlabs.org/api/people/9327/?format=json","name":"Dan Carpenter","email":"dan.carpenter@oracle.com"},"delegate":{"id":13,"url":"http://patchwork.ozlabs.org/api/users/13/?format=json","username":"paulus","first_name":"Paul","last_name":"Mackerras","email":"paulus@samba.org"},"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20160714101545.GB18175@mwanda/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/648293/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/648293/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rqs7j0Lh2z9s9N\n\tfor ;\n\tThu, 14 Jul 2016 20:17:05 +1000 (AEST)","from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3rqs7h6XnQzDr2g\n\tfor ;\n\tThu, 14 Jul 2016 20:17:04 +1000 (AEST)","from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3rqs6f3nFtzDqxj\n\tfor ;\n\tThu, 14 Jul 2016 20:16:10 +1000 (AEST)","from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id u6EAFxES014534\n\t(version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);\n\tThu, 14 Jul 2016 10:15:59 GMT","from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n\tby aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id\n\tu6EAFxeg021086\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);\n\tThu, 14 Jul 2016 10:15:59 GMT","from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21])\n\tby aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id\n\tu6EAFuNU011550; Thu, 14 Jul 2016 10:15:57 GMT","from mwanda (/154.0.139.178) by default (Oracle Beehive Gateway\n\tv4.0) with ESMTP ; Thu, 14 Jul 2016 03:15:55 -0700"],"Date":"Thu, 14 Jul 2016 13:15:46 +0300","From":"Dan Carpenter ","To":"Alexander Graf , Bharat Bhushan ","Subject":"[patch] KVM: PPC: fix a sanity check","Message-ID":"<20160714101545.GB18175@mwanda>","MIME-Version":"1.0","Content-Disposition":"inline","User-Agent":"Mutt/1.6.0 (2016-04-01)","X-Source-IP":"aserv0021.oracle.com [141.146.126.233]","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.22","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kvm@vger.kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= ,\n\tkernel-janitors@vger.kernel.org, kvm-ppc@vger.kernel.org,\n\tPaul Mackerras , Paolo Bonzini ,\n\tlinuxppc-dev@lists.ozlabs.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"We use logical negate where bitwise negate was intended. It means that\nwe never return -EINVAL here.\n\nFixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support')\nSigned-off-by: Dan Carpenter ","diff":"diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c\nindex 02b4672..df3f270 100644\n--- a/arch/powerpc/kvm/booke.c\n+++ b/arch/powerpc/kvm/booke.c\n@@ -2038,7 +2038,7 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,\n \t\tif (type == KVMPPC_DEBUG_NONE)\n \t\t\tcontinue;\n \n-\t\tif (type & !(KVMPPC_DEBUG_WATCH_READ |\n+\t\tif (type & ~(KVMPPC_DEBUG_WATCH_READ |\n \t\t\t KVMPPC_DEBUG_WATCH_WRITE |\n \t\t\t KVMPPC_DEBUG_BREAKPOINT))\n \t\t\treturn -EINVAL;\n","prefixes":[]}