{"id":638519,"url":"http://patchwork.ozlabs.org/api/patches/638519/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/1466493770-11895-11-git-send-email-andrew.smirnov@gmail.com/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1466493770-11895-11-git-send-email-andrew.smirnov@gmail.com>","list_archive_url":null,"date":"2016-06-21T07:22:45","name":"[v2,12/17] RTC: ds1307: Redefine RX8025_REG_* to minimize extra code","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"d5910d14b6ebcbcf27c76d36bf049aaaa6cb3497","submitter":{"id":67013,"url":"http://patchwork.ozlabs.org/api/people/67013/?format=json","name":"Andrey Smirnov","email":"andrew.smirnov@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/1466493770-11895-11-git-send-email-andrew.smirnov@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/638519/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/638519/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Received":["from mail-yw0-x23e.google.com (mail-yw0-x23e.google.com\n\t[IPv6:2607:f8b0:4002:c05::23e])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rYfMg3cKSz9t0Y\n\tfor ;\n\tTue, 21 Jun 2016 17:23:11 +1000 (AEST)","by mail-yw0-x23e.google.com with SMTP id i12sf2161807ywa.1\n\tfor ;\n\tTue, 21 Jun 2016 00:23:11 -0700 (PDT)","by 10.157.22.148 with SMTP id c20ls811924ote.59.gmail; Tue, 21 Jun\n\t2016 00:23:09 -0700 (PDT)","from mail-pf0-x242.google.com (mail-pf0-x242.google.com.\n\t[2607:f8b0:400e:c00::242]) by gmr-mx.google.com with ESMTPS id\n\tpo17si907888pab.2.2016.06.21.00.23.09\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 21 Jun 2016 00:23:09 -0700 (PDT)","by mail-pf0-x242.google.com with SMTP id c74so763755pfb.0\n\tfor ;\n\tTue, 21 Jun 2016 00:23:09 -0700 (PDT)","from squirtle.localdomain.localdomain\n\t(c-73-225-163-254.hsd1.wa.comcast.net. [73.225.163.254])\n\tby smtp.gmail.com with ESMTPSA id\n\tp187sm19452396pfg.67.2016.06.21.00.23.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 21 Jun 2016 00:23:08 -0700 (PDT)"],"Authentication-Results":"ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=VGoDW5rY; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=WaaRGfr1;\n\tdkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20120806;\n\th=sender:mime-version:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:x-original-sender:x-original-authentication-results\n\t:reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=fkpeehqEDBNtRPwRcScSV/BD7fAniuHVuTE1DHzDzmQ=;\n\tb=VGoDW5rY47KBeHLoBiWSmayzC3qa5tjWlQ6gq2Bx6XPYdpR2ZrgvMh7IYERXYLnJ6K\n\tmzRO3uurUNYjd3RlhN+hrrJVbS1bSMSbTX6V0kaGDY955KyEuirseXeN9NbkuEP1s2b0\n\t5O6BOCCZ3uSJWiDcSEP812xkmbjZSJc1I5dwP66T4Cyd3AzSgtCtsWi8N2jQiPNTSms8\n\teFUp1u+QBlUcbbTQP11UqOb6nQvQoK2CJ3580vRGgrTCsYVhmT8lNO7dAkXB96eDZjJf\n\t92Hdk36H0TTfvj8qYV1Dp7DwGNrQ9nM3/GYHMPXcn0wlCCjrE9tsaNHopFkBe29uOPXn\n\tNyyg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20120113;\n\th=mime-version:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:x-original-sender:x-original-authentication-results\n\t:reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=fkpeehqEDBNtRPwRcScSV/BD7fAniuHVuTE1DHzDzmQ=;\n\tb=WaaRGfr1wsu77bm24XtImZTyw9Whg45kgOel09gQOX7Fl6S3FABF5e0MzULOLGXb1u\n\tq892q35WHlWRIsi4Ys7BwB6I3szrYYI317iaCMPQmWwUFL45obEB7ulj4Hnl53lNYShi\n\tmSWVFgsdN/ygaesL7ILN+Jy5jIWFisDnYazTrmwQSlv1BsHUWqz6IKy00kM8UY7UWtGG\n\tsOvUviHE8skkyQ/PzLwmAj/ma1pQaWldTMDZrMzAtAmlh72R5mIQMlOhQ8KfS1hKHPEO\n\t0hfMO4qJrUTnWFw16MI9vjyx0FTxNowHXIhAdk2YKiZUkmd7ngXjZLSFVEhBnLiH6+wl\n\tnqdA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=sender:x-gm-message-state:mime-version:from:to:cc:subject:date\n\t:message-id:in-reply-to:references:x-original-sender\n\t:x-original-authentication-results:reply-to:precedence:mailing-list\n\t:list-id:x-spam-checked-in-group:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=fkpeehqEDBNtRPwRcScSV/BD7fAniuHVuTE1DHzDzmQ=;\n\tb=YW1SGyZYeuV0ARXNd/b2LCIMD12wbTJW57pIj59VQ8T9JT5jDYK4YElYx/VgU0EDMX\n\tZ8wlVOBp2NIOkyruoMs+DGuR4qk5zqXlyWaqJTXhGCyyDlwkkjhCXxNkdEvdb5waOddD\n\tn0MiSoC58eIE6c1V+sCDllk1DcI7QSrwfDScMmUVrJUTn9FBy+UfSMNwMmaNOMBSKG1r\n\tr/eYKmHsG2QD5ilEG+mw0+tj5Tdo2mplpS0nb0SfI6HBUblAIJl+aKZAse6Blx+x6oFT\n\tk9TkIzNsSioqCXtwYKdBJcppQ1W3pCmbP73ud6ES6nbjZFVc+2YH1ftBwcDUj51LL36O\n\twWmQ==","Sender":"rtc-linux@googlegroups.com","X-Gm-Message-State":"ALyK8tIVWzZVq4WIOVP4rn5VPvl38FhjZJDgEpabzxYyhosQQgDmXfBqKvtmI532/DDmFg==","X-Received":["by 10.157.45.14 with SMTP id v14mr604590ota.12.1466493789672;\n\tTue, 21 Jun 2016 00:23:09 -0700 (PDT)","by 10.237.34.131 with SMTP id p3mr25464863qtc.19.1466493789422; \n\tTue, 21 Jun 2016 00:23:09 -0700 (PDT)","by 10.98.14.140 with SMTP id 12mr26465554pfo.68.1466493789147;\n\tTue, 21 Jun 2016 00:23:09 -0700 (PDT)"],"MIME-Version":"1.0","X-BeenThere":"rtc-linux@googlegroups.com","Received-SPF":"pass (google.com: domain of andrew.smirnov@gmail.com\n\tdesignates 2607:f8b0:400e:c00::242 as permitted sender)\n\tclient-ip=2607:f8b0:400e:c00::242; ","From":"Andrey Smirnov ","To":"rtc-linux@googlegroups.com","Cc":"Andrey Smirnov ,\n\tAlessandro Zummo ,\n\tAlexandre Belloni ,\n\tlinux-kernel@vger.kernel.org, cphealy@gmail.com","Subject":"[rtc-linux] [PATCH v2 12/17] RTC: ds1307: Redefine RX8025_REG_* to\n\tminimize extra code","Date":"Tue, 21 Jun 2016 00:22:45 -0700","Message-Id":"<1466493770-11895-11-git-send-email-andrew.smirnov@gmail.com>","X-Mailer":"git-send-email 2.5.5","In-Reply-To":"<1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com>","References":"<1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com>","X-Original-Sender":"andrew.smirnov@gmail.com","X-Original-Authentication-Results":"gmr-mx.google.com; dkim=pass\n\theader.i=@gmail.com; spf=pass (google.com: domain of\n\tandrew.smirnov@gmail.com designates 2607:f8b0:400e:c00::242 as\n\tpermitted\n\tsender) smtp.mailfrom=andrew.smirnov@gmail.com; dmarc=pass (p=NONE\n\tdis=NONE) header.from=gmail.com","Reply-To":"rtc-linux@googlegroups.com","Content-Type":"text/plain; charset=UTF-8","Precedence":"list","Mailing-list":"list rtc-linux@googlegroups.com;\n\tcontact rtc-linux+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"rtc-linux@googlegroups.com","X-Google-Group-Id":"712029733259","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"},"content":"The only place in the driver where RX8025_REG_* are used they are always\nshifted and ORed the same way, so instead of repeating that idiom make\nit a part of symbolic constant.\n\nSigned-off-by: Andrey Smirnov \n---\n drivers/rtc/rtc-ds1307.c | 18 ++++++++++--------\n 1 file changed, 10 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c\nindex cbbe9f0..2af9c00 100644\n--- a/drivers/rtc/rtc-ds1307.c\n+++ b/drivers/rtc/rtc-ds1307.c\n@@ -103,9 +103,11 @@ enum ds_type {\n \n #define DS13XX_TRICKLE_CHARGER_MAGIC\t0xa0\n \n-#define RX8025_REG_CTRL1\t0x0e\n+#define RX8025_REG_CTRL1_\t0x0e\n+#define RX8025_REG_CTRL1\t((RX8025_REG_CTRL1_ << 4) | 0x08)\n #\tdefine RX8025_BIT_2412\t\t0x20\n-#define RX8025_REG_CTRL2\t0x0f\n+#define RX8025_REG_CTRL2_\t0x0f\n+#define RX8025_REG_CTRL2\t((RX8025_REG_CTRL2_ << 4) | 0x08)\n #\tdefine RX8025_BIT_PON\t\t0x10\n #\tdefine RX8025_BIT_VDET\t\t0x40\n #\tdefine RX8025_BIT_XST\t\t0x20\n@@ -1353,7 +1355,7 @@ static int ds1307_chip_configure(const struct ds1307 *ds1307)\n \t}\n \tcase rx_8025:\n \t\ttmp = i2c_smbus_read_i2c_block_data(client,\n-\t\t\t\t\t\t RX8025_REG_CTRL1 << 4 | 0x08,\n+\t\t\t\t\t\t RX8025_REG_CTRL1,\n \t\t\t\t\t\t 2, regs);\n \t\tif (tmp != 2) {\n \t\t\tdev_dbg(&client->dev, \"read error %d\\n\", tmp);\n@@ -1364,7 +1366,7 @@ static int ds1307_chip_configure(const struct ds1307 *ds1307)\n \t\tif (!(regs[1] & RX8025_BIT_XST)) {\n \t\t\tregs[1] |= RX8025_BIT_XST;\n \t\t\ti2c_smbus_write_byte_data(client,\n-\t\t\t\t\t\t RX8025_REG_CTRL2 << 4 | 0x08,\n+\t\t\t\t\t\t RX8025_REG_CTRL2,\n \t\t\t\t\t\t regs[1]);\n \t\t\tdev_warn(&client->dev,\n \t\t\t\t \"oscillator stop detected - SET TIME!\\n\");\n@@ -1373,7 +1375,7 @@ static int ds1307_chip_configure(const struct ds1307 *ds1307)\n \t\tif (regs[1] & RX8025_BIT_PON) {\n \t\t\tregs[1] &= ~RX8025_BIT_PON;\n \t\t\ti2c_smbus_write_byte_data(client,\n-\t\t\t\t\t\t RX8025_REG_CTRL2 << 4 | 0x08,\n+\t\t\t\t\t\t RX8025_REG_CTRL2,\n \t\t\t\t\t\t regs[1]);\n \t\t\tdev_warn(&client->dev, \"power-on detected\\n\");\n \t\t}\n@@ -1381,7 +1383,7 @@ static int ds1307_chip_configure(const struct ds1307 *ds1307)\n \t\tif (regs[1] & RX8025_BIT_VDET) {\n \t\t\tregs[1] &= ~RX8025_BIT_VDET;\n \t\t\ti2c_smbus_write_byte_data(client,\n-\t\t\t\t\t\t RX8025_REG_CTRL2 << 4 | 0x08,\n+\t\t\t\t\t\t RX8025_REG_CTRL2,\n \t\t\t\t\t\t regs[1]);\n \t\t\tdev_warn(&client->dev, \"voltage drop detected\\n\");\n \t\t}\n@@ -1392,11 +1394,11 @@ static int ds1307_chip_configure(const struct ds1307 *ds1307)\n \n \t\t\t/* switch to 24 hour mode */\n \t\t\ti2c_smbus_write_byte_data(client,\n-\t\t\t\t\t\t RX8025_REG_CTRL1 << 4 | 0x08,\n+\t\t\t\t\t\t RX8025_REG_CTRL1,\n \t\t\t\t\t\t regs[0] | RX8025_BIT_2412);\n \n \t\t\ttmp = i2c_smbus_read_i2c_block_data(client,\n-\t\t\t\t\t\t\t RX8025_REG_CTRL1 << 4 | 0x08,\n+\t\t\t\t\t\t\t RX8025_REG_CTRL1,\n \t\t\t\t\t\t\t 2, regs);\n \t\t\tif (tmp != 2) {\n \t\t\t\tdev_dbg(&client->dev, \"read error %d\\n\", tmp);\n","prefixes":["v2","12/17"]}