{"id":638517,"url":"http://patchwork.ozlabs.org/api/patches/638517/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/1466493770-11895-9-git-send-email-andrew.smirnov@gmail.com/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1466493770-11895-9-git-send-email-andrew.smirnov@gmail.com>","list_archive_url":null,"date":"2016-06-21T07:22:43","name":"[v2,10/17] RTC: ds1307: Constify struct ds1307 where possible","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"3f3d7cd808f0a21b1aafc57e60d7cd229e887f99","submitter":{"id":67013,"url":"http://patchwork.ozlabs.org/api/people/67013/?format=json","name":"Andrey Smirnov","email":"andrew.smirnov@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/1466493770-11895-9-git-send-email-andrew.smirnov@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/638517/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/638517/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Received":["from mail-io0-x237.google.com (mail-io0-x237.google.com\n\t[IPv6:2607:f8b0:4001:c06::237])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rYfMd6HtBz9t0V\n\tfor ;\n\tTue, 21 Jun 2016 17:23:09 +1000 (AEST)","by mail-io0-x237.google.com with SMTP id 100sf3630281ioh.1\n\tfor ;\n\tTue, 21 Jun 2016 00:23:09 -0700 (PDT)","by 10.157.11.69 with SMTP id p5ls3393567otd.47.gmail; Tue, 21 Jun\n\t2016 00:23:07 -0700 (PDT)","from mail-pa0-x242.google.com (mail-pa0-x242.google.com.\n\t[2607:f8b0:400e:c03::242]) by gmr-mx.google.com with ESMTPS id\n\tc11si5951082pfc.2.2016.06.21.00.23.07\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 21 Jun 2016 00:23:07 -0700 (PDT)","by mail-pa0-x242.google.com with SMTP id ts6so744545pac.0\n\tfor ;\n\tTue, 21 Jun 2016 00:23:07 -0700 (PDT)","from squirtle.localdomain.localdomain\n\t(c-73-225-163-254.hsd1.wa.comcast.net. [73.225.163.254])\n\tby smtp.gmail.com with ESMTPSA id\n\tp187sm19452396pfg.67.2016.06.21.00.23.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 21 Jun 2016 00:23:07 -0700 (PDT)"],"Authentication-Results":"ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=EMGvQKcI; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=sHaLiZOJ;\n\tdkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20120806;\n\th=sender:mime-version:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:x-original-sender:x-original-authentication-results\n\t:reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=Z4zPB0tZm4NfwXfmDF+pHM1lmA9dVHn+o2CCEtN0lQU=;\n\tb=EMGvQKcIX4iXRHVmKGfOtbEa7Vbcf98fAxnk8+Gc3V/NbzbsSScbqi19f6swEhTGlG\n\t3BdoU5gbrY+TnwKgy52nDYa3esDWiq+/MjCOJMb9ZVk4anTE7GhIpGQYdy+AHMj6fXqz\n\tQObYZcB5SDs9FZw0uyE1haybmorePLhnlkqKG4xG1C81Cxmar4KTfLMn+Z4N/p676T3B\n\tc1FJza4eG6nGk5UU04YaNihhilWglOpBdGbJLAU155NoUvK/Qmpoxrv2ayjuIsFnpn98\n\tEMgSfcEoph9kuE+OIytPfIW/L5HA5q+DfRNvqFdyJztKXfldPHJiQ8bW/UfY3BWNRMdT\n\tUC+A==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20120113;\n\th=mime-version:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:x-original-sender:x-original-authentication-results\n\t:reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=Z4zPB0tZm4NfwXfmDF+pHM1lmA9dVHn+o2CCEtN0lQU=;\n\tb=sHaLiZOJ+nVLfvoITGUEHCcr2uaoDFyaPXBEgPigvpab6gR27XrKWtoG2s0cgWUhSa\n\tNpoKejPySnRGitzkcPktjgPxbFgjqgHPEhKNr9cyiaopl2o5IJt6NkdCl1tOW6b9W9Sy\n\tJ222rOoW1mGDK1cRa6Fp/WgLm2CIWn4NihyLGH2xtxGPB3cBxz4p0/9vvOXHHpVkV6D0\n\t4xdiXETwut5YJZNskTITpGdr5947KWFKhQ+PcuR9Pvbv/mvHSJ63Em7eXBtaVm5Ykm/J\n\t/rHqIb2NfIDEfEppgdtinewD8f8rzWZgmaSX88wmmhY+VbvrSwIBQ7xHnFYSByCpPinI\n\tuyfg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=sender:x-gm-message-state:mime-version:from:to:cc:subject:date\n\t:message-id:in-reply-to:references:x-original-sender\n\t:x-original-authentication-results:reply-to:precedence:mailing-list\n\t:list-id:x-spam-checked-in-group:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=Z4zPB0tZm4NfwXfmDF+pHM1lmA9dVHn+o2CCEtN0lQU=;\n\tb=G3sozTjSeujYGbeo3IvtbGBDSZbUhO2LUJh0PGgoei6U9b9m0gfcTGcNcG+h6DoY+q\n\tzheOjXKqlLorT3hB6XiJor/kErT7TnD+htDQ1V9PjYx6AAAMdBHfsgucyVsqZEFE/u5l\n\tewJVCWsullFY3noEclCMUgbpn7FjvDQsu2ytZIYIVTeMBMaFUCc6ennmuYiYQbSGuuCk\n\tgOpf7pOX71dSmzDwlcbL4l4t0Fv2ZFv/MTcdEjMmikA+DWSE6NhFxroEFhA1k0IAjE+H\n\th340whniEOCOiAqBS6d9hOnNyqwxSW5ziXUTchSAdcK78iYCeCf20gLu/zFLPuz1cPAB\n\t/5PQ==","Sender":"rtc-linux@googlegroups.com","X-Gm-Message-State":"ALyK8tKnQpyUAMPIv85emJZhL9pV8IfIQJH1S7kyWUvb08ULdtycGXCnmNPzo0kGpB7UOQ==","X-Received":["by 10.157.11.173 with SMTP id 42mr266095oth.10.1466493788082;\n\tTue, 21 Jun 2016 00:23:08 -0700 (PDT)","by 10.157.47.98 with SMTP id h89mr8742867otb.12.1466493787881;\n\tTue, 21 Jun 2016 00:23:07 -0700 (PDT)","by 10.67.3.7 with SMTP id bs7mr26859211pad.86.1466493787578;\n\tTue, 21 Jun 2016 00:23:07 -0700 (PDT)"],"MIME-Version":"1.0","X-BeenThere":"rtc-linux@googlegroups.com","Received-SPF":"pass (google.com: domain of andrew.smirnov@gmail.com\n\tdesignates 2607:f8b0:400e:c03::242 as permitted sender)\n\tclient-ip=2607:f8b0:400e:c03::242; ","From":"Andrey Smirnov ","To":"rtc-linux@googlegroups.com","Cc":"Andrey Smirnov ,\n\tAlessandro Zummo ,\n\tAlexandre Belloni ,\n\tlinux-kernel@vger.kernel.org, cphealy@gmail.com","Subject":"[rtc-linux] [PATCH v2 10/17] RTC: ds1307: Constify struct ds1307\n\twhere possible","Date":"Tue, 21 Jun 2016 00:22:43 -0700","Message-Id":"<1466493770-11895-9-git-send-email-andrew.smirnov@gmail.com>","X-Mailer":"git-send-email 2.5.5","In-Reply-To":"<1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com>","References":"<1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com>","X-Original-Sender":"andrew.smirnov@gmail.com","X-Original-Authentication-Results":"gmr-mx.google.com; dkim=pass\n\theader.i=@gmail.com; spf=pass (google.com: domain of\n\tandrew.smirnov@gmail.com designates 2607:f8b0:400e:c03::242 as\n\tpermitted\n\tsender) smtp.mailfrom=andrew.smirnov@gmail.com; dmarc=pass (p=NONE\n\tdis=NONE) header.from=gmail.com","Reply-To":"rtc-linux@googlegroups.com","Content-Type":"text/plain; charset=UTF-8","Precedence":"list","Mailing-list":"list rtc-linux@googlegroups.com;\n\tcontact rtc-linux+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"rtc-linux@googlegroups.com","X-Google-Group-Id":"712029733259","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"},"content":"Signed-off-by: Andrey Smirnov \n---\n drivers/rtc/rtc-ds1307.c | 50 ++++++++++++++++++++++++------------------------\n 1 file changed, 25 insertions(+), 25 deletions(-)","diff":"diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c\nindex 66e7168..67907f1 100644\n--- a/drivers/rtc/rtc-ds1307.c\n+++ b/drivers/rtc/rtc-ds1307.c\n@@ -333,7 +333,7 @@ static s32 ds1307_native_smbus_read_block_data(const struct i2c_client *client,\n static irqreturn_t ds1307_irq(int irq, void *dev_id)\n {\n \tstruct i2c_client\t*client = dev_id;\n-\tstruct ds1307\t\t*ds1307 = i2c_get_clientdata(client);\n+\tconst struct ds1307\t*ds1307 = i2c_get_clientdata(client);\n \tstruct mutex\t\t*lock = &ds1307->rtc->ops_lock;\n \tint\t\t\tstat, control;\n \n@@ -367,8 +367,8 @@ out:\n static int ds1307_get_time(struct device *dev, struct rtc_time *t)\n {\n \tu8 regs[DS1307_REG_COUNT];\n-\tstruct ds1307\t*ds1307 = dev_get_drvdata(dev);\n \tint\t\ttmp;\n+\tconst struct ds1307 *ds1307 = dev_get_drvdata(dev);\n \n \t/* read the RTC date and time registers all at once */\n \ttmp = ds1307->read_block_data(ds1307->client,\n@@ -404,7 +404,7 @@ static int ds1307_get_time(struct device *dev, struct rtc_time *t)\n \n static int ds1307_set_time(struct device *dev, struct rtc_time *t)\n {\n-\tstruct ds1307\t*ds1307 = dev_get_drvdata(dev);\n+\tconst struct ds1307 *ds1307 = dev_get_drvdata(dev);\n \tint\t\tresult;\n \tint\t\ttmp;\n \tu8\t\tregs[DS1307_REG_COUNT];\n@@ -464,7 +464,7 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t)\n static int ds1337_read_alarm(struct device *dev, struct rtc_wkalrm *t)\n {\n \tstruct i2c_client *client = to_i2c_client(dev);\n-\tstruct ds1307\t\t*ds1307 = i2c_get_clientdata(client);\n+\tconst struct ds1307\t*ds1307 = i2c_get_clientdata(client);\n \tint\t\t\tret;\n \tu8\t\t\tregs[DS1307_REG_COUNT];\n \n@@ -512,7 +512,7 @@ static int ds1337_read_alarm(struct device *dev, struct rtc_wkalrm *t)\n static int ds1337_set_alarm(struct device *dev, struct rtc_wkalrm *t)\n {\n \tstruct i2c_client\t*client = to_i2c_client(dev);\n-\tstruct ds1307\t\t*ds1307 = i2c_get_clientdata(client);\n+\tconst struct ds1307\t*ds1307 = i2c_get_clientdata(client);\n \tu8\t\t\tregs[DS1307_REG_COUNT];\n \tu8\t\t\tcontrol, status;\n \tint\t\t\tret;\n@@ -574,7 +574,7 @@ static int ds1337_set_alarm(struct device *dev, struct rtc_wkalrm *t)\n static int ds1307_alarm_irq_enable(struct device *dev, unsigned int enabled)\n {\n \tstruct i2c_client\t*client = to_i2c_client(dev);\n-\tstruct ds1307\t\t*ds1307 = i2c_get_clientdata(client);\n+\tconst struct ds1307\t*ds1307 = i2c_get_clientdata(client);\n \tint\t\t\tret;\n \n \tif (!test_bit(HAS_ALARM, &ds1307->flags))\n@@ -629,7 +629,7 @@ static const struct rtc_class_ops ds13xx_rtc_ops = {\n static irqreturn_t mcp794xx_irq(int irq, void *dev_id)\n {\n \tstruct i2c_client *client = dev_id;\n-\tstruct ds1307 *ds1307 = i2c_get_clientdata(client);\n+\tconst struct ds1307 *ds1307 = i2c_get_clientdata(client);\n \tstruct mutex *lock = &ds1307->rtc->ops_lock;\n \tint reg, ret;\n \n@@ -666,7 +666,7 @@ out:\n static int mcp794xx_read_alarm(struct device *dev, struct rtc_wkalrm *t)\n {\n \tstruct i2c_client *client = to_i2c_client(dev);\n-\tstruct ds1307 *ds1307 = i2c_get_clientdata(client);\n+\tconst struct ds1307 *ds1307 = i2c_get_clientdata(client);\n \tu8 regs[DS1307_REG_COUNT];\n \tint ret;\n \n@@ -705,7 +705,7 @@ static int mcp794xx_read_alarm(struct device *dev, struct rtc_wkalrm *t)\n static int mcp794xx_set_alarm(struct device *dev, struct rtc_wkalrm *t)\n {\n \tstruct i2c_client *client = to_i2c_client(dev);\n-\tstruct ds1307 *ds1307 = i2c_get_clientdata(client);\n+\tconst struct ds1307 *ds1307 = i2c_get_clientdata(client);\n \tu8 regs[DS1307_REG_COUNT];\n \tint ret;\n \n@@ -751,7 +751,7 @@ static int mcp794xx_set_alarm(struct device *dev, struct rtc_wkalrm *t)\n static int mcp794xx_alarm_irq_enable(struct device *dev, unsigned int enabled)\n {\n \tstruct i2c_client *client = to_i2c_client(dev);\n-\tstruct ds1307 *ds1307 = i2c_get_clientdata(client);\n+\tconst struct ds1307 *ds1307 = i2c_get_clientdata(client);\n \tint reg;\n \n \tif (!test_bit(HAS_ALARM, &ds1307->flags))\n@@ -785,7 +785,7 @@ ds1307_nvram_read(struct file *filp, struct kobject *kobj,\n \t\tchar *buf, loff_t off, size_t count)\n {\n \tstruct i2c_client\t*client;\n-\tstruct ds1307\t\t*ds1307;\n+\tconst struct ds1307\t*ds1307;\n \tint\t\t\tresult;\n \n \tclient = kobj_to_i2c_client(kobj);\n@@ -804,7 +804,7 @@ ds1307_nvram_write(struct file *filp, struct kobject *kobj,\n \t\tchar *buf, loff_t off, size_t count)\n {\n \tstruct i2c_client\t*client;\n-\tstruct ds1307\t\t*ds1307;\n+\tconst struct ds1307\t*ds1307;\n \tint\t\t\tresult;\n \n \tclient = kobj_to_i2c_client(kobj);\n@@ -880,7 +880,7 @@ out:\n */\n static int ds3231_hwmon_read_temp(struct device *dev, s32 *mC)\n {\n-\tstruct ds1307 *ds1307 = dev_get_drvdata(dev);\n+\tconst struct ds1307 *ds1307 = dev_get_drvdata(dev);\n \tu8 temp_buf[2];\n \ts16 temp;\n \tint ret;\n@@ -973,7 +973,7 @@ static int ds3231_clk_sqw_rates[] = {\n \t8192,\n };\n \n-static int ds1337_write_control(struct ds1307 *ds1307, u8 mask, u8 value)\n+static int ds1337_write_control(const struct ds1307 *ds1307, u8 mask, u8 value)\n {\n \tstruct i2c_client *client = ds1307->client;\n \tstruct mutex *lock = &ds1307->rtc->ops_lock;\n@@ -1001,7 +1001,7 @@ out:\n static unsigned long ds3231_clk_sqw_recalc_rate(struct clk_hw *hw,\n \t\t\t\t\t\tunsigned long parent_rate)\n {\n-\tstruct ds1307 *ds1307 = clk_sqw_to_ds1307(hw);\n+\tconst struct ds1307 *ds1307 = clk_sqw_to_ds1307(hw);\n \tint control;\n \tint rate_sel = 0;\n \n@@ -1032,7 +1032,7 @@ static long ds3231_clk_sqw_round_rate(struct clk_hw *hw, unsigned long rate,\n static int ds3231_clk_sqw_set_rate(struct clk_hw *hw, unsigned long rate,\n \t\t\t\t\tunsigned long parent_rate)\n {\n-\tstruct ds1307 *ds1307 = clk_sqw_to_ds1307(hw);\n+\tconst struct ds1307 *ds1307 = clk_sqw_to_ds1307(hw);\n \tint control = 0;\n \tint rate_sel;\n \n@@ -1056,21 +1056,21 @@ static int ds3231_clk_sqw_set_rate(struct clk_hw *hw, unsigned long rate,\n \n static int ds3231_clk_sqw_prepare(struct clk_hw *hw)\n {\n-\tstruct ds1307 *ds1307 = clk_sqw_to_ds1307(hw);\n+\tconst struct ds1307 *ds1307 = clk_sqw_to_ds1307(hw);\n \n \treturn ds1337_write_control(ds1307, DS1337_BIT_INTCN, 0);\n }\n \n static void ds3231_clk_sqw_unprepare(struct clk_hw *hw)\n {\n-\tstruct ds1307 *ds1307 = clk_sqw_to_ds1307(hw);\n+\tconst struct ds1307 *ds1307 = clk_sqw_to_ds1307(hw);\n \n \tds1337_write_control(ds1307, DS1337_BIT_INTCN, DS1337_BIT_INTCN);\n }\n \n static int ds3231_clk_sqw_is_prepared(struct clk_hw *hw)\n {\n-\tstruct ds1307 *ds1307 = clk_sqw_to_ds1307(hw);\n+\tconst struct ds1307 *ds1307 = clk_sqw_to_ds1307(hw);\n \tint control;\n \n \tcontrol = i2c_smbus_read_byte_data(ds1307->client, DS1337_REG_CONTROL);\n@@ -1095,7 +1095,7 @@ static unsigned long ds3231_clk_32khz_recalc_rate(struct clk_hw *hw,\n \treturn 32768;\n }\n \n-static int ds3231_clk_32khz_control(struct ds1307 *ds1307, bool enable)\n+static int ds3231_clk_32khz_control(const struct ds1307 *ds1307, bool enable)\n {\n \tstruct i2c_client *client = ds1307->client;\n \tstruct mutex *lock = &ds1307->rtc->ops_lock;\n@@ -1124,21 +1124,21 @@ out:\n \n static int ds3231_clk_32khz_prepare(struct clk_hw *hw)\n {\n-\tstruct ds1307 *ds1307 = clk_32khz_to_ds1307(hw);\n+\tconst struct ds1307 *ds1307 = clk_32khz_to_ds1307(hw);\n \n \treturn ds3231_clk_32khz_control(ds1307, true);\n }\n \n static void ds3231_clk_32khz_unprepare(struct clk_hw *hw)\n {\n-\tstruct ds1307 *ds1307 = clk_32khz_to_ds1307(hw);\n+\tconst struct ds1307 *ds1307 = clk_32khz_to_ds1307(hw);\n \n \tds3231_clk_32khz_control(ds1307, false);\n }\n \n static int ds3231_clk_32khz_is_prepared(struct clk_hw *hw)\n {\n-\tstruct ds1307 *ds1307 = clk_32khz_to_ds1307(hw);\n+\tconst struct ds1307 *ds1307 = clk_32khz_to_ds1307(hw);\n \tint status;\n \n \tstatus = i2c_smbus_read_byte_data(ds1307->client, DS1337_REG_STATUS);\n@@ -1273,7 +1273,7 @@ static bool ds1307_want_irq(const struct ds1307 *ds1307,\n \treturn false;\n }\n \n-static int ds1307_chip_configure(struct ds1307 *ds1307)\n+static int ds1307_chip_configure(const struct ds1307 *ds1307)\n {\n \tint tmp;\n \tu8 regs[DS1307_REG_COUNT];\n@@ -1422,7 +1422,7 @@ static int ds1307_chip_configure(struct ds1307 *ds1307)\n \treturn 0;\n }\n \n-static int ds1307_chip_sanity_check(struct ds1307 *ds1307)\n+static int ds1307_chip_sanity_check(const struct ds1307 *ds1307)\n {\n \tint tmp;\n \tu8 regs[DS1307_REG_COUNT];\n","prefixes":["v2","10/17"]}