{"id":2237929,"url":"http://patchwork.ozlabs.org/api/patches/2237929/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ide/patch/20260513151359.1075403-7-cassel@kernel.org/","project":{"id":13,"url":"http://patchwork.ozlabs.org/api/projects/13/?format=json","name":"Linux IDE development","link_name":"linux-ide","list_id":"linux-ide.vger.kernel.org","list_email":"linux-ide@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260513151359.1075403-7-cassel@kernel.org>","list_archive_url":null,"date":"2026-05-13T15:14:00","name":"[v4,1/4] ata: libata-scsi: improve readability of ata_scsi_qc_issue()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"693f86e8deb815e9ce053789f80b87ac66ddace6","submitter":{"id":87751,"url":"http://patchwork.ozlabs.org/api/people/87751/?format=json","name":"Niklas Cassel","email":"cassel@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ide/patch/20260513151359.1075403-7-cassel@kernel.org/mbox/","series":[{"id":504179,"url":"http://patchwork.ozlabs.org/api/series/504179/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ide/list/?series=504179","date":"2026-05-13T15:13:59","name":"ata: fix deferred QC handling for port multipliers","version":4,"mbox":"http://patchwork.ozlabs.org/series/504179/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2237929/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2237929/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ldmgscwt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ide+bounces-5740-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"ldmgscwt\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gFz0j63Nqz1y5L\n\tfor ; Thu, 14 May 2026 02:08:53 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 497A632C1A2B\n\tfor ; Wed, 13 May 2026 15:18:06 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0339E495538;\n\tWed, 13 May 2026 15:14:11 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D4FC947DD6C\n\tfor ; Wed, 13 May 2026 15:14:10 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 256DDC19425;\n\tWed, 13 May 2026 15:14:08 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778685250; cv=none;\n b=WpRRvVMWDTYtqwhrcjn2ZKTbgv1NvnURmD4y/914GaPJFYq4jS/fkiWGegG/oxuPb0clB5U9n1SUvPgzPUE3Pb+D+H1OQbODGn8Y1oWiXvK3q2Z1iBiezQjNcw1PYWa0yBlOuQAYpXMuGgZhCqahMW/KGbWKZXOfts2WF54VGD4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778685250; c=relaxed/simple;\n\tbh=7XVAuWe9jwMAcS2atGTSKlwZh4NFZXOJ0YhwSzZ0zxk=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=DDU1LonXtTZFPP7/CpdCmbIlGcuijWLCSaz7OlZpDt49UiUmcfNDEWHva6Ps5xFiENX0RJaKxQTf1bMABwhcR80cebzVWtyoEq/mXuSL2GwBAb4Q6K1MVw9lfMCKB0HovY6oB+OH3bMmHN2VSkulhiEaoe4Sbo1TWLzk1GUM5oc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=ldmgscwt; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778685250;\n\tbh=7XVAuWe9jwMAcS2atGTSKlwZh4NFZXOJ0YhwSzZ0zxk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ldmgscwthOdxdOSzASrAjOIKYsvyvocO9ydrtrFfXWRgCuNXLwgDR6EfGUWDxPSG2\n\t W0W6Vj94dKTKssXXF3DNpIr6fnA+EktspMlwZfiBFbMXxQoIWsYj/IGE+M7JYRGLPE\n\t +ez35GP6ppCrTH5UoRH6E6tvKYsU2G13IFV4Czy9Wq6Ktlf9deXB4ltyknb9BVR6Wu\n\t k5TFWMnP6VXfeMZliYCtF7/aK+tOslv+HTezi6/vQJwfCG8esSQRoPraPwGX2vWiAf\n\t UbxCEhghNWzmSBjcd9nv89nxK6id0YI3HbBpO5Ce4DY3ob5rH9vvB09tERo3j7Lxal\n\t TIVXnyafycqVw==","From":"Niklas Cassel ","To":"Tommy Kelly ,\n\tDamien Le Moal ,\n\tNiklas Cassel ","Cc":"John Garry ,\n\tlinux-ide@vger.kernel.org","Subject":"[PATCH v4 1/4] ata: libata-scsi: improve readability of\n ata_scsi_qc_issue()","Date":"Wed, 13 May 2026 17:14:00 +0200","Message-ID":"<20260513151359.1075403-7-cassel@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260513151359.1075403-6-cassel@kernel.org>","References":"<20260513151359.1075403-6-cassel@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2217; i=cassel@kernel.org;\n h=from:subject; bh=7XVAuWe9jwMAcS2atGTSKlwZh4NFZXOJ0YhwSzZ0zxk=;\n b=owGbwMvMwCV2MsVw8cxjvkWMp9WSGLJYpppf7Ft/1q1wo/q/lzyMv60+nVnnkTwnUutw2rc1H\n yY+P/onuaOUhUGMi0FWTJHF94fL/uJu9ynHFe/YwMxhZQIZwsDFKQAT6VRg+J960ljxBcti7fMr\n UuOrOUt3SZW18ThbmV09ynFvxp+CJhuG/75zOFZNfv0qYIOln9XtGqmUOd4W3UnLOZj23bx7auK\n rTxwA","X-Developer-Key":"i=cassel@kernel.org; a=openpgp;\n fpr=5ADE635C0E631CBBD5BE065A352FE6582ED9B5DA","Content-Transfer-Encoding":"8bit"},"content":"Improve readability of ata_scsi_qc_issue().\n\nNo functional changes.\n\nSigned-off-by: Niklas Cassel \n---\n drivers/ata/libata-scsi.c | 43 +++++++++++++++++++--------------------\n 1 file changed, 21 insertions(+), 22 deletions(-)","diff":"diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c\nindex 6733f2b14521..b9064dd4390c 100644\n--- a/drivers/ata/libata-scsi.c\n+++ b/drivers/ata/libata-scsi.c\n@@ -1767,7 +1767,7 @@ static int ata_scsi_qc_issue(struct ata_port *ap, struct ata_queued_cmd *qc)\n \tint ret;\n \n \tif (!ap->ops->qc_defer)\n-\t\tgoto issue;\n+\t\tgoto issue_qc;\n \n \t/*\n \t * If we already have a deferred qc, then rely on the SCSI layer to\n@@ -1786,38 +1786,37 @@ static int ata_scsi_qc_issue(struct ata_port *ap, struct ata_queued_cmd *qc)\n \t\tbreak;\n \tcase ATA_DEFER_LINK:\n \t\tret = SCSI_MLQUEUE_DEVICE_BUSY;\n-\t\tbreak;\n+\t\tgoto defer_qc;\n \tcase ATA_DEFER_PORT:\n \t\tret = SCSI_MLQUEUE_HOST_BUSY;\n-\t\tbreak;\n+\t\tgoto defer_qc;\n \tdefault:\n \t\tWARN_ON_ONCE(1);\n \t\tret = SCSI_MLQUEUE_HOST_BUSY;\n-\t\tbreak;\n+\t\tgoto defer_qc;\n \t}\n \n-\tif (ret) {\n-\t\t/*\n-\t\t * We must defer this qc: if this is not an NCQ command, keep\n-\t\t * this qc as a deferred one and report to the SCSI layer that\n-\t\t * we issued it so that it is not requeued. The deferred qc will\n-\t\t * be issued with the port deferred_qc_work once all on-going\n-\t\t * commands complete.\n-\t\t */\n-\t\tif (!ata_is_ncq(qc->tf.protocol)) {\n-\t\t\tap->deferred_qc = qc;\n-\t\t\treturn 0;\n-\t\t}\n+issue_qc:\n+\tata_qc_issue(qc);\n+\treturn 0;\n \n-\t\t/* Force a requeue of the command to defer its execution. */\n-\t\tata_qc_free(qc);\n-\t\treturn ret;\n+defer_qc:\n+\t/*\n+\t * We must defer this qc: if this is not an NCQ command, keep\n+\t * this qc as a deferred one and report to the SCSI layer that\n+\t * we issued it so that it is not requeued. The deferred qc will\n+\t * be issued with the port deferred_qc_work once all on-going\n+\t * commands complete.\n+\t */\n+\tif (!ata_is_ncq(qc->tf.protocol)) {\n+\t\tap->deferred_qc = qc;\n+\t\treturn 0;\n \t}\n \n-issue:\n-\tata_qc_issue(qc);\n+\t/* Force a requeue of the command to defer its execution. */\n+\tata_qc_free(qc);\n \n-\treturn 0;\n+\treturn ret;\n }\n \n /**\n","prefixes":["v4","1/4"]}