{"id":2232375,"url":"http://patchwork.ozlabs.org/api/patches/2232375/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260504121603.1702674-1-poros@redhat.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260504121603.1702674-1-poros@redhat.com>","list_archive_url":null,"date":"2026-05-04T12:16:03","name":"[iwl-net] ice: fix missing priority callbacks for U.FL DPLL pins","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a20d3ae13b399ac4881d43dfde2c0a58ebeaca31","submitter":{"id":74657,"url":"http://patchwork.ozlabs.org/api/people/74657/?format=json","name":"Petr Oros","email":"poros@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260504121603.1702674-1-poros@redhat.com/mbox/","series":[{"id":502652,"url":"http://patchwork.ozlabs.org/api/series/502652/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=502652","date":"2026-05-04T12:16:03","name":"[iwl-net] ice: fix missing priority callbacks for U.FL DPLL pins","version":1,"mbox":"http://patchwork.ozlabs.org/series/502652/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232375/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232375/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=CbpOIauQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8LGv5rB8z1yJV\n\tfor ; Mon, 04 May 2026 22:16:39 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 49CE041A45;\n\tMon, 4 May 2026 12:16:38 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id K-BHkbtcET_D; Mon, 4 May 2026 12:16:37 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 88F374178D;\n\tMon, 4 May 2026 12:16:37 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 3EA75204\n for ; Mon, 4 May 2026 12:16:36 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 2E8664178D\n for ; Mon, 4 May 2026 12:16:36 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id HoB7Hyd1qbav for ;\n Mon, 4 May 2026 12:16:35 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 1CC554177E\n for ; Mon, 4 May 2026 12:16:34 +0000 (UTC)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-LrtmlwPiOKuCdnt5m95f2g-1; Mon,\n 04 May 2026 08:16:30 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id F1CF318005A9; Mon, 4 May 2026 12:16:26 +0000 (UTC)","from ShadowPeak.redhat.com (unknown [10.44.49.137])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 3296D19560B1; Mon, 4 May 2026 12:16:22 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 88F374178D","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1CC554177E"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777896997;\n\tbh=2sstvlgjHF5YnWZtlmXTF4LSbEWS2pzj7DOEfpRp9Fg=;\n\th=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:Cc:From;\n\tb=CbpOIauQxRPYbV9AXoprNrWD6pzmzX0A6a2BzoUHapophPGjG5qytsKc6emcKaW2k\n\t ndY4AI2DyQgRYAn1aYsZjUIDpIPR9VSl6Hh/QsqFR01OXqv/tQ2WbkEEtVajnmIrM7\n\t wFES5Cm4xQCh+0l545amnY5Bk1W0AyVFb7ORTR2iGZrsJ0Iw/j521bojbIsQcySQdf\n\t 8UB/R/auNWZ704H5ubR5qFpuRiQcoHhBlq5C2yXvoKgn0u9UDZPmrEknZFP6NEa7hp\n\t 6OLO/1BCL3mOQUnRvSTBDYrrW72zEhfXbublyXRQUhEtlsMm4PpThZK81VAeAS+5rR\n\t TaYDw5uCXyTqw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=poros@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 1CC554177E","X-MC-Unique":"LrtmlwPiOKuCdnt5m95f2g-1","X-Mimecast-MFC-AGG-ID":"LrtmlwPiOKuCdnt5m95f2g_1777896987","From":"Petr Oros ","To":"netdev@vger.kernel.org","Date":"Mon, 4 May 2026 14:16:03 +0200","Message-ID":"<20260504121603.1702674-1-poros@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-MFC-PROC-ID":"jpHCV820FDQiO8gOztJHiWvFijb4rZW79vji6AUsld0_1777896987","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1777896993;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=2sstvlgjHF5YnWZtlmXTF4LSbEWS2pzj7DOEfpRp9Fg=;\n b=bxTUzbzwy6m9lcUTr48h2DyzQeWvCPBX6M0yuLl6Y8ZTODoWAnuM6dT/t8FCFau3Dz2EU+\n SN4+igDGJgtm6SbxxMKvg3H6K9f8rpDMeCekp7874eX3+/7zxGgLPCOLtkTWQmki1ZL70U\n 8gY/lqrTmLFSB/8v0X7It5zJae3XLD0=","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp4.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=bxTUzbzw"],"Subject":"[Intel-wired-lan] [PATCH iwl-net] ice: fix missing priority\n callbacks for U.FL DPLL pins","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Przemek Kitszel ,\n Eric Dumazet ,\n Arkadiusz Kubalewski ,\n Andrew Lunn ,\n Tony Nguyen ,\n Simon Horman , intel-wired-lan@lists.osuosl.org,\n Jakub Kicinski , Paolo Abeni ,\n \"David S. Miller\" , linux-kernel@vger.kernel.org","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"The U.FL2 input pin advertises DPLL_PIN_CAPABILITIES_PRIORITY_CAN_CHANGE\nin its capability mask, but ice_dpll_pin_ufl_ops does not provide\n.prio_get and .prio_set callbacks. As a result the DPLL subsystem\ncannot report or accept priority for U.FL pins: pin-get omits the prio\nfield on U.FL2 and pin-set with prio is rejected as invalid, even\nthough the capability is present. This prevents user space from using\npriority to select or disable U.FL2 as a DPLL input source.\n\nAdd the missing .prio_get and .prio_set callbacks to\nice_dpll_pin_ufl_ops, reusing ice_dpll_sw_input_prio_{get,set}. The\nsame ops struct is shared by U.FL1 and U.FL2: U.FL2 (input) delegates\nto the backing hardware input pin, while U.FL1 (output) does not\nadvertise DPLL_PIN_CAPABILITIES_PRIORITY_CAN_CHANGE so the dpll core\ncapability gate never invokes the callback for it. The reused helpers\nalso guard on p->direction != DPLL_PIN_DIRECTION_INPUT and !p->input\nas defense in depth.\n\nFixes: 2dd5d03c77e2 (\"ice: redesign dpll sma/u.fl pins control\")\nSigned-off-by: Petr Oros \n---\n drivers/net/ethernet/intel/ice/ice_dpll.c | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethernet/intel/ice/ice_dpll.c\nindex 27b460926baced..be72a076f7a15c 100644\n--- a/drivers/net/ethernet/intel/ice/ice_dpll.c\n+++ b/drivers/net/ethernet/intel/ice/ice_dpll.c\n@@ -2628,6 +2628,8 @@ static const struct dpll_pin_ops ice_dpll_pin_ufl_ops = {\n \t.state_on_dpll_set = ice_dpll_ufl_pin_state_set,\n \t.state_on_dpll_get = ice_dpll_sw_pin_state_get,\n \t.direction_get = ice_dpll_pin_sw_direction_get,\n+\t.prio_get = ice_dpll_sw_input_prio_get,\n+\t.prio_set = ice_dpll_sw_input_prio_set,\n \t.frequency_get = ice_dpll_sw_pin_frequency_get,\n \t.frequency_set = ice_dpll_sw_pin_frequency_set,\n \t.esync_set = ice_dpll_sw_esync_set,\n","prefixes":["iwl-net"]}