{"id":2232372,"url":"http://patchwork.ozlabs.org/api/patches/2232372/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-35-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260504-qom-tests-v2-35-ef7e3dc94f7a@redhat.com>","list_archive_url":null,"date":"2026-05-04T11:35:23","name":"[v2,35/46] hw/gpio/pca9552: fix state_str leak in pca955x_set_led","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5e5f937d6c8b25284097ddaac03525bc739d4c67","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-35-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232372/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232372/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ifZUWnEe;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KTg097tz1yJ9\n\tfor ; Mon, 04 May 2026 21:40:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrdP-0007aZ-9i; Mon, 04 May 2026 07:38:47 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrdM-0007HG-Nv\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:44 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrdL-0001Je-4m\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:44 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-456-IddKBZgKOvKx3xT3MPB0Rg-1; Mon,\n 04 May 2026 07:38:38 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E1FC018005AA; Mon, 4 May 2026 11:38:37 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D1DA619560A6; Mon, 4 May 2026 11:38:36 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894722;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=pE6Pca7W7tBGiOTIVoQ+zK1N9Z4QVqZ8xEfNADow84I=;\n b=ifZUWnEefo2g0fCZUx/EQCAJBX5dx781UJa/1HNsJDmGwTqt7g1bGHCPkNnyuCRrIe2D//\n aeJkkhOaSVOrbEyc8kCuY+nGCE8sq2/Tv989MMuwQEoPKRO9UGN50fj2F6kkZgosF5yDj2\n 0uxQL9ZPfdVJ5CIZnQXAQoRemqBz+js=","X-MC-Unique":"IddKBZgKOvKx3xT3MPB0Rg-1","X-Mimecast-MFC-AGG-ID":"IddKBZgKOvKx3xT3MPB0Rg_1777894718","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:23 +0400","Subject":"[PATCH v2 35/46] hw/gpio/pca9552: fix state_str leak in\n pca955x_set_led","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-35-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Glenn Miles ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=930;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=Yyqdk4pqgUvsNBnd22QgjuieBpuRTzwJTZeeL08X0pU=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtH0un1uSz1Bb/OU6ul3laQWKoZiN4dZE1f\n 3PZdd5HWgOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac\n 5WR3D/9OYyZdGvCz6KFa6bFLMtxwCIJjxG20speZdkTR6W2lTwXTNIOztZhYcyRmmzZjQt6PvME\n II1Tb6lLCrInlElu7wZDLDYsIZzRp6rtwD74wJC2klLF1JHGkKa4PyVsz8gKIGNrJq8R5aZ/vJH\n mWbwhxgCeYcATFCpfDyj21ynB6IXTYBUrYCVbz/off1OZutvb2OPENZeGPNuvBCEXXHsT7Xc6QT\n mjrq6Y0KyWh1rr9FEFGLYqgUr5KwbDiVrd4GC/4NYJzHjYdswErwN9gHfl/sAZO9We6PMC4gnyD\n DKbHQnEbcUSuDLVK0f+//bys5RBL28+AjSWhiLB7ffmiWI0GhtIYZHSytL76UnD2IykyD6W74tv\n t2qltbZqlt6mp2jYadC+FjUFszhLhAohRr1eqANhWiZG6uRBfgG50iNT8//Gw7Uugz4PDhllC41\n sdOd4cD/bfCFzpVgwOSlonfGf0roPhkoCtfmIXEl7LpeAkAzY2yVvtvyhOupY3Q+l7F850JaHdN\n 4fU/JZowuxVWu/DX8qBH7/UuqnLIwAeDGN3wrC7PW4CjpM4WqShUE5io3nAv/E2bJfihHcuiKSL\n NTK9PTznYbyJyhwNdM+wvGxOYmGqUXkMhutbKNL5nCdPIIcjORHmeaY0pueKPn8XwGJ/3DN8HBo\n nk1lBk4/cWXke2A==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"visit_type_str() allocates state_str, but the function never frees it\non any code path. Use g_autofree to ensure it is freed on return.\n\nFixes: a90d8f84674d (\"misc/pca9552: Add qom set and get\")\nReviewed-by: Glenn Miles \nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n hw/gpio/pca9552.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c\nindex dd3f1536b65..472d8ad9571 100644\n--- a/hw/gpio/pca9552.c\n+++ b/hw/gpio/pca9552.c\n@@ -342,7 +342,7 @@ static void pca955x_set_led(Object *obj, Visitor *v, const char *name,\n PCA955xState *s = PCA955X(obj);\n int led, rc, reg, val;\n uint8_t state;\n- char *state_str;\n+ g_autofree char *state_str = NULL;\n \n if (!visit_type_str(v, name, &state_str, errp)) {\n return;\n","prefixes":["v2","35/46"]}