{"id":2232363,"url":"http://patchwork.ozlabs.org/api/patches/2232363/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-34-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260504-qom-tests-v2-34-ef7e3dc94f7a@redhat.com>","list_archive_url":null,"date":"2026-05-04T11:35:22","name":"[v2,34/46] hw/fsi: move OPBus qbus_init() to instance_init","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0d3064903d4657b46257d88a7c19de396b7a1134","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-34-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232363/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232363/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=J5E/rmy/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KSc6Nbmz1yJV\n\tfor ; Mon, 04 May 2026 21:40:00 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrdK-0006qm-Fk; Mon, 04 May 2026 07:38:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrdF-0006Wo-Gv\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:38 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrdD-0001Il-Ps\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:37 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-30-_x_9NHkxMY-Wyjy6jtvc5w-1; Mon,\n 04 May 2026 07:38:32 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id F1C2D1956053\n for ; Mon, 4 May 2026 11:38:31 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 63E3E19560B1; Mon, 4 May 2026 11:38:29 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894715;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=R0bsIIMKhxFpIJn0xl6jXJpi31e37LsGmYzmuzP6pM4=;\n b=J5E/rmy/0VZOWMUXTa5OV8E0ItAvZzjRgZ7dXKZXC3vjGme9wLSH7Fs+NO0rjd6a9BUhyu\n F2FMETXDFtbBqSdW8LEreHCXEWeQlRHjUfU+/Fdve9P3lzvxznM9fsItgNtqFbQzM4MVng\n hxfnurcrcuEDoWTl7givFprLbidBU2I=","X-MC-Unique":"_x_9NHkxMY-Wyjy6jtvc5w-1","X-Mimecast-MFC-AGG-ID":"_x_9NHkxMY-Wyjy6jtvc5w_1777894712","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:22 +0400","Subject":"[PATCH v2 34/46] hw/fsi: move OPBus qbus_init() to instance_init","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-34-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?C=C3=A9dric_Le_Goater?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1604;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=CVudjOeCyZzDTPF5IBNWQlIgSw+1Rz8G/fZyKfzNExw=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtZ79WtCadqntEqeNDEhdxBLIEkOMbnlciD\n NtU3PK2QwmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac\n 5a8/D/4pwdSQCD7+NMRTqLTM6CNdc2m1lYb/kNngSd6LxcPoc3wHUylgG4L8nbQkNSkdLq7nGxO\n NfR9mSYuVrylntmbxQtES8uzvB1COP2N/OH+N/c+z3RsvV/StSaymDCkgD/yIBVbKqHPk35Z6EM\n POVN2WknnJbXQClJDBpfIb5Z5XVZ8QPXIVZxEf5L0gEL0piDDbaRAPVkWQJFf1cH6ad2inAonw3\n LJGvymaLYpHhdHc9p0RhDVx1e8LoWwN4Fgafe2YfLbHMPlnubgH8MIOXLsr1/Vso+dxQN/YJwvm\n JOeoxgl6qBf6jWLTu7NFuKHqco4wkSNxCni+zffWbfzFdNnApvhSBr3cFMFLGvwIrcTUQk/T9j5\n RfHn6MQ/3sBhDfKBurs+e9rK+BXkdNIVCgPcFlMEVQyz4KXmdJBWvHB4adf8LAtA+1kU4xVMTHk\n 2D3/nxnuMqNvSMy4mDuxcWgdxba2xKfy+rXiYoIiAGQTWA3S6kE4GxSiFuDxhLyfIKi73ZTqnCF\n P5qqmzDIj94djIj8oQ5R872cQKqYGdMMEZh08GPj+/htnNoZbvop3geB9cHgDgaaS4C6pguMwfi\n 3XKXNRqwArLJBrtXc5cmMK1w31lNgOiqj3I/kFl5aCzhkQjmXucwt+Aq4o63gUBTLnXkp3BbCP9\n gb2RFcVrF3UtdIA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"8","X-Spam_score":"0.8","X-Spam_bar":"/","X-Spam_report":"(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Remove the TODO comment that documented the workaround, as it is\nno longer needed.\n\nSuggested-by: Cédric Le Goater \nSigned-off-by: Marc-André Lureau \n---\n hw/fsi/aspeed_apb2opb.c | 13 +------------\n 1 file changed, 1 insertion(+), 12 deletions(-)","diff":"diff --git a/hw/fsi/aspeed_apb2opb.c b/hw/fsi/aspeed_apb2opb.c\nindex 36092468391..058abc86452 100644\n--- a/hw/fsi/aspeed_apb2opb.c\n+++ b/hw/fsi/aspeed_apb2opb.c\n@@ -273,6 +273,7 @@ static void fsi_aspeed_apb2opb_init(Object *o)\n for (i = 0; i < ASPEED_FSI_NUM; i++) {\n object_initialize_child(o, \"fsi-master[*]\", &s->fsi[i],\n TYPE_FSI_MASTER);\n+ qbus_init(&s->opb[i], sizeof(s->opb[i]), TYPE_OP_BUS, DEVICE(s), NULL);\n }\n }\n \n@@ -282,18 +283,6 @@ static void fsi_aspeed_apb2opb_realize(DeviceState *dev, Error **errp)\n AspeedAPB2OPBState *s = ASPEED_APB2OPB(dev);\n int i;\n \n- /*\n- * TODO: The OPBus model initializes the OPB address space in\n- * the .instance_init handler and this is problematic for test\n- * device-introspect-test. To avoid a memory corruption and a QEMU\n- * crash, qbus_init() should be called from realize(). Something to\n- * improve. Possibly, OPBus could also be removed.\n- */\n- for (i = 0; i < ASPEED_FSI_NUM; i++) {\n- qbus_init(&s->opb[i], sizeof(s->opb[i]), TYPE_OP_BUS, DEVICE(s),\n- NULL);\n- }\n-\n sysbus_init_irq(sbd, &s->irq);\n \n memory_region_init_io(&s->iomem, OBJECT(s), &aspeed_apb2opb_ops, s,\n","prefixes":["v2","34/46"]}