{"id":2232361,"url":"http://patchwork.ozlabs.org/api/patches/2232361/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-36-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260504-qom-tests-v2-36-ef7e3dc94f7a@redhat.com>","list_archive_url":null,"date":"2026-05-04T11:35:24","name":"[v2,36/46] hw/arm/aspeed: free fmc_model and spi_model on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2e2546fcd0ed20c6bf6936462f129eb55fb89cc4","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-36-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232361/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232361/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Rff7229Q;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KSB1ypxz1yJV\n\tfor ; Mon, 04 May 2026 21:39:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrdS-00084F-HS; Mon, 04 May 2026 07:38:50 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrdQ-0007p6-OJ\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:48 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrdP-0001KB-7w\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:48 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-gridOgSdM9ahhmp1Rg4obQ-1; Mon,\n 04 May 2026 07:38:45 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 7A59D195609E\n for ; Mon, 4 May 2026 11:38:44 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 1F87F1800480; Mon, 4 May 2026 11:38:42 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894726;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=6GxczfIUezB8LDmHE3u3mH9fTJmiCKopfl79kKH/Kww=;\n b=Rff7229Q+bFglJrSohySWC4XbCWvXFuLNcuy4Be3vMpb3SIsMq+BraOIadTYV7oFK87qjL\n B7I8BFyRUFjsk46IUz/CUY4ifQjFkqYQXfK91aV3ds1tOiM+OY/XsUvHIC8Ezvv6XGVR8Q\n xdYHEwmNOeya1L58Wls/7tXzGTEZcxw=","X-MC-Unique":"gridOgSdM9ahhmp1Rg4obQ-1","X-Mimecast-MFC-AGG-ID":"gridOgSdM9ahhmp1Rg4obQ_1777894724","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:24 +0400","Subject":"[PATCH v2 36/46] hw/arm/aspeed: free fmc_model and spi_model on\n finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-36-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?C=C3=A9dric_Le_Goater?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1366;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=PkTZRbkufOoEKwzeptnlFgLn3nglmLBi5Zuslh0iOS0=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtJxDqxwfr091qv+GTM7qI3HJ3ULK1xpqnJ\n TcJlry/lFqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac\n 5co/D/9AXzA/rYOf0bjnSKTbPvAyqkm9LAH19htqAe/i598peTuTux1ZI33zRMtjnnW8gYmswsV\n fmhycaAg/5PWIqsKpIApvKHz6h11oTWGXmIlE0TYmddYqiQSEmP72+VKihtJuu+wi46022CqQw1\n xGr8kb6eKrwuazz7/LzsAVB621masF8cLOWS82z8OatCxZNjh6i1ShoauShq0OIehJEn3K7Y0Q8\n ziUoXMGRwSBsENHLe3YbFIA702uZsAdTYVtLc4xVUxr6hCIH4pctxJbqyXtpcbgydUtWYlJ6CUZ\n QbThNwRA55t0ePfZkiLQcXCWOqOWFk+7WkPEEvnBai7qzQPWRsmOE9ovXiAIZdN/oMpJZw0JvaB\n b79I/dAxrqeu/uLkXM2G2H/xPZFrv1QbaibtTFeGc0nzY8mi75eDBilA7GVjKMiI2aLbQnqjDsZ\n SGORiEHjGheOUWF8MfrVUfrPJsHON/AWhUulCFlOei7niFErqv3R0tjOaxAVezaTnEPvYHDgJou\n 0BsQ77m90xVIsh5E3htRR15jzWO3uP0wWYcsn59y7dl3PMuQo5/1dKXHWQhwjinMCFUjYWRsvAU\n B5hH5ZdOUuNBhAv3p65ErqosRgxq0l0rnrexFj1ZZdy0eTnGMsONewz1M5I/PycWc663trdi9Dp\n M67IDp5pf8xJYkQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"8","X-Spam_score":"0.8","X-Spam_bar":"/","X-Spam_report":"(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The fmc_model and spi_model strings are allocated via g_strdup in\nproperty setters but never freed when the machine object is destroyed.\n\nFixes: 9820e52fbef7 (\"hw/arm/aspeed: Add machine properties to define the flash models\")\nReviewed-by: Cédric Le Goater \nSigned-off-by: Marc-André Lureau \n---\n hw/arm/aspeed.c | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c\nindex a3db3406c5f..a48c4420583 100644\n--- a/hw/arm/aspeed.c\n+++ b/hw/arm/aspeed.c\n@@ -419,12 +419,21 @@ static void aspeed_machine_class_init(ObjectClass *oc, const void *data)\n aspeed_machine_class_props_init(oc);\n }\n \n+static void aspeed_machine_instance_finalize(Object *obj)\n+{\n+ AspeedMachineState *bmc = ASPEED_MACHINE(obj);\n+\n+ g_free(bmc->fmc_model);\n+ g_free(bmc->spi_model);\n+}\n+\n static const TypeInfo aspeed_machine_types[] = {\n {\n .name = TYPE_ASPEED_MACHINE,\n .parent = TYPE_MACHINE,\n .instance_size = sizeof(AspeedMachineState),\n .instance_init = aspeed_machine_instance_init,\n+ .instance_finalize = aspeed_machine_instance_finalize,\n .class_size = sizeof(AspeedMachineClass),\n .class_init = aspeed_machine_class_init,\n .abstract = true,\n","prefixes":["v2","36/46"]}