{"id":2232358,"url":"http://patchwork.ozlabs.org/api/patches/2232358/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-32-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260504-qom-tests-v2-32-ef7e3dc94f7a@redhat.com>","list_archive_url":null,"date":"2026-05-04T11:35:20","name":"[v2,32/46] hw/tpm: free PPI buffer on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"980be7b22c9a7a53d76ab1d7ee5d7a2b69a0e2b1","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-32-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232358/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232358/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=UqlYLBPa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KRc1jFnz1yJV\n\tfor ; Mon, 04 May 2026 21:39:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrd6-0005fz-Qa; Mon, 04 May 2026 07:38:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrd3-0005Tn-BM\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:25 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrd0-0001E2-NB\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:25 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-63-mANkXZGIMmKkzw6VvpauBQ-1; Mon,\n 04 May 2026 07:38:20 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E6881195606C\n for ; Mon, 4 May 2026 11:38:19 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id EAAEE1800480; Mon, 4 May 2026 11:38:18 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894701;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=UVBuI+EbJBte7cudwIUDMDVUZlvs1SZgaSQuqt1SPTs=;\n b=UqlYLBPabTfy/Eo13lWpxZnaW6zFyaYkXW8GuPVs1oNqaGDVGm+grawwkigINmbiZBvIRc\n F9MKOJs2yJ5T+aShRYD/KPlcOmZzHhLnk7RTCOtsqEzLrTDcOb7BP+xbS8CyzO9tb/ch7S\n y7VSXIL5zAGeqIXJ3pQ/NeeG4FSxdmk=","X-MC-Unique":"mANkXZGIMmKkzw6VvpauBQ-1","X-Mimecast-MFC-AGG-ID":"mANkXZGIMmKkzw6VvpauBQ_1777894700","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:20 +0400","Subject":"[PATCH v2 32/46] hw/tpm: free PPI buffer on finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-32-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1254;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=+gbtJ/99XwN9Q6M5HxsUiEi2wFIXez1EC/KRfHjlUrQ=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtYTmF8+gyP72Dd5S8PuxtBhXsxpTe6eXQ3\n SnGgW4VnyGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac\n 5fAjD/4/BstuHa1Wyv3+WBmBEPEga/Y/nAduf1UrVa4DU6CYB0w4lbNIf3RVmoYX+2bz3uFgvfi\n Gbc5jTMlP6bqujYi64wQ8nZfn4IAfyW0nVHTTFLfajRHChuU14NhAHqghX09UAYK6P2FfI3iyx6\n xlEflvCZJXdcZNde4X+q4FT+S9PGa4MtcWJn6PlBrwcSvGHRhEOWv0GsrJogx9aYUk6/9fKWqZh\n LPNgfy91uu3Al8KcR3YdpWp+66qzDjQJtgXbTIQO3XTiKBCkORa7ADijXjcp3lqDQ6lkiDdwneP\n iUn4znghYJKkaU8Uo8f1YEoGkF6tPqhKpn0bKhvsRza+sCBqK99lxZohBobyzUeXBzeKBdMhWS+\n zipbUKnI96bDoark9hu0WhMXNEDB2APIn2WoH4ht/r+v6ANHVuxp2Rw+ADbtofiVaK4PBZJfXRE\n f6ZRb6H0vPVQrHmdZBJcddFbUizkEYbran8FsmOBNIYIn232P+q1RL7cda/pYwdDMn3cQocRyT3\n H1QZlmTggT1C672gm2bT05kvn3VvdBdK1Vjg+QPqtBuR64imZmCf5j92glexxMZ+aKyId9L6YMp\n lRy2NQywR2x9ycxKcnfgcd9GZPAdpyysv+bqn+hpVgilztKM2VHioXKJ/nSCRfVHqPj0DhH4F8d\n XQjGPfmYAo9GAFA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"8","X-Spam_score":"0.8","X-Spam_bar":"/","X-Spam_report":"(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The PPI buffer is allocated with qemu_memalign() in instance_init but\nnever freed when the device is destroyed.\n\nFixes: 46cd2c1050f0 (\"hw/tpm: add PPI support to tpm-tis-device for ARM64 virt\")\nSigned-off-by: Marc-André Lureau \n---\n hw/tpm/tpm_tis_sysbus.c | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c\nindex 6bec30c36fc..3984228c42f 100644\n--- a/hw/tpm/tpm_tis_sysbus.c\n+++ b/hw/tpm/tpm_tis_sysbus.c\n@@ -150,11 +150,20 @@ static void tpm_tis_sysbus_class_init(ObjectClass *klass, const void *data)\n set_bit(DEVICE_CATEGORY_MISC, dc->categories);\n }\n \n+static void tpm_tis_sysbus_finalize(Object *obj)\n+{\n+ TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(obj);\n+ TPMState *s = &sbdev->state;\n+\n+ qemu_vfree(s->ppi.buf);\n+}\n+\n static const TypeInfo tpm_tis_sysbus_info = {\n .name = TYPE_TPM_TIS_SYSBUS,\n .parent = TYPE_DYNAMIC_SYS_BUS_DEVICE,\n .instance_size = sizeof(TPMStateSysBus),\n .instance_init = tpm_tis_sysbus_initfn,\n+ .instance_init = tpm_tis_sysbus_finalize,\n .class_init = tpm_tis_sysbus_class_init,\n .interfaces = (const InterfaceInfo[]) {\n { TYPE_TPM_IF },\n","prefixes":["v2","32/46"]}