{"id":2232357,"url":"http://patchwork.ozlabs.org/api/patches/2232357/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-28-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260504-qom-tests-v2-28-ef7e3dc94f7a@redhat.com>","list_archive_url":null,"date":"2026-05-04T11:35:16","name":"[v2,28/46] scsi/pr-manager-helper: free path on finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a7a6029abb7fcc6b0da8208fa5dd9afa35e3f72b","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-28-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232357/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232357/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=RRJoRhCQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KRN6j9wz1yKS\n\tfor ; Mon, 04 May 2026 21:38:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrcp-0003bP-Is; Mon, 04 May 2026 07:38:11 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrci-0002oo-Oq\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:05 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrcg-00017T-AH\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:03 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-308-q3q6YFaFPZK3lQODvOpSYQ-1; Mon,\n 04 May 2026 07:37:58 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B5C1E1800366; Mon, 4 May 2026 11:37:57 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 5A83530001A1; Mon, 4 May 2026 11:37:55 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894681;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=OVmQ7IUeUk12NUknieiIH7qn0uIUvETj0FJeOsX0UJY=;\n b=RRJoRhCQ2KFJtS0JlzSajiMdUG+XIrInsYw1PDmCA2D1BOUC+//xDgHEu9GPXrHVPH1f+O\n 5BFE3nagvCDKYOmsV3qdh6CNiTkTrXsscOCmeKeG/mnaPOML35NB8d63mxrhcnPNvyRfLs\n fw46pXSaME95O/QMJcNHhpKMPGtZRvU=","X-MC-Unique":"q3q6YFaFPZK3lQODvOpSYQ-1","X-Mimecast-MFC-AGG-ID":"q3q6YFaFPZK3lQODvOpSYQ_1777894677","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:16 +0400","Subject":"[PATCH v2 28/46] scsi/pr-manager-helper: free path on finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-28-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Peter Maydell ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=822;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=xkwAcgxCLEsSnJnOju9M5/XFWfwI9OD8yYJlkmPakUQ=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtBxrwfx1k+VMOrCEFbSOrmVFzEqHaC10fS\n LwU9SSBhNGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac\n 5UMID/9a1shVChUuSZSMsz7VxZhHohExTsONlnb4EwugLnhkPvTI3LEDgdaGCJIq+HZ2FyTp72K\n 377a+hq+sjJSMgYtEJh7z2TpT/4u/S96KW86lXX0xwZRaQyY6jKCQ7++sDvAUzvxNAPn1rHRa72\n Y+elm1WTGj6fDQLULnMiJMRJJnshngHX2lx//ViIZYAoaEBXHvJOhzM/OlErlvpWpwX6UB3i/G5\n sAHWUQH0cu5UrQe+O5RA+jkl2aS/YuCeIi7495YULFYP+XREnphxupmDjsUR+JtVwdmsCn6Lym4\n SzAxOBV5DzvDciFNNvL3SAilH99Prb8xBHzVPTkx34PAywytZlLe7qPLz83QzGZp7xZjQvkcONM\n Sj3fWF+P1iK1DkSJpBK+sNBWbTsB/cS+HQyGqfN1AGkm8ggAhFq5xHVennHuC8JCJtWSw8DkwAH\n +Qk0VDwn6qQu1f1+WhI2KEL24CEibUIYdcfgZ9503VbAwBrce+i2sTiSAvknK1+RxObVCyDBzx2\n OiRKeRvDB+2+AUI1PXptA/fK/3ciWN3viWrD5dVUI6w35YDSB9QlZb+fmQya737b9+EnKaipzdR\n 6jmKrdV6Mx/DiMMYH1BuDxS6h+wVDPtq46FThU6kLbaXdU4mIRqomkXUXbEhjkXsuRmRNCP80wT\n gsSBbw20hYN1yDg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"set_path allocates path via g_strdup, but\npr_manager_helper_instance_finalize did not free it.\n\nFixes: 9bad2a6b9d0a (\"scsi: add persistent reservation manager using qemu-pr-helper\")\nReviewed-by: Peter Maydell \nSigned-off-by: Marc-André Lureau \n---\n scsi/pr-manager-helper.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c\nindex f6454cd80de..53432e6d606 100644\n--- a/scsi/pr-manager-helper.c\n+++ b/scsi/pr-manager-helper.c\n@@ -284,6 +284,7 @@ static void pr_manager_helper_instance_finalize(Object *obj)\n {\n PRManagerHelper *pr_mgr = PR_MANAGER_HELPER(obj);\n \n+ g_free(pr_mgr->path);\n object_unref(OBJECT(pr_mgr->ioc));\n qemu_mutex_destroy(&pr_mgr->lock);\n }\n","prefixes":["v2","28/46"]}