{"id":2232356,"url":"http://patchwork.ozlabs.org/api/patches/2232356/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-8-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260504-qom-tests-v2-8-ef7e3dc94f7a@redhat.com>","list_archive_url":null,"date":"2026-05-04T11:34:56","name":"[v2,08/46] hw/xlnx_dp: reject NULL 'dpdma' property rather than crash","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fc48efe1722039bca9c0cac95bd53cc98800f01d","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-8-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232356/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232356/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KSDjufmy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KRN2wlMz1yJV\n\tfor ; Mon, 04 May 2026 21:38:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrb6-0007qO-1f; Mon, 04 May 2026 07:36:24 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrao-0007o5-Rr\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:08 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJram-0000tS-Tk\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:05 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-Oh4z6cupP7Wo2GmZbvOeVQ-1; Mon,\n 04 May 2026 07:36:02 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 45B531956095\n for ; Mon, 4 May 2026 11:36:01 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 100861955D84; Mon, 4 May 2026 11:35:59 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894563;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=GpiJsQbA6N4lVaGQnZSXpb0IqEmM+X+KurXrRNwGnJc=;\n b=KSDjufmyX983zfuvcCBkpOjptT0D4M0AczKQx16oOlk8+Dki9wxgSVjbXhbj7BmDXM8nKO\n Jk0RIbKZwFFq0qV2rhsj8yBM4QNw2Qn5Cds7cYbIK0sBL/UV3lTV4AEu4VSPYEpGtK3nQy\n Y+7DbHEr7s9EPgXAqGV7ExxPjCwa6D8=","X-MC-Unique":"Oh4z6cupP7Wo2GmZbvOeVQ-1","X-Mimecast-MFC-AGG-ID":"Oh4z6cupP7Wo2GmZbvOeVQ_1777894561","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:34:56 +0400","Subject":"[PATCH v2 08/46] hw/xlnx_dp: reject NULL 'dpdma' property rather\n than crash","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-8-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=819;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=ust1ZuWfSfSA7Ib1bldNFkkVSryiOB6BQFu7ci9K6O4=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRs3Jb7MzUVjAZgRkGU611y5HPz03rcxztzK\n 2AZkNtYcy2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac\n 5Wy2D/9g9uRtQ/LxB9wNV5i/PjAmI0Sc+zFik27774askZDfN88v58vcudoq+neG5lMt6sfkD1U\n +K2TK7l06ODi4Bl0s2eutAwnG3rO9h5eW3hSiIHxhynPcK7Ew9F6v39Huuy7Mi7yC00YjUX1AuH\n lrtkOcptq+E9arfJ8v9bBS7+6Es8xQ7/zKdh7ybWI0kTu5glGXJLZpJzvfHVb1N15lJ5K0KHLEL\n CgrgomikhRxWFeUWG/G4X6dCe1SPYkbxEPXhAFQ8dE6T50wdxODxLeMZZu9mya3nqkKCTYxFWr4\n RHKZPVEKTcSOMLSWrbvznDbj5B02xJtefPeEgde9UobjS4GngrJr8/EjpXdmP1TnUzLUVqHjVuW\n ghL9/IrYkCSSsfz7C+2Fl8O1S2WQs8cCHT2x2hJU+iWfTpUQbNSpIPICUFL9ahcdg6BOS7B/ZH2\n mIjnDmhR1mAIH0JAzu7r5C6V2GtNsUJPVyHpus8+V6Xha+M4lEzwa5cgaRO5Wk4Oj+fzsr59L2n\n JiHxWTdM5IITjBnfSxlrZQchG7Mh4Kg1we+fjjvkb7AVIt6IM5j3fhjjYh3yhQuqc5LmGlJNt6e\n y491eX8YtJZuglanjF41coPvjfUyomAUSIYOJikKQ2wO/rC0K4fB7r9SuB5e1HMjBrjoScLi0GJ\n 8EyGjdE2cMjAE6A==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"8","X-Spam_score":"0.8","X-Spam_bar":"/","X-Spam_report":"(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The type-checking macros (XLNX_DPDMA(val)) which crash on NULL.\n\nSigned-off-by: Marc-André Lureau \n---\n hw/display/xlnx_dp.c | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c\nindex 50e6ef10984..876cb3d6642 100644\n--- a/hw/display/xlnx_dp.c\n+++ b/hw/display/xlnx_dp.c\n@@ -570,6 +570,12 @@ static void xlnx_dp_set_dpdma(const Object *obj, const char *name, Object *val,\n Error **errp)\n {\n XlnxDPState *s = XLNX_DP(obj);\n+\n+ if (!val) {\n+ error_setg(errp, \"%s cannot be set to NULL\", name);\n+ return;\n+ }\n+\n if (s->console) {\n DisplaySurface *surface = qemu_console_surface(s->console);\n XlnxDPDMAState *dma = XLNX_DPDMA(val);\n","prefixes":["v2","08/46"]}