{"id":2232353,"url":"http://patchwork.ozlabs.org/api/patches/2232353/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-33-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260504-qom-tests-v2-33-ef7e3dc94f7a@redhat.com>","list_archive_url":null,"date":"2026-05-04T11:35:21","name":"[v2,33/46] hw/fsi: move OPBus address space init to realize","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5f6777af7c2c68d81302d8dbb7efcb3ca5d68b61","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-33-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232353/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232353/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=MXbgAK35;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KRB5T1xz1yJV\n\tfor ; Mon, 04 May 2026 21:38:46 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrdB-0006Bf-Ta; Mon, 04 May 2026 07:38:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrd8-0005wv-6d\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:30 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrd6-0001Hr-J1\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:29 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-OiiLnOkQOAqJYO9hq9Jasw-1; Mon,\n 04 May 2026 07:38:26 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id DFD4F19560B5\n for ; Mon, 4 May 2026 11:38:25 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 18B1F1955D84; Mon, 4 May 2026 11:38:23 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894707;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9uhmtc7dYjQMN1jMZa6kxMNc/KRWfHf/T/TyMWiJ680=;\n b=MXbgAK35imNkJpE2eg/t6l8Ue5e/ZA7EzrpyoYosBLF7DDeSyIrESJhIRvE9VQ1ElNMZcf\n rqfIDGA70ChhB2hfdIaVqPzHT5ljSvzJ7XJWQ5TOLCO4g95wzhn4bWxDk+XA9yqbOIR4j6\n NSWaeBdJOHhhinxhk0e5SNo6H28uZz0=","X-MC-Unique":"OiiLnOkQOAqJYO9hq9Jasw-1","X-Mimecast-MFC-AGG-ID":"OiiLnOkQOAqJYO9hq9Jasw_1777894706","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:21 +0400","Subject":"[PATCH v2 33/46] hw/fsi: move OPBus address space init to realize","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-33-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2041;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=KILJnJhSBQUK/Muq0oJYoyL0XcLZf7mKortd6mZZUGU=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtkHwrDnUZIC+S8Ez13lnmT8rBpw5EvgQr5\n /BfpM/ui5+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac\n 5V24D/9UPKuMHvfCzcumfKeS063iVTHyhYb+539Vpig5f4Xp18Gk/cr7lAmMnfkeQ66xvsYfRZk\n iKZFEEIePAmQrG8LBmG/G9tUaKuPL1aFRdGKKLP45XUaHmecI9LRmE71jZuNf24YfH7C0Y8MN6K\n Cajm+UoUMOTswAVKPNZLvWVmgRBVgFd6PgFPdtzhWAxtJpGLyKKGo9KxSVYCQmdIPgml8jE1lhL\n hVgPFydheMT+iQUT261nY3osxemGUnp21EGE5wwTZczFgzR++P+NGJupvroIQdOZwVuVDmyp7L8\n qYDVCkdogbNje4GvoodbliYMYe5mBoiVZZlJHLa5TwIgEAVJslk7mUc91OWDtbSYpYW+L3w2hTg\n rIYEOvENz5X55fQtCPwxcB6rTdLQzii5UYXKJ0FtkhdHLpLr+WtoYgjxPlT0x9rRTossPSeZR/G\n XDTB2xfM/vP3XR+BYbhmQ6ZfkBw9rjb7yfGch3lUgGezNJb3Oj5dC3iqsPYBIcoCloV1+6zE/Vs\n oIhY5srXSVNjhPiVZNfrclwC2MrJS9QyslklOtARpvGYWJCqS96cbfVJR1EyHqGGaZjUqvVWMsg\n sK1LdtFBKHT6duhsHvbQY7kr83XVoXaf7y1JUVhjzpI+n6W17xsyZgrZD0KBlrj87E/T1MVR7Df\n XjsicoeWiiYMUnw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"8","X-Spam_score":"0.8","X-Spam_bar":"/","X-Spam_report":"(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The OPBus instance_init initializes an AddressSpace, registering it in\nthe global address_spaces list. When a bare OPBus object is created\nand destroyed (e.g. by qom-tests), there is no finalize to remove the\nstale entry, leading to a heap-use-after-free when a subsequent\nflatviews_reset iterates the list.\n\nMove address_space_init to the bus realize callback and add the\ncorresponding address_space_destroy in unrealize, following the\nNubusBus pattern. Also fix the memory_region_init owner from NULL to\nthe OPBus object, so the MR is properly parented instead of dangling\nunder the \"unattached\" container.\n\nFixes: eb04c35da2c0 (\"hw/fsi: Aspeed APB2OPB & On-chip peripheral bus\")\nSigned-off-by: Marc-André Lureau \n---\n hw/fsi/aspeed_apb2opb.c | 24 +++++++++++++++++++++++-\n 1 file changed, 23 insertions(+), 1 deletion(-)","diff":"diff --git a/hw/fsi/aspeed_apb2opb.c b/hw/fsi/aspeed_apb2opb.c\nindex b9d72f3ecf6..36092468391 100644\n--- a/hw/fsi/aspeed_apb2opb.c\n+++ b/hw/fsi/aspeed_apb2opb.c\n@@ -348,15 +348,37 @@ static void fsi_opb_init(Object *o)\n {\n OPBus *opb = OP_BUS(o);\n \n- memory_region_init(&opb->mr, 0, TYPE_FSI_OPB, UINT32_MAX);\n+ memory_region_init(&opb->mr, o, TYPE_FSI_OPB, UINT32_MAX);\n+}\n+\n+static void fsi_opb_realize(BusState *bus, Error **errp)\n+{\n+ OPBus *opb = OP_BUS(bus);\n+\n address_space_init(&opb->as, &opb->mr, TYPE_FSI_OPB);\n }\n \n+static void fsi_opb_unrealize(BusState *bus)\n+{\n+ OPBus *opb = OP_BUS(bus);\n+\n+ address_space_destroy(&opb->as);\n+}\n+\n+static void fsi_opb_class_init(ObjectClass *klass, const void *data)\n+{\n+ BusClass *bc = BUS_CLASS(klass);\n+\n+ bc->realize = fsi_opb_realize;\n+ bc->unrealize = fsi_opb_unrealize;\n+}\n+\n static const TypeInfo opb_info = {\n .name = TYPE_OP_BUS,\n .parent = TYPE_BUS,\n .instance_init = fsi_opb_init,\n .instance_size = sizeof(OPBus),\n+ .class_init = fsi_opb_class_init,\n };\n \n static void fsi_opb_register_types(void)\n","prefixes":["v2","33/46"]}