{"id":2232348,"url":"http://patchwork.ozlabs.org/api/patches/2232348/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-22-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260504-qom-tests-v2-22-ef7e3dc94f7a@redhat.com>","list_archive_url":null,"date":"2026-05-04T11:35:10","name":"[v2,22/46] ui/console-vc: destroy fifo on text console finalization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"81b947fd19a4ecf505adaca074548ef6f13bc859","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-22-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232348/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232348/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QddjaYdB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KQt3nwGz1yKS\n\tfor ; Mon, 04 May 2026 21:38:30 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrcY-00027D-NB; Mon, 04 May 2026 07:37:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrc4-0001Ji-8W\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:25 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrc2-00013o-Un\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:23 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-lqtieBFCNfCZajFnBsL6Sw-1; Mon,\n 04 May 2026 07:37:20 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 171C31956089\n for ; Mon, 4 May 2026 11:37:20 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id ADF9919560B6; Mon, 4 May 2026 11:37:18 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894642;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=wuKJe960C3JZZMX2EjW66DJfgAaebcTF8mCh47fG1f4=;\n b=QddjaYdBS/bR77PWO/IPkc6JKLgxWB9h4imhVY//FkwG0mm0dBU4P3jK1HC6sKSG2YbxtD\n tcu+M5ISufpGhOt3tjf2V/xuiFmh1Y7oBPrBltctmfhKgTKIvPD0FoydonAzYUpNNflt9p\n aWgQuDgj1Hcj3LO7WKHxJdOzwMyWuQY=","X-MC-Unique":"lqtieBFCNfCZajFnBsL6Sw-1","X-Mimecast-MFC-AGG-ID":"lqtieBFCNfCZajFnBsL6Sw_1777894640","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:10 +0400","Subject":"[PATCH v2 22/46] ui/console-vc: destroy fifo on text console\n finalization","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-22-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=699;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=bgNRmMvCBvL1ntBm5XZWmDb8LVMsoFnZArE91z4s6o4=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtO7phVAlWYpF4TCjtZwfAj939qgYKLygx7\n 0vCCgovMPKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac\n 5Y+mD/9Jm+KqyGh4+ef084LUueX7ikGFIUeql7wCvxbqmnZPcphitttwTcblon50pO3P+FdthrP\n dsUamZW79QeHmLkb/q06s6FbKLdRIY2HmrF94aHwb7ZaFQkJuQBJ4bRAMSn3V7DJ+ChpU8Giv7J\n E1dj0mlXwm+JPBbdI5gVbwwRBt16qtdj51mhGrJNTq+jwXjkLmf77CjLMgEMNKbMn0FdL8ZjO70\n tiUR6TzNmMGErjYLJT2+Et+Ii3DxT337dCOX0E+BMAWDBwtGJdJFHkBFzl22Y6uVWs9N6iMSI49\n AAPhtip4AB4yAOGmUHQcURrTlHJQ0bhyA82JYiNyArOONVKkzsRYQsnQoRldataXDkFSo2HHH/h\n ZRMNTMNO5fS4yc5TcSFcX4IDHx5J/sOdVkuFybL6hLzOdK+Sf/1RjYqoZ2Y9+k6qrK0Z2PSNtqD\n DLbA6dzv5WSilW5Re4HqxC/VZXiV8Q1nBckAqWpSxdONXFG73rgYBG5kauzl8AWpOGKqSM0E8gp\n VV3hA2IDPL1KXlpmPoT8Nf5GW26o7IfeWgCuc6cqr/nxZwdyeOgYT0mF4VKUqtSm1SPwIwUl1yG\n +HuI2sQP8OK/XUKkdi0qf1JRGUziTX4WGNKJL6Xf5RwmuZSCxzsPZqqyr/8oGSkw6rEUauV3u1d\n go8H4i2oFoN09XA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"8","X-Spam_score":"0.8","X-Spam_bar":"/","X-Spam_report":"(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"qemu_text_console_init creates a fifo8 via fifo8_create, but\nqemu_text_console_finalize never called fifo8_destroy, leaking the\nunderlying buffer.\n\nFixes: 0c9d0641ac (\"ui/console: replace QEMUFIFO with Fifo8\")\nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 6163e21d2c6..3e00d2588c3 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -1082,6 +1082,7 @@ qemu_text_console_finalize(Object *obj)\n {\n QemuTextConsole *s = QEMU_TEXT_CONSOLE(obj);\n \n+ fifo8_destroy(&s->out_fifo);\n QTAILQ_REMOVE(&vt100s, &s->vt, list);\n }\n \n","prefixes":["v2","22/46"]}