{"id":2232343,"url":"http://patchwork.ozlabs.org/api/patches/2232343/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-13-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260504-qom-tests-v2-13-ef7e3dc94f7a@redhat.com>","list_archive_url":null,"date":"2026-05-04T11:35:01","name":"[v2,13/46] io/net-listener: move mutex init to instance_init","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3e453b8bcccd8432627bfd0e3958169bbce897f8","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-13-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232343/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232343/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KQSlUy0d;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KQd5RtGz1yKW\n\tfor ; Mon, 04 May 2026 21:38:17 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJrba-0000KT-O7; Mon, 04 May 2026 07:36:55 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrbF-0008NG-GE\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:34 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJrbE-0000w8-2E\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:33 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-577-4uwF6CMcMQ67mA6abelspg-1; Mon,\n 04 May 2026 07:36:29 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id D8C021956094\n for ; Mon, 4 May 2026 11:36:28 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id ACF621800480; Mon, 4 May 2026 11:36:26 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894591;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=hawV2zHhsLP3IpBpGcaKS5nofkenBW3wvzF/cqta4OE=;\n b=KQSlUy0dVQunrN5cd3nIeC3qb+awXH2+DxLYSvL0F0fppOY+l9Vvu8eg6bfxOGkMWJZDCD\n N1/NzTuq9YVToreQnXdKiZaAy1KlGxqDJrjcZeTTStd09PXL07Tey0xGe9lsAthu5vnyx7\n 5Z5FDA6HPcMG6JyoXuurPQYX/HHozYE=","X-MC-Unique":"4uwF6CMcMQ67mA6abelspg-1","X-Mimecast-MFC-AGG-ID":"4uwF6CMcMQ67mA6abelspg_1777894589","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:35:01 +0400","Subject":"[PATCH v2 13/46] io/net-listener: move mutex init to instance_init","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-13-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n peterx@redhat.com,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ,\n Peter Xu ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2097;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=FO0JbNzdhqKOcr/H+UXjPEtyLHouJa/+KfqAHcSin8A=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsXDsGstuJZzUMHFI049qftwUp6PKECYBUG\n W8ebphBuiWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac\n 5b90D/9igcAOdVBdS2aP/I9NuJ8WCrcCQrf6jeu2mZSQyRH9OYAutk2uhdrvAhhL/Ga5p/vt1ut\n XxmzmVvN+jLZcD68rn5o7z8/KwdpJwOSuVxlPKrt1kpIE4hLW2a3V4SSy4sBC4DtNZGiT8MUiF/\n 1ozq4f1vWu079roA0g4CMxdEBuJy8vJ9v1X14m052sCmrV6y4iDV7jN0W8UNrGcYMmtuZRWLCGe\n WWDfgTQ9BkAvhFo5zQcZOgSMJvYg+u3vQcVATkcRQvqFMriHLoWxzmxuktICHyaxKdEltL7maYy\n p9foo2Gnmnkb6MfHxzICON4zhErf/9cUfW6BsD5fsgnOwKQMdGhgpW/ror+uAyWJcY3OU7kO4Zk\n hNbOS5N3JdWNp7NnmVX4n1bD+gaz/aAHR46Owbm/74JAtwbKVsOxZAGOO+tbELSSMUT05NwEMuD\n UsOICv3/qkO8S+BvNyTefJ9ep2+OA+e5bvVs5plm/v8wvXd1Rs0f6JjvtLykReUV88Norl8AFIY\n ACeZHrUlXLdbYwSny0Q6WAwg6vWqdZ2SsUnF5CqO3x5EVTOLAIB+I0kEdJj/wFzR5vWcWgv8ZvG\n 6p/IcklxZjf4pxp0LHsabkv6uOwnu+dKyHSqDqkBwz2XVncU8SyXAYGZqotPPzAhpO0i39DById\n 7QZb5quy+yCQ/8A==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"8","X-Spam_score":"0.8","X-Spam_bar":"/","X-Spam_report":"(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The QIONetListener mutex is initialized in the convenience\nconstructor qio_net_listener_new() rather than in an instance_init.\nThis means a bare object_new(TYPE_QIO_NET_LISTENER) produces an\nobject with an uninitialized mutex, but instance_finalize\nunconditionally calls qemu_mutex_destroy() on it, which aborts.\n\nMove the mutex initialization to a proper instance_init so that init\nand finalize are always paired regardless of how the object is\ncreated.\n\nThis patch is just added for completeness, but \"qio: Fix\nqom-list-properties crash on net listener object\" from Peter Xu is\nbasically the same.\n\nFixes: 9d86181874a (\"qio: Protect NetListener callback with mutex\")\nCc: peterx@redhat.com\nReviewed-by: Daniel P. Berrangé \nReviewed-by: Peter Xu \nSigned-off-by: Marc-André Lureau \n---\n io/net-listener.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/io/net-listener.c b/io/net-listener.c\nindex 9410d72da9c..1fd0f6cb5ab 100644\n--- a/io/net-listener.c\n+++ b/io/net-listener.c\n@@ -38,7 +38,6 @@ QIONetListener *qio_net_listener_new(void)\n QIONetListener *listener;\n \n listener = QIO_NET_LISTENER(object_new(TYPE_QIO_NET_LISTENER));\n- qemu_mutex_init(&listener->lock);\n return listener;\n }\n \n@@ -440,6 +439,13 @@ qio_net_listener_get_local_address(QIONetListener *listener, size_t n,\n return qio_channel_socket_get_local_address(sioc, errp);\n }\n \n+static void qio_net_listener_instance_init(Object *obj)\n+{\n+ QIONetListener *listener = QIO_NET_LISTENER(obj);\n+\n+ qemu_mutex_init(&listener->lock);\n+}\n+\n static void qio_net_listener_finalize(Object *obj)\n {\n QIONetListener *listener = QIO_NET_LISTENER(obj);\n@@ -463,6 +469,7 @@ static const TypeInfo qio_net_listener_info = {\n .parent = TYPE_OBJECT,\n .name = TYPE_QIO_NET_LISTENER,\n .instance_size = sizeof(QIONetListener),\n+ .instance_init = qio_net_listener_instance_init,\n .instance_finalize = qio_net_listener_finalize,\n };\n \n","prefixes":["v2","13/46"]}