{"id":2232326,"url":"http://patchwork.ozlabs.org/api/patches/2232326/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-1-ef7e3dc94f7a@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260504-qom-tests-v2-1-ef7e3dc94f7a@redhat.com>","list_archive_url":null,"date":"2026-05-04T11:34:49","name":"[v2,01/46] hw/pci: handle missing bus in prop_pci_busnr_get","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5dd5240ac140b420e9513f68b767c6576a9cc123","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-1-ef7e3dc94f7a@redhat.com/mbox/","series":[{"id":502649,"url":"http://patchwork.ozlabs.org/api/series/502649/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649","date":"2026-05-04T11:34:48","name":"Fix various QOM object life-cycle issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502649/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232326/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232326/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cuPyDpwq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KN33P4Fz1yKS\n\tfor ; Mon, 04 May 2026 21:36:01 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJraC-0007Uq-FP; Mon, 04 May 2026 07:35:28 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJraA-0007UL-IJ\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:26 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJra8-0000m5-S8\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:26 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-xRcAc9CBOECCGvfAeZKgsg-1; Mon,\n 04 May 2026 07:35:22 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 77640195608B\n for ; Mon, 4 May 2026 11:35:21 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 77CF71800347; Mon, 4 May 2026 11:35:20 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894523;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=3LnmPj2a/SZ2VXKAkFID+9JaaVLfJOAgO0sBcWpZJog=;\n b=cuPyDpwqJBMWit5zpLWWebI6c2gcTL6jHuMknwwRgT3qkuXW7t4VnKGIKsHgRwJ3X4+eMo\n HV3Ft7aO5jZ0QMPic0vJfvqn5qb0E9nzN4vgLd317GHoDF3E4MTXLUy/ORWVQCgMuxcTXw\n mL9FV9pa6NrQBAQwUAL90ld4NjoxqWI=","X-MC-Unique":"xRcAc9CBOECCGvfAeZKgsg-1","X-Mimecast-MFC-AGG-ID":"xRcAc9CBOECCGvfAeZKgsg_1777894521","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 04 May 2026 15:34:49 +0400","Subject":"[PATCH v2 01/46] hw/pci: handle missing bus in prop_pci_busnr_get","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260504-qom-tests-v2-1-ef7e3dc94f7a@redhat.com>","References":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","In-Reply-To":"<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1270;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=TNcMmHQOk/Cv/pMBfbzxmrySqL4hQAd92bEHD4UL6Q0=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRr//8ubAy8v2Oj1r0e7dXjo+CRyChMgnZ/0\n A1+EgTV1nSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEawAKCRDa6OEJdZac\n 5VcCD/9gGFYwE91xP9RdLb6fSOV65ujihzeQ0i1npwXmXc86tDhxFSXcMa/JNFrvBB43HbpHmZW\n ulj5WQFBerU7dJ9bx4kMNrz658dLKsIVOz96CF4vzBY35J5q0PukFG5FpeJEnPcclsNn3+ty47t\n YjIGnhx1liyTj8+p6rldYalAFC1FOM6Z52QKcopN1XNQe+Rdc7juxh/Nz7RLCzUwMg/9taof+/9\n 8Idmx0lPzuoh1l4D3IqB0LN1fm8ar450dDKJZz9PQcolWMHq+YZOk8/qG+COOvcD8bz2WgyjUsU\n YNwkfJ9rJYhfZwPi5eQR8KeCpX5nMSlASvciFtdc0HuaWZQw8yuL1sMDt/D1r/YBeJ+SqX4CVya\n Qlm2Bj/ccmmgT1eJMFUkVC1viBYz9R57r3+OkTjZAbROEoibo91BgS04j+69YPjXeGffH2UPkW6\n 0zvqR8JtABLSQOU9jU5A03ceQfx09ab3Rm3mlzUiIPbK7rxm1R2G19GYfjxRUZjtssq3NdEozVn\n syYGoahObkk7Cw/CDEgS6xNUHyGr68HKwR5jK4BkEBePAc//ZX2apFhfcLXjAjZ2nnE1XCiT52c\n BGdck9m9qGr4TzHUxQCn61OShf6UUJN/DQAscQXCsgbPC7bUN4wyvUvZV4IPP96xXO/3rIBlj+E\n pegFo4nZSU8x6TQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"8","X-Spam_score":"0.8","X-Spam_bar":"/","X-Spam_report":"(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When called on an unrealized device (e.g. from\nqmp_qom_list_properties), pci_get_bus() returns NULL since the device\nhas no parent bus. Check for this to avoid a NULL dereference in\npci_bus_num().\n\nFixes: df9ac7254fd9 (\"hw/pci: Add a busnr property to pci_props and use for acpi/gi\")\nSigned-off-by: Marc-André Lureau \n---\n hw/pci/pci.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/pci/pci.c b/hw/pci/pci.c\nindex a0dbb81fd90..bf13cabd174 100644\n--- a/hw/pci/pci.c\n+++ b/hw/pci/pci.c\n@@ -64,10 +64,17 @@ static void pcibus_reset_hold(Object *obj, ResetType type);\n static bool pcie_has_upstream_port(PCIDevice *dev);\n \n static void prop_pci_busnr_get(Object *obj, Visitor *v, const char *name,\n- void *opaque, Error **errp)\n+ void *opaque, Error **errp)\n {\n- uint8_t busnr = pci_dev_bus_num(PCI_DEVICE(obj));\n+ PCIDevice *dev = PCI_DEVICE(obj);\n+ PCIBus *bus = pci_get_bus(dev);\n+ uint8_t busnr;\n \n+ if (!bus) {\n+ error_setg(errp, \"device not attached to a PCI bus\");\n+ return;\n+ }\n+ busnr = pci_bus_num(bus);\n visit_type_uint8(v, name, &busnr, errp);\n }\n \n","prefixes":["v2","01/46"]}