{"id":2232269,"url":"http://patchwork.ozlabs.org/api/patches/2232269/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260504075036.12190-2-zxl434815272@gmail.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260504075036.12190-2-zxl434815272@gmail.com>","list_archive_url":null,"date":"2026-05-04T07:50:35","name":"[v2,2/3] tools: gpio: validate arguments in gpiotools_request_line","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"36c3c9eaabe4b7e0ba5f1e72288c06204ee2eec7","submitter":{"id":93314,"url":"http://patchwork.ozlabs.org/api/people/93314/?format=json","name":"Zhang Xiaolei","email":"zxl434815272@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260504075036.12190-2-zxl434815272@gmail.com/mbox/","series":[{"id":502584,"url":"http://patchwork.ozlabs.org/api/series/502584/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=502584","date":"2026-05-03T19:00:16","name":"tools: gpio: fix buffer overflow and add bounds check","version":1,"mbox":"http://patchwork.ozlabs.org/series/502584/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232269/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232269/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=E29aocr2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-36021-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"E29aocr2\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.178","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8DVL50Fhz1yJV\n\tfor ; Mon, 04 May 2026 17:56:10 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 94D5C301469A\n\tfor ; Mon, 4 May 2026 07:55:53 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 469BD2D7DCE;\n\tMon, 4 May 2026 07:55:52 +0000 (UTC)","from mail-pl1-f178.google.com (mail-pl1-f178.google.com\n [209.85.214.178])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FADC30595C\n\tfor ; Mon, 4 May 2026 07:55:48 +0000 (UTC)","by mail-pl1-f178.google.com with SMTP id\n d9443c01a7336-2b788a98557so31809995ad.2\n for ;\n Mon, 04 May 2026 00:55:48 -0700 (PDT)","from 007.. ([59.66.153.14])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b9cae0f67esm99898255ad.51.2026.05.04.00.55.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 04 May 2026 00:55:47 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777881352; cv=none;\n b=SkwSlgUDxTqxS4P1UxcjtZvl+vF9b+8VdbKHfgdov0+ZFOFQf3R0IAvpoGtTAjpC52EQX+1Bwz8tdskbWmUBzw5/8T90q362ICb3+UzxZEQFR7padq2ewQF/17CDEhfRAQ2OAZqHKO38sLd+1fFRFOvKm8kmqoAmr+y/9JzPvc4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777881352; c=relaxed/simple;\n\tbh=dCVQgRHFcTbGgiHoD6wqZ1Z8fhCxT95GCkwijb1fhMM=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=W975JYw+HYfuex3eKsb1p/tA+VITFJkCrpQduI83Tm0cWpjfxgDDcocHe2ge0U7RSLngse3FxPBbymVRO3VeL3A6kqooDSa4oOYOFsrmOSia1SiR6TwPDqXQWRsah2KHxc5jIiuviC0pIDfE58dRnzPeMnDqEmUmaZRnlIMhtiQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=E29aocr2; arc=none smtp.client-ip=209.85.214.178","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777881348; x=1778486148;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=tOkfISWp3zKt6MhbV91AmgDxPSReCWlbub1B9xCSCNk=;\n b=E29aocr2ROCduS3yzEtABYNhf1szJET1LmVNrElFMyiz336vWfzDk5KsOwT5TgGby+\n IWhk9xB1KjiS7JizjWvcfZQUbcymJsOGkouMa6iSEaWVeJfVo8a+N5+utleus3jDMj4p\n Nadd+U167aZoNzaBeXf3CopJYbvnDRmjOjkZvOsIBB3/6FstbCHB7uW9gBHW+ofOShms\n a0p4jqARrhcSeReAtn8pW9RrZga3pxnSb88g8ZZoojYYjtFZq1dXk4UIDh14EiNswMzc\n v5PiGUQ1zlG+QAKGWZwwiZXk9g08Pu0XzgGsLurqA62VyEqR8+sgHhnNOtE8QBumlD+X\n eLJA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777881348; x=1778486148;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=tOkfISWp3zKt6MhbV91AmgDxPSReCWlbub1B9xCSCNk=;\n b=V97muXnH7Sw3JlX3GFQUs3uWb/8ZAHEFhwLsfJHgSnJKlCZvwpAbdzQpSX4kn5BWRE\n Vth9NHwPovtSuQEgzXonZevhAW/NZOCULpCI2cbWrCCJaYbFKt1DIIahHQ3slwm+oWq0\n uX8ueiS5vCZcFuf73zeu2UBgexYgJexIvcUVA5WsUQgRdtkDDWfseC0YjzPOpQ8U43TK\n wS+oO+ecEOK5Z3WE9GxIPit7uRH/ldrmxJTvez+D5v0IKySqDK9NPa2U0MWz4PCtZK/d\n H6vmryxdq1cGzS5DVv5cJV7512lgVmSRQ7pGdanjA21XUmr5oq52vs/PTHn2RL4cBtVV\n KuAw==","X-Gm-Message-State":"AOJu0Yx5eU7rmfO+J3Zp98LScfhrZkqfR4gMIVVbj9cBW8N1PsY4VH2z\n\tgvW/9/WdSsH8sSV+1fwBOkjm30dtgiXSAPRZk2IK3RJfQgBTESNDlTX0QqRfdA==","X-Gm-Gg":"AeBDietes5NC+mSaXe3ALYKbnGJwq31HpfTTOtbr4iN3pCvEssj/kndm4Bljaoz+GM2\n\tmlIWtzDBHGlATn0P081nDl9FkTnPJozNnchm+HAaZWYTbIBlq5qE1DGgdTceK4EM7Ac39Kkcm/A\n\tUap8sgdo/ZL4V1732Ij8hXqq4gVgn7azV+kiWCFQ8aBmbekJH9vrtHru4CnvyXUPMc7/maOzIr9\n\tGFmO0cGvvulXJIWPepnFk63URZRwbdwwJVqgHYy94urwFbGaDgHbM6zDXCGugcb9jLtzmg7W2zS\n\ttDAl4CufEofj+rowsomvCYtLdlR5PESLGe+V70lPRLV+Uwo0BpQD632ss1hyKtpmQNNo0ZMtTus\n\tzie0IOQL/yMuxeyJo1ugoc2MbRJvk8sZFUb/lEmN3NAspFeU6WLO9t45t0aEd10Qx1c/BYwKmij\n\t/bF6qPhlr8FYvOl0oI6p19LX/gnQ==","X-Received":"by 2002:a17:903:3887:b0:2b4:6022:bf8c with SMTP id\n d9443c01a7336-2b9f260b140mr83710155ad.22.1777881347662;\n Mon, 04 May 2026 00:55:47 -0700 (PDT)","From":"Zhang Xiaolei ","To":"linux-gpio@vger.kernel.org","Cc":"brgl@kernel.org,\n\twarthog618@gmail.com,\n\tlinux-kernel@vger.kernel.org,\n\tZhang Xiaolei ","Subject":"[PATCH v2 2/3] tools: gpio: validate arguments in\n gpiotools_request_line","Date":"Mon, 4 May 2026 15:50:35 +0800","Message-Id":"<20260504075036.12190-2-zxl434815272@gmail.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260504075036.12190-1-zxl434815272@gmail.com>","References":"<20260503190016.13439-1-zxl434815272@gmail.com>\n <20260504075036.12190-1-zxl434815272@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Add validation for input pointers and number of lines.\n\nSigned-off-by: Zhang Xiaolei \n---\n tools/gpio/gpio-utils.c | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/tools/gpio/gpio-utils.c b/tools/gpio/gpio-utils.c\nindex 176bccfcccb0..930a38fe7911 100644\n--- a/tools/gpio/gpio-utils.c\n+++ b/tools/gpio/gpio-utils.c\n@@ -65,6 +65,12 @@ int gpiotools_request_line(const char *device_name, unsigned int *lines,\n \tint i;\n \tint ret;\n \n+\tif (!device_name || !lines || !config || !consumer || !num_lines)\n+\t\treturn -EINVAL;\n+\n+\tif (num_lines > GPIO_V2_LINES_MAX)\n+\t\treturn -EINVAL;\n+\n \tret = asprintf(&chrdev_name, \"/dev/%s\", device_name);\n \tif (ret < 0)\n \t\treturn -ENOMEM;\n","prefixes":["v2","2/3"]}