{"id":2232150,"url":"http://patchwork.ozlabs.org/api/patches/2232150/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260503070939.2730826-1-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260503070939.2730826-1-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2026-05-03T07:09:39","name":"ui/input: do not assert() when tracing invalid input","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"98cae4148b6063e167a847617a6d740538e63953","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260503070939.2730826-1-marcandre.lureau@redhat.com/mbox/","series":[{"id":502567,"url":"http://patchwork.ozlabs.org/api/series/502567/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502567","date":"2026-05-03T07:09:39","name":"ui/input: do not assert() when tracing invalid input","version":1,"mbox":"http://patchwork.ozlabs.org/series/502567/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232150/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232150/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KPHohrbp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g7bXM6rM1z1yJ0\n\tfor ; Sun, 03 May 2026 17:10:42 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wJQxi-0005ee-2N; Sun, 03 May 2026 03:09:58 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJQxf-0005eW-Su\n for qemu-devel@nongnu.org; Sun, 03 May 2026 03:09:55 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wJQxe-0002BO-3I\n for qemu-devel@nongnu.org; Sun, 03 May 2026 03:09:55 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-AkUG29rgNby310tzq_M3Nw-1; Sun,\n 03 May 2026 03:09:48 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id EB0E51800473\n for ; Sun, 3 May 2026 07:09:47 +0000 (UTC)","from localhost (unknown [10.44.24.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id BEE9619560A6; Sun, 3 May 2026 07:09:46 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777792190;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=dWdls0qxO24t0lHRZtq5+1onptUNMWa3UAZJKRMBIhc=;\n b=KPHohrbp6cdKXTvXA2qB9AASihnt9QMdLQsRMMrbbGZXf1gqX6p7VeMwBAHJyYbrs1POK+\n FoAKnKHtqliwuqQdXl7VHz8ERSSTxWZe+pj14UK2L9OCZGjOD704D0Pjjud/v0flkA4f3e\n NveW90xgq6IkL66wv6UBiABgooKGVmU=","X-MC-Unique":"AkUG29rgNby310tzq_M3Nw-1","X-Mimecast-MFC-AGG-ID":"AkUG29rgNby310tzq_M3Nw_1777792188","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Subject":"[PATCH] ui/input: do not assert() when tracing invalid input","Date":"Sun, 3 May 2026 11:09:39 +0400","Message-ID":"<20260503070939.2730826-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Marc-André Lureau \n\nIt's possible to reach an assert() in the input tracing code by sending\nsome out of range input values via D-Bus for ex:\n\n #0 0x00007fec8652186c in __pthread_kill_implementation () at /lib64/libc.so.6\n #1 0x00007fec864c648e in raise () at /lib64/libc.so.6\n #2 0x00007fec864ad7b3 in abort () at /lib64/libc.so.6\n #3 0x00007fec864ae804 in __libc_message_impl.cold () at /lib64/libc.so.6\n #4 0x00007fec864be345 in __assert_fail () at /lib64/libc.so.6\n #5 0x00005597964c551e in qapi_enum_lookup[cold] ()\n #6 0x000055979650514a in qemu_input_event_send_impl ()\n #7 0x0000559796505a4d in qemu_input_queue_btn ()\n #8 0x00007fec85780c19 in dbus_mouse_press () at /usr/bin/../lib64/qemu/ui-dbus.so\n #9 0x00007fec857912fc in _g_dbus_codegen_marshal_BOOLEAN__OBJECT_UINT.part.0 () at /usr/bin/../lib64/qemu/ui-dbus.so\n #10 0x00007fec874cce7c in g_closure_invoke () at /lib64/libgobject-2.0.so.0\n #11 0x00007fec874eb849 in signal_emit_unlocked_R.isra.0 () at /lib64/libgobject-2.0.so.0\n #12 0x00007fec874ec66f in g_signal_emitv () at /lib64/libgobject-2.0.so.0\n #13 0x00007fec85797e0a in _qemu_dbus_display1_mouse_skeleton_handle_method_call () at /usr/bin/../lib64/qemu/ui-dbus.so\n\nOther paths in input code accept out-of-range values\n(qemu_input_key_value_to_number etc). Let it pass tracing.\n\nSigned-off-by: Marc-André Lureau \n---\n ui/input.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/ui/input.c b/ui/input.c\nindex 57e7817878a..966023d4f4d 100644\n--- a/ui/input.c\n+++ b/ui/input.c\n@@ -207,22 +207,22 @@ static void qemu_input_event_trace(QemuConsole *src, InputEvent *evt)\n break;\n case INPUT_EVENT_KIND_BTN:\n btn = evt->u.btn.data;\n- name = InputButton_str(btn->button);\n+ name = btn->button < INPUT_BUTTON__MAX ? InputButton_str(btn->button) : \"invalid\";\n trace_input_event_btn(idx, name, btn->down);\n break;\n case INPUT_EVENT_KIND_REL:\n move = evt->u.rel.data;\n- name = InputAxis_str(move->axis);\n+ name = move->axis < INPUT_AXIS__MAX ? InputAxis_str(move->axis) : \"invalid\";\n trace_input_event_rel(idx, name, move->value);\n break;\n case INPUT_EVENT_KIND_ABS:\n move = evt->u.abs.data;\n- name = InputAxis_str(move->axis);\n+ name = move->axis < INPUT_AXIS__MAX ? InputAxis_str(move->axis) : \"invalid\";\n trace_input_event_abs(idx, name, move->value);\n break;\n case INPUT_EVENT_KIND_MTT:\n mtt = evt->u.mtt.data;\n- name = InputAxis_str(mtt->axis);\n+ name = mtt->axis < INPUT_AXIS__MAX ? InputAxis_str(mtt->axis) : \"invalid\";\n trace_input_event_mtt(idx, name, mtt->value);\n break;\n case INPUT_EVENT_KIND__MAX:\n","prefixes":[]}