{"id":2232130,"url":"http://patchwork.ozlabs.org/api/patches/2232130/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260503005723.68888-1-francisco@maestretorreblanca.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260503005723.68888-1-francisco@maestretorreblanca.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260503005723.68888-1-francisco@maestretorreblanca.com/","date":"2026-05-03T00:57:23","name":"[v2] macintosh: windfarm_ad7417: fix coding style issues","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7df20dfce8b510f8d0a0ad23c4253e13f27a962c","submitter":{"id":93109,"url":"http://patchwork.ozlabs.org/api/people/93109/?format=json","name":"Francisco Maestre","email":"francisco@maestretorreblanca.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260503005723.68888-1-francisco@maestretorreblanca.com/mbox/","series":[{"id":502557,"url":"http://patchwork.ozlabs.org/api/series/502557/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=502557","date":"2026-05-03T00:57:23","name":"[v2] macintosh: windfarm_ad7417: fix coding style issues","version":2,"mbox":"http://patchwork.ozlabs.org/series/502557/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232130/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2232130/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=maestretorreblanca.com header.i=@maestretorreblanca.com\n header.a=rsa-sha256 header.s=google header.b=anNY7+R0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20387-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::a34\"","lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=maestretorreblanca.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=maestretorreblanca.com header.i=@maestretorreblanca.com\n header.a=rsa-sha256 header.s=google header.b=anNY7+R0;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=maestretorreblanca.com\n (client-ip=2607:f8b0:4864:20::a34; helo=mail-vk1-xa34.google.com;\n envelope-from=francisco@maestretorreblanca.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g7RFp3KBQz1xvV\n\tfor ; Sun, 03 May 2026 10:57:33 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g7RFm4ctkz2yZ6;\n\tSun, 03 May 2026 10:57:32 +1000 (AEST)","from mail-vk1-xa34.google.com (mail-vk1-xa34.google.com\n [IPv6:2607:f8b0:4864:20::a34])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g7RFl2ygqz2xQB\n\tfor ; Sun, 03 May 2026 10:57:30 +1000 (AEST)","by mail-vk1-xa34.google.com with SMTP id\n 71dfb90a1353d-575212eb419so94244e0c.1\n for ;\n Sat, 02 May 2026 17:57:30 -0700 (PDT)","from localhost.localdomain ([95.214.114.12])\n by smtp.gmail.com with ESMTPSA id\n 71dfb90a1353d-574a6c6c582sm4009660e0c.9.2026.05.02.17.57.25\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Sat, 02 May 2026 17:57:26 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777769852;\n\tcv=none;\n b=D3iJiva1teonOET7qeJxYtBparOGoly1id3mjcOX+iq0BGcSz2oOypUJha1sjK992mNtaGmd+fG3gXnt0tmngI1PenMaBtAR8BqPdGYb8z4tP0J39SwFjcazTh9KuRLlSV4w+8Dodwbm5+punz4nAXqHklgF2PEM/JqUsjkFM2jLCc2Y1BvbYjqKcASU3nEQp1pnh1RIhhN/NXMQ4W0gEMXxysKDS5S4RjZX0ZnATXUprspvBxARFwPITdMngftfEtZGob01dRewjyWl5atp1x8HME1hNAXkWuJktam/lXSEhNEH/nd51REXQ6Fk9aGzL26Vf5fdnCOQU9i2ldzuvQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777769852; c=relaxed/relaxed;\n\tbh=jAbutDuOdCLlr5MjEhNwBJAD8Xktp0AiK9lNlrbs3WE=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=YUamNUZkCegxznwYHYsiftToyqvz3uLnDdqpeUTw2C82xe19CzSm+Dnp76TKmc/3B+jg0gJ1LIU4rPjNYyqzkENuJb40PJXmje5/zAMjckHeKSbkfGyxC1ne0oVO0PphhsEsdJlewK3CLg5KcFTCmhIl9ifVnTKS87pFkCzh3+wQyILlSkF8Laybztl5hpzTUOCz1zdzVVf5d/8fU+NAnZR+x4/tEPZYRKpG7aJmUCr711CXkcx3hibdZF1xId4KJTl5xet5epWJaOGw0/JBcr5Tqs2nB/q03lJ8mhZ6ag27ToECtGeLExNE/cdZGfnXd6ZYFeFT4rXLWWHGSyYrmw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=maestretorreblanca.com;\n dkim=pass (2048-bit key;\n secure) header.d=maestretorreblanca.com header.i=@maestretorreblanca.com\n header.a=rsa-sha256 header.s=google header.b=anNY7+R0; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::a34; helo=mail-vk1-xa34.google.com;\n envelope-from=francisco@maestretorreblanca.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=maestretorreblanca.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=maestretorreblanca.com; s=google; t=1777769847; x=1778374647;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=jAbutDuOdCLlr5MjEhNwBJAD8Xktp0AiK9lNlrbs3WE=;\n b=anNY7+R0amYDBI+rGNH9NpWi7Q9ZMLUqu9NjOokzlt6Q8xffzku0WS+L/Dqw2u5ij2\n Vg1Sg4cgl8aAOksYUsp+gwBEvFUie0+JmfhLHOu7s4qM8TljuDsuKS5nyl+bk6nyJDdw\n ba5ajRDRjvW1BGDPI4WTR8M2gSHgQQk6iuJElgZjFW5IphHnYuppxG74XhgcHEeqDbWt\n PQjFfRVf3df+U/Imx0v2DRUQq5ob/nR9dhRrzF+giwiOR6mRhv4LWzOiAn0sDWMEL4vC\n WgzwS90X1XSHp+64BLOOcyIGeA/85F/XMsQt0iSu1+VFwshYjLSna2s6tAEgXPLdM8SE\n jBHQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777769847; x=1778374647;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=jAbutDuOdCLlr5MjEhNwBJAD8Xktp0AiK9lNlrbs3WE=;\n b=d82KbO2mylmnjMevvK3EZILznciinIiIIkrOfFaWKahwCz9zkW06oVN3d0pbpC0b34\n HVEHe9FKCl4o7BRtKUB60IH6q5CguQKmWz2cTUJ789EFsGQR7CVTl4BozWWozESkuE0Q\n sAMWWOimo7uJcnqGYNjV072Wq11TMBVWjrX9gcAjqam2GPr/dtmCMwqzgvzfPvGvq00Q\n A6VCoI0dM7K0YBf4W7AyjZYLOvfvS+ms63RB/0KIcH8fC2rLu7vDASUwFIFQ4RyDV6qq\n IHZIacpnH7wM1o9ywyD07AERcMbLH7j2fL7V/EGqFsSgt+5+PzTmAUljqPHH3bsoFCaM\n 3rLw==","X-Gm-Message-State":"AOJu0YwiJ/rlRUyylFkcTWrevIwKDrDkSzkye8GZWzI6091ercaKGqVv\n\tu1s9ywPKo8tUkxDQatGU6L/b6Q4CpHU4ckpDsUdtc7c42UU24QaEd0h9Loaqe7Stdn2LQiCkPQ6\n\tFQrHd1ZL0Lg==","X-Gm-Gg":"AeBDietTCyhgpy9s/szPfiMr2bD3LePjTZghIs5cz3xDCSQ24RQMtQBaN55I2Rvowh9\n\tGlDlx/TvLN+1iJe2CBwJKmsV0IvbHOWHZL40llHi4qz/Zx95Yvnx22LUqRBvpUFuXp8CqFs9qSw\n\tVFfo+jxpc1oTIlFEWcMbbJOCYNS7Z5YQPuDzyRVGSpJrUX0zH51MWWowwS0x3qLMYEKgcp+A+QQ\n\tt/CEDtjyyHDRj0WYE8kBroZvY5gN7f6TYlBhrphJyWjz1mw9E/fz947rBelurYbZ7sGeTTGmUOP\n\tunJ0hjE+1RipEgk0U1oxjLAEBoa16eU2hEyKKEbgqxqAAaIVQhfWBpK36FVhIS9SpbMi0qm6L9/\n\tkWEVwJTbOUfhvySJPqWXLQLgdojLLhzSk8mtWagljDk9Y6Y4jt5F42EEiRIUTH/OJ2voIvYpBvE\n\tw105drxpQmnPk485R1doDXsn9XPmw37My/5WQihydscRy5crLcGEa/VXBI0SFrBENOuN07ZBfD0\n\ttYxHvYQlzLa8VMs7PvHiIFNuY/0GWfiOCZ0Zw==","X-Received":"by 2002:a05:6122:328e:b0:56f:7e8a:a395 with SMTP id\n 71dfb90a1353d-5750c011345mr1658926e0c.1.1777769847071;\n Sat, 02 May 2026 17:57:27 -0700 (PDT)","From":"Francisco Maestre ","To":"linuxppc-dev@lists.ozlabs.org","Cc":"linux-kernel@vger.kernel.org,\n\tFrancisco Maestre ","Subject":"[PATCH v2] macintosh: windfarm_ad7417: fix coding style issues","Date":"Sat, 2 May 2026 19:57:23 -0500","Message-ID":"<20260503005723.68888-1-francisco@maestretorreblanca.com>","X-Mailer":"git-send-email 2.50.1","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Fix several coding style issues detected by checkpatch.pl:\n\n- Add missing space before open parenthesis in switch statement\n- Fix duplicated word 'a' in two comments ('a a' -> 'a')\n- Replace bare -1 return values with proper -EIO error code\n- Fix alignment of dev_dbg() argument continuation line\n- Use !ptr instead of ptr == NULL for NULL pointer check\n\nSigned-off-by: Francisco Maestre \n---\nv2: Resend as individual patch, not part of an unrelated series.\n drivers/macintosh/windfarm_ad7417_sensor.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/macintosh/windfarm_ad7417_sensor.c b/drivers/macintosh/windfarm_ad7417_sensor.c\nindex 4bae07ca6669..733dc711cdc7 100644\n--- a/drivers/macintosh/windfarm_ad7417_sensor.c\n+++ b/drivers/macintosh/windfarm_ad7417_sensor.c\n@@ -52,7 +52,7 @@ static int wf_ad7417_temp_get(struct wf_sensor *sr, s32 *value)\n \tif (rc < 0)\n \t\tgoto error;\n \n-\t/* Read a a 16-bit signed value */\n+\t/* Read a 16-bit signed value */\n \traw = be16_to_cpup((__le16 *)buf);\n \n \t/* Convert 8.8-bit to 16.16 fixed point */\n@@ -63,7 +63,7 @@ static int wf_ad7417_temp_get(struct wf_sensor *sr, s32 *value)\n \n error:\n \tmutex_unlock(&pv->lock);\n-\treturn -1;\n+\treturn -EIO;\n }\n \n /*\n@@ -79,7 +79,7 @@ static int wf_ad7417_temp_get(struct wf_sensor *sr, s32 *value)\n static void wf_ad7417_adc_convert(struct wf_ad7417_priv *pv,\n \t\t\t\t int chan, s32 raw, s32 *value)\n {\n-\tswitch(chan) {\n+\tswitch (chan) {\n \tcase 1: /* Diode */\n \t\t*value = (raw * (s32)pv->mpu->mdiode +\n \t\t\t((s32)pv->mpu->bdiode << 12)) >> 2;\n@@ -128,7 +128,7 @@ static int wf_ad7417_adc_get(struct wf_sensor *sr, s32 *value)\n \t\tif (rc < 0)\n \t\t\tgoto error;\n \n-\t\t/* Read a a 16-bit signed value */\n+\t\t/* Read a 16-bit signed value */\n \t\traw = be16_to_cpup((__le16 *)buf) >> 6;\n \t\twf_ad7417_adc_convert(pv, chan, raw, value);\n \n@@ -141,12 +141,12 @@ static int wf_ad7417_adc_get(struct wf_sensor *sr, s32 *value)\n \n \terror:\n \t\tdev_dbg(&pv->i2c->dev,\n-\t\t\t \"Error reading ADC, try %d...\\n\", i);\n+\t\t\t\"Error reading ADC, try %d...\\n\", i);\n \t\tif (i < 9)\n \t\t\tmsleep(10);\n \t}\n \tmutex_unlock(&pv->lock);\n-\treturn -1;\n+\treturn -EIO;\n }\n \n static void wf_ad7417_release(struct kref *ref)\n@@ -261,7 +261,7 @@ static int wf_ad7417_probe(struct i2c_client *client)\n \t}\n \n \tpv = kzalloc_obj(struct wf_ad7417_priv);\n-\tif (pv == NULL)\n+\tif (!pv)\n \t\treturn -ENODEV;\n \n \tkref_init(&pv->ref);\n","prefixes":["v2"]}