{"id":2232129,"url":"http://patchwork.ozlabs.org/api/patches/2232129/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260503003530.62539-1-francisco@maestretorreblanca.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260503003530.62539-1-francisco@maestretorreblanca.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260503003530.62539-1-francisco@maestretorreblanca.com/","date":"2026-05-03T00:35:30","name":"[2/3] macintosh: windfarm_ad7417: fix coding style issues","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7df20dfce8b510f8d0a0ad23c4253e13f27a962c","submitter":{"id":93109,"url":"http://patchwork.ozlabs.org/api/people/93109/?format=json","name":"Francisco Maestre","email":"francisco@maestretorreblanca.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260503003530.62539-1-francisco@maestretorreblanca.com/mbox/","series":[{"id":502556,"url":"http://patchwork.ozlabs.org/api/series/502556/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=502556","date":"2026-05-03T00:35:30","name":null,"version":1,"mbox":"http://patchwork.ozlabs.org/series/502556/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232129/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232129/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=maestretorreblanca.com header.i=@maestretorreblanca.com\n header.a=rsa-sha256 header.s=google header.b=PR6Gsocg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20386-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::a2f\"","lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=maestretorreblanca.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=maestretorreblanca.com header.i=@maestretorreblanca.com\n header.a=rsa-sha256 header.s=google header.b=PR6Gsocg;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=maestretorreblanca.com\n (client-ip=2607:f8b0:4864:20::a2f; helo=mail-vk1-xa2f.google.com;\n envelope-from=francisco@maestretorreblanca.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g7Qmc2m26z1yJV\n\tfor ; Sun, 03 May 2026 10:35:43 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g7QmZ27Tzz2yZ6;\n\tSun, 03 May 2026 10:35:42 +1000 (AEST)","from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com\n [IPv6:2607:f8b0:4864:20::a2f])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g7QmX0YHdz2xQB\n\tfor ; Sun, 03 May 2026 10:35:38 +1000 (AEST)","by mail-vk1-xa2f.google.com with SMTP id\n 71dfb90a1353d-56a8e0ea02aso2803486e0c.0\n for ;\n Sat, 02 May 2026 17:35:38 -0700 (PDT)","from localhost.localdomain ([95.214.114.12])\n by smtp.gmail.com with ESMTPSA id\n 71dfb90a1353d-574a6c6b8f1sm4316524e0c.12.2026.05.02.17.35.32\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Sat, 02 May 2026 17:35:34 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777768542;\n\tcv=none;\n b=mOq4buBg3n4VfZ9Izl3U20D9hH4XDq3k5Hxj+e3e6cC9E5HMkC/pPBNdV+JBC0ftH2n2xeo45snRnpi4FDCBFW5Q0NNqoxOFeHjUFIcnvzZDRBLK0XN5IDtxcty4H0tZnc6p1bD8bEJeO9qcLExCwzhfLgUx/0AT4M9EhyZiR9nb0CICrx62U1a/PUcc9ycdW9CJgKEtKPjkD0JSHBYOsrEz2g3He3DU1xxXbyyaKWsSENif0JqtyVv76Te4pLbtVRH1Wc8qKsgNgKlVIQ4PjOyLgRdOhxVWo+gIV65yMVPb3wdlzTfQLdrmzmTZRGQpmdN+zEd97Jsvicv7kpQrMA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777768542; c=relaxed/relaxed;\n\tbh=fbU9XP4r+Vkqdo073U4JVzbvhQhcQEwvGnAM/1xTwyA=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=dlmOtQJJ2enS7rN+kIb3gY10e5wAHug6N6qnUDOy4IkLGqCplHmXM+CqTeaDg6ZXzaws4G8KzZUsn/3ocqO6wJVCDjdpej6cVo24hqTkK7G/sxS2vPIayGlyz0NEgfa60E8yRgehICG/Ff5aPKkYHuDGoOM0q3zlTgvTr6YFmbOxayEVnzYkzh/YT8ClpcxY+j94k9yq9O+a4TJk6nUhvS9g3zKP1MQBYgoOik5sA3j5ebD1sC+8xYLvzM+ZiiLtTW1nyWA789naQAonZGEPkHeMsIB/6Z7PLzn18EyY7N+O3Fj4IoT8eyEc88bzH45/0Wl281DDlF4kaCyxzqeOBA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=maestretorreblanca.com;\n dkim=pass (2048-bit key;\n secure) header.d=maestretorreblanca.com header.i=@maestretorreblanca.com\n header.a=rsa-sha256 header.s=google header.b=PR6Gsocg; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::a2f; helo=mail-vk1-xa2f.google.com;\n envelope-from=francisco@maestretorreblanca.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=maestretorreblanca.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=maestretorreblanca.com; s=google; t=1777768535; x=1778373335;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=fbU9XP4r+Vkqdo073U4JVzbvhQhcQEwvGnAM/1xTwyA=;\n b=PR6GsocgF+ejZG8z86NYhFhLo1hgZwUgMSKMU0zp8kMK1HBxUQHWXyZ+kc3I6NEZYZ\n gsXybMuJly5EcsIW6N9nq9ZBvYrVJJtrRaiyJfQj2dDlYYH3SK9pcGVGHMw2ghjr8DPX\n vB/iewwHXtmKz5ujeDuVje1joivDpueEFmu/BJhkufEX355KBRP+DLRVa5Zlj807kqWt\n DjATll4YWuMZONpwOG+NwpI6mOupXkxX0L3RM+wg7xlBo5sGSWjlWEeCq+UmsfmUEoOB\n VZWp+2n/FKa7lr84Lxtme/Lq9JV6eSl4mR3xrmQqJrU/kSpM181/drzi3CTjEAMhXAf+\n l4Kg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777768535; x=1778373335;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fbU9XP4r+Vkqdo073U4JVzbvhQhcQEwvGnAM/1xTwyA=;\n b=ZCx/xec4wGZH+iUJbYSd3yXI7gaQ3AqyRBHlCOdIDEV1WGuCnHrXmrCx4sXMI2p2xR\n YwQWD2Jy1+KSjwV9Mj7HiUrnmigTQzRO86fZHz+9Dr8rh4ck7XjVyFQrUIEYck3cgYhl\n QLgOiEnTIZjPj4usEKqDXEkNqTtyf+E8KcD75BdTaSDerzP+f7IYO5WciItQii05AjtU\n dKmq9SlsFu6igrRxMTBdmUSLMXJsKp07+yeo8UdpyRVuNkKw3SGOUXd9sP1nPDyLdD7U\n LpP0iu4vimcCE5wiGtgIvET9dQJYYAMlh4sfg2pIyGZJQEAJfz5tYeA6swtpNbYxsig/\n wj3Q==","X-Gm-Message-State":"AOJu0YxM/sIF6At39BSH+r18thXcKIL3ZLZ/ptOm1vtgalbDMwLznN1R\n\tK8mW0TUjYC1Zzae6WwZE5UeI6HJFqfDpB+tMQUYdqC1+GxM1dWIjKq8aE0LAzDFVmGP0eb9sQvd\n\tzxqWSAEDkYQ==","X-Gm-Gg":"AeBDieuo3m/w9g8Vhr4O+qr5sDDRwzKFPpXOn6JZMTJyqYmUythxudVE+lrAiUC+VbV\n\t/mMtERJSGCbQntUXOndx90ufbtxpmsiPaa708I/S+SteGtk0FAJclHwdg1wtaFTkfUtsE9ZpnNQ\n\tQfUNuNtoEPIega3UiNSK1xl2uOSs54r6GO5/3QUdWT5fAgShp9G90TkWe0oJZ8KJT9gLG+3PN/i\n\t+oMv8y7fP7j7vL4qc3i1fk3sXoi5BmE1GzOfTW/fbZic+bVT2FfR3mZR+AJxrY8PBWio6MuSWYu\n\t1UQZmT684ziI+zjHyopfPjMNAeHMQ66WS1cu8ub5HeG1fqut1w73x0wJQF3WVxwK5oZ5wajsFn0\n\t2WQbAxDiKpERSMEFYTfP7XZfxUfVz2MnOfS1xZza6bze6JAZ6jTykF+KjLzkCsK8BslfKGnQTxf\n\trOrAf8CP6Gm8zN3MOLArxSGwaROntSgWPhRqt7WP7+RQVHGA84y33rpRA90E2ovCn9SX1FJQXVS\n\tnx7KOYMu1zVP1B7T82Gz1kCCQJfaY0uwFPxEQ==","X-Received":"by 2002:a05:6122:e447:b0:575:2166:74c3 with SMTP id\n 71dfb90a1353d-57521667d16mr245207e0c.9.1777768535452;\n Sat, 02 May 2026 17:35:35 -0700 (PDT)","From":"Francisco Maestre ","To":"linuxppc-dev@lists.ozlabs.org","Cc":"linux-kernel@vger.kernel.org,\n\tFrancisco Maestre ","Subject":"[PATCH 2/3] macintosh: windfarm_ad7417: fix coding style issues","Date":"Sat, 2 May 2026 19:35:30 -0500","Message-ID":"<20260503003530.62539-1-francisco@maestretorreblanca.com>","X-Mailer":"git-send-email 2.50.1","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Fix several coding style issues detected by checkpatch.pl:\n\n- Add missing space before open parenthesis in switch statement\n- Fix duplicated word 'a' in two comments ('a a' -> 'a')\n- Replace bare -1 return values with proper -EIO error code\n- Fix alignment of dev_dbg() argument continuation line\n- Use !ptr instead of ptr == NULL for NULL pointer check\n\nSigned-off-by: Francisco Maestre \n---\n drivers/macintosh/windfarm_ad7417_sensor.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/macintosh/windfarm_ad7417_sensor.c b/drivers/macintosh/windfarm_ad7417_sensor.c\nindex 4bae07ca6669..733dc711cdc7 100644\n--- a/drivers/macintosh/windfarm_ad7417_sensor.c\n+++ b/drivers/macintosh/windfarm_ad7417_sensor.c\n@@ -52,7 +52,7 @@ static int wf_ad7417_temp_get(struct wf_sensor *sr, s32 *value)\n \tif (rc < 0)\n \t\tgoto error;\n \n-\t/* Read a a 16-bit signed value */\n+\t/* Read a 16-bit signed value */\n \traw = be16_to_cpup((__le16 *)buf);\n \n \t/* Convert 8.8-bit to 16.16 fixed point */\n@@ -63,7 +63,7 @@ static int wf_ad7417_temp_get(struct wf_sensor *sr, s32 *value)\n \n error:\n \tmutex_unlock(&pv->lock);\n-\treturn -1;\n+\treturn -EIO;\n }\n \n /*\n@@ -79,7 +79,7 @@ static int wf_ad7417_temp_get(struct wf_sensor *sr, s32 *value)\n static void wf_ad7417_adc_convert(struct wf_ad7417_priv *pv,\n \t\t\t\t int chan, s32 raw, s32 *value)\n {\n-\tswitch(chan) {\n+\tswitch (chan) {\n \tcase 1: /* Diode */\n \t\t*value = (raw * (s32)pv->mpu->mdiode +\n \t\t\t((s32)pv->mpu->bdiode << 12)) >> 2;\n@@ -128,7 +128,7 @@ static int wf_ad7417_adc_get(struct wf_sensor *sr, s32 *value)\n \t\tif (rc < 0)\n \t\t\tgoto error;\n \n-\t\t/* Read a a 16-bit signed value */\n+\t\t/* Read a 16-bit signed value */\n \t\traw = be16_to_cpup((__le16 *)buf) >> 6;\n \t\twf_ad7417_adc_convert(pv, chan, raw, value);\n \n@@ -141,12 +141,12 @@ static int wf_ad7417_adc_get(struct wf_sensor *sr, s32 *value)\n \n \terror:\n \t\tdev_dbg(&pv->i2c->dev,\n-\t\t\t \"Error reading ADC, try %d...\\n\", i);\n+\t\t\t\"Error reading ADC, try %d...\\n\", i);\n \t\tif (i < 9)\n \t\t\tmsleep(10);\n \t}\n \tmutex_unlock(&pv->lock);\n-\treturn -1;\n+\treturn -EIO;\n }\n \n static void wf_ad7417_release(struct kref *ref)\n@@ -261,7 +261,7 @@ static int wf_ad7417_probe(struct i2c_client *client)\n \t}\n \n \tpv = kzalloc_obj(struct wf_ad7417_priv);\n-\tif (pv == NULL)\n+\tif (!pv)\n \t\treturn -ENODEV;\n \n \tkref_init(&pv->ref);\n","prefixes":["2/3"]}