{"id":2232050,"url":"http://patchwork.ozlabs.org/api/patches/2232050/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260502141258.17128-1-atrajeev@linux.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260502141258.17128-1-atrajeev@linux.ibm.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260502141258.17128-1-atrajeev@linux.ibm.com/","date":"2026-05-02T14:12:57","name":"[V3,1/2] tools/perf: Fix the check for parameterized field in event term","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3640932a68b018b9aef7095e174af1b058e46af0","submitter":{"id":90290,"url":"http://patchwork.ozlabs.org/api/people/90290/?format=json","name":"Athira Rajeev","email":"atrajeev@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260502141258.17128-1-atrajeev@linux.ibm.com/mbox/","series":[{"id":502529,"url":"http://patchwork.ozlabs.org/api/series/502529/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=502529","date":"2026-05-02T14:12:57","name":"[V3,1/2] tools/perf: Fix the check for parameterized field in event term","version":3,"mbox":"http://patchwork.ozlabs.org/series/502529/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2232050/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2232050/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linuxppc-dev+bounces-20380-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=I9u1HIgX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20380-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.156.1","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=I9u1HIgX;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=atrajeev@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g78ys6hntz1yJ0\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 03 May 2026 00:13:41 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g78yl49TMz2xtC;\n\tSun, 03 May 2026 00:13:35 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g78yj5jw2z2xlr\n\tfor <linuxppc-dev@lists.ozlabs.org>; Sun, 03 May 2026 00:13:32 +1000 (AEST)","from pps.filterd (m0356517.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 64247jb31939676;\n\tSat, 2 May 2026 14:13:21 GMT","from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9y115g9-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tSat, 02 May 2026 14:13:21 +0000 (GMT)","from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 642E9WPZ006849;\n\tSat, 2 May 2026 14:13:20 GMT","from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230])\n\tby ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dw9jysc3n-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tSat, 02 May 2026 14:13:20 +0000 (GMT)","from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com\n [10.20.54.100])\n\tby smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 642EDGGJ31785306\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tSat, 2 May 2026 14:13:16 GMT","from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 155BA20043;\n\tSat,  2 May 2026 14:13:16 +0000 (GMT)","from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id CEB7320040;\n\tSat,  2 May 2026 14:13:10 +0000 (GMT)","from localhost.localdomain (unknown [9.124.223.37])\n\tby smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tSat,  2 May 2026 14:13:10 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777731215;\n\tcv=none;\n b=gl1RDWIogutFFvQOujmoRsQIo1pZ2SUvqz3p4chumG+nj9P1X5u+1+0ynPJHK5qxJNyPpRgeB9Vx0pOXQR8oOX5OcejMaWEZMfV/smye/copURrN2b7S3VoyVw2CmdUukG7rLnQ68tIvAhBUJTZPLI/CF+7OlY8+lnkT/0lvLidYFOqbBNGCCAqA4L1T+8pJQbmjnsrcdPGGZDtbUb9Y8xUokMNA9hRqmJ8pmIGyA5evnyA1aKXJxOARfG5SqoCo4PMGl3vSyvBGnG2ix+SdjJU5o55a5ox2/8aqvUClFLUT5JmtBuEOpZPdKrmxSMiJQZZGbbPIHrXXBj7ARzH/Kw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777731215; c=relaxed/relaxed;\n\tbh=NQrnYnlv2aAV3m8E8dm1/D40QRqTd3oQDjHplzORYhU=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=A7TKvJpb7f+WlhniyXmo4eXcTMpE70adTznDJv+tLepi2W+WJcmQygHGfiKRrzu3KVvsWLEzSzw5bs5KIN6Weq6th/rPPamxpAVyrIXcYRooZUb6JZ5y0iJ7PtrztVaYoZrqI2E4kU0Hoc+/couS2dQpbavtYV0JEEGQ8WYdB08FnNP2N2R2/yNLhl6i9mtpy7JXEso0y4an7Gw8dHvFBoOTyJnhh1v2cJbzJmsG/XYjfQYIyrzgq1DhjcwD7SgFXKUitjUwN0s5nGnV+GPUyU7jrRFZJB3XPdMmtyISCyTvpaRGwOlqMDKJMfFr75f5glbDWElPFCnTvcYTEB2G+A==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=I9u1HIgX; dkim-atps=neutral;\n spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=atrajeev@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=pp1; bh=NQrnYnlv2aAV3m8E8dm1/D40QRqTd3oQDjHplzORY\n\thU=; b=I9u1HIgXV2PwGhR1plwyVjynBUsyhQ4AmkNH3NThKQuXMhYzFnV/kyo7Y\n\th+6SYr/oZVFP6vLpPIDIb1GQypLQovB0NiULIfo5Y6y0H4UsDFcVdm2RSQUciLZy\n\tyYYDEnqrDM3cDhkxSWKwj74x+1X0jPjYulyGNAFclGacz5kOPso0LCeZHm0Gj9Zw\n\tw06enfTfeYqVx4c/DYm9Ov9uPAbP8evgYolYx2pxwtQhpp8y7sTsDV1fq4oAeRbk\n\tG46S5IJqcS8rWj128ryF3P54o/EHHMnn2QlnY4RZVNZnt6j13MDwbkIaP2F0A2yr\n\trBVzs6huYOOhWxTfSMNpSuwgJF8zA==","From":"Athira Rajeev <atrajeev@linux.ibm.com>","To":"acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,\n        mpetlan@redhat.com, tmricht@linux.ibm.com, maddy@linux.ibm.com,\n        irogers@google.com, namhyung@kernel.org","Cc":"linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n        atrajeev@linux.ibm.com, hbathini@linux.vnet.ibm.com,\n        Tejas.Manhas1@ibm.com, Tanushree.Shah@ibm.com, shivani@linux.ibm.com","Subject":"[PATCH V3 1/2] tools/perf: Fix the check for parameterized field in\n event term","Date":"Sat,  2 May 2026 19:42:57 +0530","Message-Id":"<20260502141258.17128-1-atrajeev@linux.ibm.com>","X-Mailer":"git-send-email 2.39.5 (Apple Git-154)","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-ORIG-GUID":"Dd5NJWAcZdTcg9JcDuyXVWXmel297htt","X-Proofpoint-GUID":"v3b8Wpc3F7E56A3wawAnh1eCXMBYpARW","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTAyMDE0MSBTYWx0ZWRfX9rLyTNIXt5pI\n YV6pYYakdONQ43gaObDL2T5QOBUJ90azDIIz0H7MYRzc78S7JNPgqFe5I7tEWK6Dgs8wgRMFdG8\n hsSrj41O2rAfdYu2axgRQfnVn2W8oqSMxFmhvWIS1ZWjrrGbAX86Q3Nt0waXPQnQx/mnHYAbVj/\n OV/ewH/Q7cR0uoDY2ODZp1yblya0VGLWPDxjqvPcDrzkStFQ048uNORMLnsm1TqoXvXKMEH8dv4\n LK5K4a0EwhcXuW6lZEEvmvWoawciPA/CAqU5tKih3l8/aUCGVe8xt/f6hgVfMxCTe53Dc4+a+Of\n YdIEjDpo073gMmYqGd00iam4CVB/BpiP8axCkU44FmadWcR/v5yHroMX50ykd9mxFfdpkDUBHbx\n 7djav89PHIPMEUUPzI9vUUwYkC05/BgpOtBd3S1Qop4pjgFT2tXdHf+h58OsSNGQMYywmMFysEn\n EC2GHZc4Z9JrpcqU8Mg==","X-Authority-Analysis":"v=2.4 cv=UbFhjqSN c=1 sm=1 tr=0 ts=69f60681 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=KlCRr-_lrQmZq1rU:21 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VnNF1IyMAAAA:8\n a=g2m9RzfYH6J901Z4KtUA:9","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-02_03,2026-04-30_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0\n adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605020141","X-Spam-Status":"No, score=0.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"The format_alias() function in util/pmu.c has a check to\ndetect whether the event has parameterized field ( =? ).\nThe string alias->terms contains the event and if the event\nhas user configurable parameter, there will be presence of\nsub string \"=?\" in the alias->terms.\n\nSnippet of code:\n\n /* Paramemterized events have the parameters shown. */\n       if (strstr(alias->terms, \"=?\")) {\n               /* No parameters. */\n               snprintf(buf, len, \"%.*s/%s/\", (int)pmu_name_len, pmu->name, alias->name);\n\nif \"strstr\" contains the substring, it returns a pointer\nand hence enters the above check which is not the expected\ncheck. And hence \"perf list\" doesn't have the parameterized\nfields in the result.\n\nFix this check to use:\n\nif (!strstr(alias->terms, \"=?\")) {\n\nWith this change, perf list shows the events correctly with\nthe strings showing parameters.\n\nSigned-off-by: Athira Rajeev <atrajeev@linux.ibm.com>\n---\nChangelog:\nv2 -> v3:\nSplit the strstr correction in a single patch\n\n tools/perf/util/pmu.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c\nindex 23337d2fa281..0b8d58543f17 100644\n--- a/tools/perf/util/pmu.c\n+++ b/tools/perf/util/pmu.c\n@@ -2117,7 +2117,7 @@ static char *format_alias(char *buf, int len, const struct perf_pmu *pmu,\n \t\t\t\t\t\t   skip_duplicate_pmus);\n \n \t/* Paramemterized events have the parameters shown. */\n-\tif (strstr(alias->terms, \"=?\")) {\n+\tif (!strstr(alias->terms, \"=?\")) {\n \t\t/* No parameters. */\n \t\tsnprintf(buf, len, \"%.*s/%s/\", (int)pmu_name_len, pmu->name, alias->name);\n \t\treturn buf;\n","prefixes":["V3","1/2"]}