{"id":2231662,"url":"http://patchwork.ozlabs.org/api/patches/2231662/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/f2141eafb80e7780395e03aa9a22e8a37be80513.1777606826.git.ritesh.list@gmail.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"","list_archive_url":"https://lore.kernel.org/linuxppc-dev/f2141eafb80e7780395e03aa9a22e8a37be80513.1777606826.git.ritesh.list@gmail.com/","date":"2026-05-01T04:11:43","name":"[v3,4/9] pseries/papr-hvpipe: Fix & simplify error handling in papr_hvpipe_init()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5b2abf846cc21e4c3506223954c98fc8ed2e43c4","submitter":{"id":79126,"url":"http://patchwork.ozlabs.org/api/people/79126/?format=json","name":"Ritesh Harjani (IBM)","email":"ritesh.list@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/f2141eafb80e7780395e03aa9a22e8a37be80513.1777606826.git.ritesh.list@gmail.com/mbox/","series":[{"id":502420,"url":"http://patchwork.ozlabs.org/api/series/502420/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=502420","date":"2026-05-01T04:11:39","name":"pseries/papr-hvpipe: Fix deadlock, races and misc cleanups","version":3,"mbox":"http://patchwork.ozlabs.org/series/502420/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231662/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231662/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=TkW+3t3s;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20355-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::42a\"","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=TkW+3t3s;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::42a; helo=mail-pf1-x42a.google.com;\n envelope-from=ritesh.list@gmail.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6Hh460VRz1y04\n\tfor ; Fri, 01 May 2026 14:12:52 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g6Hgl70WQz30Bd;\n\tFri, 01 May 2026 14:12:35 +1000 (AEST)","from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com\n [IPv6:2607:f8b0:4864:20::42a])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g6Hgl2GCyz2xjd\n\tfor ; Fri, 01 May 2026 14:12:35 +1000 (AEST)","by mail-pf1-x42a.google.com with SMTP id\n d2e1a72fcca58-82cebbdbdccso968574b3a.1\n for ;\n Thu, 30 Apr 2026 21:12:35 -0700 (PDT)","from localhost.localdomain ([49.205.216.49])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-83515b485eesm1159428b3a.48.2026.04.30.21.12.28\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 30 Apr 2026 21:12:32 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777608755;\n\tcv=none;\n b=Cpn0bh4FbzOUH5i2cYMeU/X6T0Oo+cimzMJRokCJWa3uy5Lpoh6PeoUDZSs22F5goa6wmNIYZ3PK78DRSa6thOh7VQnAvWPCArnQhQJMEYCOyLIQraufAs8QtpHIW6JYC/SErxEAAK161qKbAod0/SUa4yFJwq6A78Y+Y0HqH4fFakkrHVYY37d0n7UNg/su0qQKzh/z4rGyE9SxyFzZEcMEPIkGN+PKZiXZVDr/UHRnrrsRbxeUJC/JApDSMM3iy6atMpkqvHqYfXxaN7zdLhDtwsGqwiIaqsL4U+Ozi50Q4+LTJoxNh/ZAP174PMAnbwK1D7sPW56ynVwFZaIstg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777608755; c=relaxed/relaxed;\n\tbh=FX+puozfKOk6l+f90pyqn7buO5CtmALr+6nyHUFvWvA=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=YVjXabg53D2CcK6a3TpDNV/twvN9s/9hmRmDCU3QwZuzLINuDGm9b3QFDH4RM71Om6/MQFAZt5ZWOKi1IYtZcTa0n41+/0+nnhAdp43ehJFsYzpU3syd+gtTlBeblXOUTGoPstX/GnacZDS2RfJFiBPU1D+nMHxROj3zv8/UB1Hs8XSwbfwhCHm1i9kxeOF8WIRVw8ewt3MI/aIgjL9llGrcXSsbZfaAEw0xj2EMyMhYqRbMC29BBcEkNLILcjTtMf5vviJDM7b4Wj5AnYBtbTltunByfuEGZNLRlggZeSElCGj8FK3E0dXwi2dEs39arFIi2/rsRFWwcOwcWxoqKg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=TkW+3t3s; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::42a; helo=mail-pf1-x42a.google.com;\n envelope-from=ritesh.list@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777608753; x=1778213553;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FX+puozfKOk6l+f90pyqn7buO5CtmALr+6nyHUFvWvA=;\n b=TkW+3t3sBawiPcCHts8z3UCGcQhlDWLciPJNgBpquH49vKZp+J0b6yq9wRxKZ7FKTm\n pS875XZ5pAvSaaskRIb14NWr1PVgyOkXD3F2hwgIAxeFZ9hWP4zzcQZhj0JLaiY+IbW7\n IPV5gZIinWoxEM0zeUO5HEkFyiLzt7y7KKFxaNF4/fwYLI4ij+YkGSWXVWtvP8bFPW9Q\n +N283YVinSZvtoaMNo0mDH0PwNMoaJr2CJGh+v178RVvwrexH6WFAaf7rd7JdjCvS8fK\n flxXC0sUg2VtrjWQx6Et0KBHjnjK/eUwE2gdph2skXDJLrPf6QChoWo+JGQdCRk6CfYM\n Z7KQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777608753; x=1778213553;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=FX+puozfKOk6l+f90pyqn7buO5CtmALr+6nyHUFvWvA=;\n b=khQBzjHkqgE8rkHs1ILGTcjZLdpVjlv3woK+eg8v9NEUjRAwZjYYjsor8NETVwUmWv\n mhJmqXVOurs1Cm9nbgvD1z5jLYqdPtFHC3cHJwTNzS3NeXr+JCFdcaxytYQKsyXXWQmF\n 3Fx81YtPJhHCrSHSaAA7syCoByFyEmJZ0hXGQn9Bd27VRoC6PL5EkKWhKlo+5ev6dciv\n YMHu8gLn7oJ4M8nFyD/3PJQXS6lA3rRgy02JoCnCuICOPy7hyeNiHNqCUQhN1rJW0xaj\n WmNg1WoWvE9Qxc+scz+x0tWsbx6F8k8SbsunFQLQ209giTJ6DW5JO52lgmvT3dlqNDGE\n nmDQ==","X-Gm-Message-State":"AOJu0YybKuK0vfkIAAxbd4Y8lv1uX9CFYZOMYBbgyJqHAxbVNWdG3PcH\n\tBxul9X/lAhDGdOLt/PfMPiIbOjo76Om0I0HveP+0HMre13cQIvx57xF7hHoCgu63","X-Gm-Gg":"AeBDievexT9ZMFmyuj0wXberg+fZ53mneTLw4M6uhe3vI4zGbwb9BMeErT4oeU6nrJw\n\t7mtYe/nq98/BQyoVC51JTYUIYbPooHjV1m94IPOw++ZdWB7cnrYC/8Lo1gLClStI3gIsz3NaJ0T\n\tIUHA6mGi7S1di3TjdCilEG7FsQ6tXi78j9k+BXSZkcGPMJPR5TPQvJRHF+4lAcGJqUHNolFMKa0\n\tKvlL1nHw1HDa9UW30fufM6bZZnI3zFfEV2TS8QMWRUbWY+jbm/oLdYHkeiDJhRHTy2d3P9MN9cp\n\tv4yaL40s0bcM3cCkyc9sUnEH7wN0zapDxv4A9vJ/y8NAFXTiX69kvmpXuMiDrdjwCYXeB9AhUS/\n\tG7nQqcLpcpcCwtRaGBm0BiSSIwgKnj+TXZsibE51TaZeGe9To2Ii18HbZdpHCDLH5/Q6cyBp7WW\n\tGJLC0+72iPCAi0Nb63caSj22ZjfvijH3mDEqWQPPG7P/peTu8PASQv7c0i4usOvotKExFOn/SKU\n\tg==","X-Received":"by 2002:a05:6a00:3e27:b0:82f:3774:4fdc with SMTP id\n d2e1a72fcca58-834fff78b31mr5164676b3a.1.1777608752763;\n Thu, 30 Apr 2026 21:12:32 -0700 (PDT)","From":"\"Ritesh Harjani (IBM)\" ","To":"linuxppc-dev@lists.ozlabs.org,\n\tHaren Myneni ","Cc":"Madhavan Srinivasan ,\n\tChristophe Leroy ,\n\tVenkat Rao Bagalkote ,\n\tNicholas Piggin ,\n\tlinux-kernel@vger.kernel.org,\n\t\"Ritesh Harjani (IBM)\" ,\n\tstable@vger.kernel.org","Subject":"[PATCH v3 4/9] pseries/papr-hvpipe: Fix & simplify error handling in\n papr_hvpipe_init()","Date":"Fri, 1 May 2026 09:41:43 +0530","Message-ID":"\n ","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"","References":"","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Remove such 3 levels of nesting patterns to check success return values\nfrom function calls.\n\nret = enable_hvpipe_IRQ()\n if (!ret)\n\t ret = set_hvpipe_sys_param(1)\n\t if (!ret)\n\t\t ret = misc_register()\n\nInstead just bail out to \"out*:\" labels, in case of any error. This\nsimplifies the init flow.\n\nWhile at it let's also fix the following error handling logic:\nWe have already enabled interrupt sources and enabled hvpipe to received\ninterrupts, if misc_register() fails, we will destroy the workqueue, but\nthe HMC might send us a msg via hvpipe which will call, queue work on\nthe workqueue which might be destroyed.\n\nSo instead, let's reverse the order of enabling set_hvpipe_sys_param(1)\nand in case of an error let's remove the misc dev by calling\nmisc_deregister().\n\nCc: stable@vger.kernel.org\nFixes: 39a08a4f94980 (\"powerpc/pseries: Enable hvpipe with ibm,set-system-parameter RTAS\")\nSigned-off-by: Ritesh Harjani (IBM) \n---\n arch/powerpc/platforms/pseries/papr-hvpipe.c | 28 ++++++++++++--------\n 1 file changed, 17 insertions(+), 11 deletions(-)","diff":"diff --git a/arch/powerpc/platforms/pseries/papr-hvpipe.c b/arch/powerpc/platforms/pseries/papr-hvpipe.c\nindex 402781299497..800649f309a5 100644\n--- a/arch/powerpc/platforms/pseries/papr-hvpipe.c\n+++ b/arch/powerpc/platforms/pseries/papr-hvpipe.c\n@@ -780,23 +780,29 @@ static int __init papr_hvpipe_init(void)\n \t}\n \n \tret = enable_hvpipe_IRQ();\n-\tif (!ret) {\n-\t\tret = set_hvpipe_sys_param(1);\n-\t\tif (!ret)\n-\t\t\tret = misc_register(&papr_hvpipe_dev);\n-\t}\n+\tif (ret)\n+\t\tgoto out_wq;\n \n-\tif (!ret) {\n-\t\tpr_info(\"hvpipe feature is enabled\\n\");\n-\t\thvpipe_feature = true;\n-\t\treturn 0;\n-\t}\n+\tret = misc_register(&papr_hvpipe_dev);\n+\tif (ret)\n+\t\tgoto out_wq;\n \n-\tpr_err(\"hvpipe feature is not enabled %d\\n\", ret);\n+\tret = set_hvpipe_sys_param(1);\n+\tif (ret)\n+\t\tgoto out_misc;\n+\n+\tpr_info(\"hvpipe feature is enabled\\n\");\n+\thvpipe_feature = true;\n+\treturn 0;\n+\n+out_misc:\n+\tmisc_deregister(&papr_hvpipe_dev);\n+out_wq:\n \tdestroy_workqueue(papr_hvpipe_wq);\n out:\n \tkfree(papr_hvpipe_work);\n \tpapr_hvpipe_work = NULL;\n+\tpr_err(\"hvpipe feature is not enabled %d\\n\", ret);\n \treturn ret;\n }\n machine_device_initcall(pseries, papr_hvpipe_init);\n","prefixes":["v3","4/9"]}