{"id":2231490,"url":"http://patchwork.ozlabs.org/api/patches/2231490/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260430182543.3931718-3-rc@rexion.ai/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430182543.3931718-3-rc@rexion.ai>","list_archive_url":null,"date":"2026-04-30T18:25:42","name":"[net-next,v2,2/3] netfilter: nf_conntrack_irc: use nf_ct_helper_parse_port()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"18d14ba98468344e17533aa3235f1cc2778bc3b9","submitter":{"id":93293,"url":"http://patchwork.ozlabs.org/api/people/93293/?format=json","name":"HACKE-RC","email":"rc@rexion.ai"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260430182543.3931718-3-rc@rexion.ai/mbox/","series":[{"id":502357,"url":"http://patchwork.ozlabs.org/api/series/502357/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=502357","date":"2026-04-30T18:25:41","name":"netfilter: conntrack: add shared port parser and use it in IRC and Amanda helpers","version":2,"mbox":"http://patchwork.ozlabs.org/series/502357/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231490/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231490/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" header.d=rexion.ai\n header.i=@rexion.ai header.a=rsa-sha256 header.s=spacemail header.b=iCc8hK9k;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12351-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key) header.d=rexion.ai\n header.i=@rexion.ai header.b=\"iCc8hK9k\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=63.250.43.88","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=rexion.ai","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=rexion.ai"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g62vx44wgz1yHZ\n\tfor ; Fri, 01 May 2026 04:37:17 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id DF6B63051AB8\n\tfor ; Thu, 30 Apr 2026 18:35:04 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A53F447D92E;\n\tThu, 30 Apr 2026 18:35:02 +0000 (UTC)","from out-03.smtp.spacemail.com (out-03.smtp.spacemail.com\n [63.250.43.88])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EBA04779A4;\n\tThu, 30 Apr 2026 18:35:00 +0000 (UTC)","from Kyren (unknown [49.207.224.37])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mail.spacemail.com (Postfix) with ESMTPSA id 4g62g33chZz8sWt;\n\tThu, 30 Apr 2026 18:26:07 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777574102; cv=none;\n b=l7oZvfOGczqJS+8u5eeBMhfqjMG+96nZlFLGDJ1KIVcmZNX741rS96EwCkolR66KBSbCvZceWLBQoZjrkcJDImzOrOSlTcAOQQc4hxW0w+MDFOJRyDSWyS67XGvsn0q7nStNtx2cB97zRgzFuZeGjwLnmamXyuvoaEZSQ7pgwEQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777574102; c=relaxed/simple;\n\tbh=nLWDjCYG2VJb/niqMQC2v2WrYtWZ4BxwIhZ+B8UKc9g=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=R8AwfQXPbNR6II4AtJfWnBC4FhKIv1Z02FtkWj0BSPxsNPZ50xMB0D9UUBcAQtl22JIXq8gvitnXa5YfPA06235YzT9R2gciHDE4JZMOIr81nvhzrsAYqsApb8lv/pDHBEwZSjtdH+dtnSBDXhscD1JthXQDCkilSB1dEktHLuM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=rexion.ai;\n spf=pass smtp.mailfrom=rexion.ai;\n dkim=fail (0-bit key) header.d=rexion.ai header.i=@rexion.ai\n header.b=iCc8hK9k reason=\"key not found in DNS\";\n arc=none smtp.client-ip=63.250.43.88","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=rexion.ai;\n\ts=spacemail; t=1777573571;\n\tbh=tq9jLvGxcCHzQiNF7PIsLncsroNls5TdwyWf8VNvfHA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=iCc8hK9kBpcsuU+8KWElc+BIxDQopM1oB1hXU70FPdacdlzueVsHQYtTy0Mysm4jU\n\t RkmISs9xNYGt8ceGTZ5q4n8EigCo78PS2aA7xnm6YEVOXdJHEtjn+hxOTj2XbXxudv\n\t HjXoGihG23TpEfSKJt2ekNyA6X6f+kCqdMc9JP15M0nUeBldeO4aE7uu5Vk9q83wj2\n\t dykXPa5V99DOS/SGjxX3sKrspqAIhdRNo7/cqJiToYHRbzqsopVbjpSOW67hB597FV\n\t bNUt1QneiHkA4OWLyv1CFV4Vbko2BfxbwnHLpD4H+3rbayPwOX2evvK8tDhLH8bG4u\n\t 5qlRvI0IhNV6g==","From":"HACKE-RC ","To":"Pablo Neira Ayuso ,\n\tFlorian Westphal ","Cc":"Phil Sutter ,\n\t\"David S . Miller\" ,\n\tEric Dumazet ,\n\tJakub Kicinski ,\n\tPaolo Abeni ,\n\tSimon Horman ,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tHACKE-RC ","Subject":"[PATCH net-next v2 2/3] netfilter: nf_conntrack_irc: use\n nf_ct_helper_parse_port()","Date":"Thu, 30 Apr 2026 23:55:42 +0530","Message-ID":"<20260430182543.3931718-3-rc@rexion.ai>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260430182543.3931718-1-rc@rexion.ai>","References":"<20260430182543.3931718-1-rc@rexion.ai>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Envelope-From":"rc@rexion.ai"},"content":"Replace the bare simple_strtoul() call for port parsing with the\nshared nf_ct_helper_parse_port(). This avoids reliance on the\nnul-terminated string guarantee (currently provided by the newline\nscan earlier in parse_dcc) and validates the port fits in u16.\n\nThe simple_strtoul() for the IP address field is left as-is since\nit returns unsigned long for a __be32 conversion, which is a\nseparate concern.\n\nFixes: 869f37d8e48f (\"[NETFILTER]: nf_conntrack/nf_nat: add IRC helper port\")\nSigned-off-by: HACKE-RC \n---\n net/netfilter/nf_conntrack_irc.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/net/netfilter/nf_conntrack_irc.c b/net/netfilter/nf_conntrack_irc.c\nindex 522183b9a..1b51f5a6a 100644\n--- a/net/netfilter/nf_conntrack_irc.c\n+++ b/net/netfilter/nf_conntrack_irc.c\n@@ -93,7 +93,9 @@ static int parse_dcc(char *data, const char *data_end, __be32 *ip,\n \t\tdata++;\n \t}\n \n-\t*port = simple_strtoul(data, &data, 10);\n+\tif (nf_ct_helper_parse_port(data, data_end - data, port, &data))\n+\t\treturn -1;\n+\n \t*ad_end_p = data;\n \n \treturn 0;\n","prefixes":["net-next","v2","2/3"]}