{"id":2231445,"url":"http://patchwork.ozlabs.org/api/patches/2231445/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430172204.1006673-34-pbonzini@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430172204.1006673-34-pbonzini@redhat.com>","list_archive_url":null,"date":"2026-04-30T17:21:39","name":"[PULL,33/58] whpx: i386: IO port fast path cleanup","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"31475a5ad9d98230a9d0aa6d0b833df4a17e1e62","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/?format=json","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430172204.1006673-34-pbonzini@redhat.com/mbox/","series":[{"id":502347,"url":"http://patchwork.ozlabs.org/api/series/502347/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502347","date":"2026-04-30T17:21:16","name":"[PULL,01/58] pythondeps: bump to meson 1.11.1","version":1,"mbox":"http://patchwork.ozlabs.org/series/502347/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231445/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231445/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Orxt5E0V;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=dX6hzX9r;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g61P444RZz1yK1\n\tfor ; Fri, 01 May 2026 03:28:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIV7d-0006dQ-1l; Thu, 30 Apr 2026 13:24:21 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIV7E-0005kc-GB\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 13:24:02 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIV7C-0004jx-Nd\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 13:23:56 -0400","from mail-qv1-f71.google.com (mail-qv1-f71.google.com\n [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-605-FrJr5b_RPl2q-W4NyFZtRw-1; Thu, 30 Apr 2026 13:23:52 -0400","by mail-qv1-f71.google.com with SMTP id\n 6a1803df08f44-8acb85a973cso18028496d6.3\n for ; Thu, 30 Apr 2026 10:23:52 -0700 (PDT)","from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b3ff301dd3sm23226086d6.7.2026.04.30.10.23.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 10:23:49 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777569834;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=rdbdDUV8SBoKHBzZeDrdnJov3VN1o5NNOvVbJYBGDCI=;\n b=Orxt5E0V93SUAswGot5VY0gVfp6ZNdn3T8MGz2E7G+fQOPgI8/YFdLc9hL9/JQXxraM0pi\n 3ybe0qKd/vd07QiychrT4u8dReM6zLpqHOCuwrel/FviC/z57zY1pl6Q/+I88xctEDi/Uf\n RCmXJXuYg9VJYb7/vAIb5o8cHrFESUA=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777569831; x=1778174631; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rdbdDUV8SBoKHBzZeDrdnJov3VN1o5NNOvVbJYBGDCI=;\n b=dX6hzX9rz/QQ8HS8mbN6+3fMX07bmEN/mmvxJFRBAilyh5yqaOY8CD+quPX5Ay2BK3\n dKjven47CPOcjk2ZDGvVIVdAD6W89Vqf2Z0SyR2YASLhPSK6Yq/7wPT/YkvPYGcBOkRt\n Gs7WLPvUpAwCfPfYkmylL83+BhpQMSRCvKCqwv7EUIBfmxTichZ5MhmwLnre6y4pczTy\n oup+rJZX02f2KLppgUTNg+irWNfyq5CBa0hLAwT4OEmZgoHtrud/6ma7xrxbQQe0MeBJ\n 7JaF3xHOl7Kur+jcb0nSQfBv8vh3ux3XNRfAZRokIV7xhS7YERaeVEnug5IGl5DP9LZb\n gnsw=="],"X-MC-Unique":"FrJr5b_RPl2q-W4NyFZtRw-1","X-Mimecast-MFC-AGG-ID":"FrJr5b_RPl2q-W4NyFZtRw_1777569832","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777569831; x=1778174631;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=rdbdDUV8SBoKHBzZeDrdnJov3VN1o5NNOvVbJYBGDCI=;\n b=DNhSzoJwX+2kxbXl0alddNUTVnMIDgXE7XJBWZoSAicIx3lS4LoBT7zDCeu8JF3yoz\n tLCuydjhkna8RFBTLLGbLG8+Nwu7WIuxS5B2QxcSBvqx+Wrsi9TTdkPvPCODVtfc7o2O\n 3bji2puikmhEVYv0IMgoVSIHEiiGfQ6zgMTxJpZjGF+o6R+WweQMJDwL+myMdJDhUDlc\n z/X8274mHmzPcIUSsM2UIkf+UWKpFQ1gE4Wu59EvSzEztW4xCsLzQ0SUKigY4gI0sRJz\n o5Mei261DGxjVUlMzjTRD4aBpzCcYyU0NtG5UMVdVZDXqJA4faRR3bUW3/m8MRm8Prsx\n IqXQ==","X-Gm-Message-State":"AOJu0Yzi3GiUxsuEsU8ideFkW5mWiNEHNACPL7yCEnoBG2mXv9aO4j9O\n zJ807PS2s88q+zC5LEOY0mHrHW5yV4PjFN0MnYbyW2YZo7ec1SjWYhZ6YhIll1wLBtkcyK3Cp2i\n eRSHio2PI4z/DC3x4HJ/o3G1rIIA3DGhAtJmI7r9aA0WHpTI+mQYa+TlpGdm77hFmsEXPznMmrf\n cZ+YMvTmX62m8xxs/wL4vzCwaPFqDhISDVVEHyw1Ku","X-Gm-Gg":"AeBDietKdEVqw3ySha/QbH+hQQ/WgiOTnbqDK2W9VB3npwfktqhllxf+x2s0ySQ7Ret\n SNXFHnWSfg/s/g939Rdzs03iWdSHrrib7qlEWarstAWSucvcIOzcayk0B1/HDNya4bs6fzj2k2N\n e3WJMvUUEpLISbbZKVLWIzF/q2GQX5uieNW/9zPTdhFN4cTRhbpC99eDe2BkiInrcDMlPcru2gP\n bR+/3IxWq0VBqpa2RtD6bRc7+83RNuo0dGwbqNjDB1w9hEQ+x/jqdZkbcGIIjZGGZd6ZhffdryL\n 2gLPFO/HeLYm4pp4b2l9IVywholbdPzxiTBZFJtjNLk7AQhmtLtox3R8BMunCNDiJWLL3bjsGZr\n yzexzdGofSAPkwB8B6YV8katD6eiViVJOSsGS0s+HjznVi6S2IOz/zGjZeRQ5AEoOSMbaJKU77n\n AbGVy18mBfZSmM20rywpCvtlVHTG2Shn5QuLQ=","X-Received":["by 2002:a05:6214:4e81:b0:8b3:f5ab:baea with SMTP id\n 6a1803df08f44-8b3fe7e383fmr56142296d6.39.1777569831158;\n Thu, 30 Apr 2026 10:23:51 -0700 (PDT)","by 2002:a05:6214:4e81:b0:8b3:f5ab:baea with SMTP id\n 6a1803df08f44-8b3fe7e383fmr56141406d6.39.1777569830347;\n Thu, 30 Apr 2026 10:23:50 -0700 (PDT)"],"From":"Paolo Bonzini ","To":"qemu-devel@nongnu.org","Cc":"Mohamed Mediouni ","Subject":"[PULL 33/58] whpx: i386: IO port fast path cleanup","Date":"Thu, 30 Apr 2026 19:21:39 +0200","Message-ID":"<20260430172204.1006673-34-pbonzini@redhat.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260430172204.1006673-1-pbonzini@redhat.com>","References":"<20260430172204.1006673-1-pbonzini@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Mohamed Mediouni \n\nvmport calls synchronise_state within an I/O port read.\nSupport that properly.\n\nWhat was there before worked because of a side effect of\nwhpx_get_reg synchronising context if cpu->vcpu_dirty.\n\nRemove that whpx_get_reg call in whpx_bump_rip too as it's no longer\nneeded now.\n\nSigned-off-by: Mohamed Mediouni \nLink: https://lore.kernel.org/r/20260422214225.2242-12-mohamed@unpredictable.fr\nSigned-off-by: Paolo Bonzini \n---\n target/i386/whpx/whpx-all.c | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)","diff":"diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex ab8e97787fe..75f0f062d44 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -881,7 +881,6 @@ static void handle_io(CPUState *env, uint16_t port, void *buffer,\n static void whpx_bump_rip(CPUState *cpu, WHV_RUN_VP_EXIT_CONTEXT *exit_ctx)\n {\n WHV_REGISTER_VALUE reg;\n- whpx_get_reg(cpu, WHvX64RegisterRip, ®);\n reg.Reg64 = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n whpx_set_reg(cpu, WHvX64RegisterRip, reg);\n }\n@@ -909,13 +908,23 @@ static int whpx_handle_portio(CPUState *cpu,\n } else {\n reg.Reg64 = (uint64_t)val;\n }\n- whpx_bump_rip(cpu, exit_ctx);\n- whpx_set_reg(cpu, WHvX64RegisterRax, reg);\n+ /* vmport calls cpu_synchronize_state on an I/O port read */\n+ if (!cpu->vcpu_dirty) {\n+ whpx_bump_rip(cpu, exit_ctx);\n+ whpx_set_reg(cpu, WHvX64RegisterRax, reg);\n+ } else {\n+ env->eip = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n+ env->regs[R_EAX] = reg.Reg64;\n+ }\n return 0;\n } else if (!ctx->AccessInfo.StringOp && ctx->AccessInfo.IsWrite) {\n RAX(env) = ctx->Rax;\n handle_io(cpu, ctx->PortNumber, &RAX(env), 1, ctx->AccessInfo.AccessSize, 1);\n- whpx_bump_rip(cpu, exit_ctx);\n+ if (!cpu->vcpu_dirty) {\n+ whpx_bump_rip(cpu, exit_ctx);\n+ } else {\n+ env->eip = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n+ }\n return 0;\n }\n \n","prefixes":["PULL","33/58"]}