{"id":2231414,"url":"http://patchwork.ozlabs.org/api/patches/2231414/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430172204.1006673-5-pbonzini@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430172204.1006673-5-pbonzini@redhat.com>","list_archive_url":null,"date":"2026-04-30T17:21:10","name":"[PULL,04/58] tests: add test for json-streamer.c error recovery","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"11b91166ce7ec60745f5f11dbd47bdd0c4b5961b","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/?format=json","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430172204.1006673-5-pbonzini@redhat.com/mbox/","series":[{"id":502347,"url":"http://patchwork.ozlabs.org/api/series/502347/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502347","date":"2026-04-30T17:21:16","name":"[PULL,01/58] pythondeps: bump to meson 1.11.1","version":1,"mbox":"http://patchwork.ozlabs.org/series/502347/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231414/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231414/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=EaA3j6Le;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=PSlEM6y/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g61Hj1pGwz1xqf\n\tfor ; Fri, 01 May 2026 03:24:17 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIV60-0004cf-BW; Thu, 30 Apr 2026 13:22:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIV5t-0004am-Ud\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 13:22:35 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIV5n-0004B9-Tr\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 13:22:31 -0400","from mail-qv1-f71.google.com (mail-qv1-f71.google.com\n [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-196-BAUcWOvbMPKeeaE9IaWIjw-1; Thu, 30 Apr 2026 13:22:25 -0400","by mail-qv1-f71.google.com with SMTP id\n 6a1803df08f44-8b1f4478ca7so32593706d6.3\n for ; Thu, 30 Apr 2026 10:22:25 -0700 (PDT)","from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b3ff301ba6sm23813886d6.1.2026.04.30.10.22.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 10:22:21 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777569746;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=+uGb0wizViXSjvbg5PQVLkxmFWS6aEyQNVK65+EI6LU=;\n b=EaA3j6LevpbbDRtDrmKBULWd1QGEvo7QV7+Ub0pm8oeay8yTYUnOwG+JhMPOO2OHUtrIrA\n TrI1KAEsw51GU5/zssmJju3qP8VUEO7xKa6BXxv1L08B8MvVOl6b37f0KPcz1DsjTJtqin\n khikV/N3xNDZVTcL7iCIJl4/q2RGFaM=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777569744; x=1778174544; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=+uGb0wizViXSjvbg5PQVLkxmFWS6aEyQNVK65+EI6LU=;\n b=PSlEM6y/gqTLbyRtnPaJU1BRwuSF1h94M6C71ewGk02jAJJR3o095YkKpRpf5DoOd5\n iQhPy+TIfrFcvdUiVR4iS8giQl4fSV/SLza50MCcT8cCvLYYAceGmHDvphMxbUfDz6JA\n DJ3Vnf0ri57metzG/+4GTSLTcNUwPxOG2wakS9u2khuwDUYEYQXKqrUVBRPj1ylIssJS\n 21muAa9ekK+MCO0uNx/zHOgb0oZdjm3qSefscqstfQvkAHUIvLG0c5H5LgjH5QDln86e\n wFGhYClNBZy7uU13Z4yKRWvEOmhSjw51fgpATM6ZN1o2ZVoQCpQ/w7845KAk1+81CPqP\n QPPA=="],"X-MC-Unique":"BAUcWOvbMPKeeaE9IaWIjw-1","X-Mimecast-MFC-AGG-ID":"BAUcWOvbMPKeeaE9IaWIjw_1777569745","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777569744; x=1778174544;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=+uGb0wizViXSjvbg5PQVLkxmFWS6aEyQNVK65+EI6LU=;\n b=CVQpFbbegDcIqm7gV5hBS5qU/FLQGOhSxmrfsSLUJx4n+362VMWl2c2nlsmYQkWuOd\n l+u7DNHtoNHF9lUDwpB3X/tJvsRLN4J52bi5bzhON2h4sC8OAwcFPhKVtI95Wr1ETOs2\n 6ES0IQkkO4D2YKaLwxoNOz26SSkEPolsJUvsP8cb8MhuyylApwWq3wjiafDk7XR0UGqH\n c1DJMkkGwxMrgHsD0JzgvNfJu2XoaDa9PEOuyxAxVnzLbOL2nsoyk00WANUbgx1bFhBz\n ydM3p1/5m+5Qc1/PjXt4Jg5nIP1qQywrd949GgFvGWFYbFzwWQsb1RqGM5RPAmR/2oaQ\n 95sA==","X-Gm-Message-State":"AOJu0YxYMsq8vItNobo43NSORbZap2+WkeQ+x/2okojaIIY/ABNkC8WQ\n 56FeZK19LI3KSWMNUCvKL2gUGChhZfOKp9NBrKoKe89RNf2BrVGPdWtVMxDGAjwav19JTjTcTif\n nGhyPtUMUy4JU9N1OPHunSADX4GGVOoBtcrVRHWdmFcv6aMGdwwTBWAm5/sgztkIlVSY9dJPyQx\n LhI6KqxcXzTibLl2UA/c3u7Y7X4p8I+dnWIZ47lilq","X-Gm-Gg":"AeBDieuaVWsA/DVzFL7D1wkia8Co3KOJNUfE7kWKk026GcKxoSrjD3tU2Hs8/A/85E+\n s5qrhQuilN8u0uBDZ3BuamE6aeL30kX7vFPD3g8RLK9SARcV+N5GU1jvpS4ZFYqQFL5ZUS4CEfj\n MRHyNDQODPYK2NSfC9BGRnQ7AMv1i3UfiRALAgRwW8DJiqZkzZaWsuEkK57lfLf/LoQ5aZfpDda\n J+EGjR1j7/F6eU2Iz8/Zor0PJikpVb80Q//zIBrEsA44VE5u823+JsbjdIf7vaNMF98N/yl2BDY\n vA7BDJNwoIxP9XdX98peWeS/QNMxswVqoMCxHuvLVqRKNU7LO5t9D9+hOUC3V6lX8HJp+tZqRQf\n CcJG8+ZEt86h8tl/W62gS1AX0ncZeWg9PjQQN6nzDiGzBsS/s81BzSrYqhl6WxN1/8sjEpBcGk3\n +G5hjTvhytwcus20h7TPVMNZ7qQZmvqkyorTQ=","X-Received":["by 2002:a05:6214:c4d:b0:8b3:f58e:9a9 with SMTP id\n 6a1803df08f44-8b3fe6e583dmr59270516d6.4.1777569743731;\n Thu, 30 Apr 2026 10:22:23 -0700 (PDT)","by 2002:a05:6214:c4d:b0:8b3:f58e:9a9 with SMTP id\n 6a1803df08f44-8b3fe6e583dmr59269716d6.4.1777569743130;\n Thu, 30 Apr 2026 10:22:23 -0700 (PDT)"],"From":"Paolo Bonzini ","To":"qemu-devel@nongnu.org","Cc":"Markus Armbruster ","Subject":"[PULL 04/58] tests: add test for json-streamer.c error recovery","Date":"Thu, 30 Apr 2026 19:21:10 +0200","Message-ID":"<20260430172204.1006673-5-pbonzini@redhat.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260430172204.1006673-1-pbonzini@redhat.com>","References":"<20260430172204.1006673-1-pbonzini@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Before rewriting the error recovery code to work in a push parsing\nsetup, make sure that we have tests for it.\n\nCover various cases of invalid JSON, to check that structural\nrecovery based on balanced brackets and braces works; and\nlexer-based recovery which documents \"\\f\" as a sure fire\nway to reset the lexer.\n\nReviewed-by: Markus Armbruster \nSigned-off-by: Paolo Bonzini \n---\n tests/unit/check-json-parser.c | 159 +++++++++++++++++++++++++++++++++\n tests/unit/meson.build | 1 +\n 2 files changed, 160 insertions(+)\n create mode 100644 tests/unit/check-json-parser.c","diff":"diff --git a/tests/unit/check-json-parser.c b/tests/unit/check-json-parser.c\nnew file mode 100644\nindex 00000000000..656a4752470\n--- /dev/null\n+++ b/tests/unit/check-json-parser.c\n@@ -0,0 +1,159 @@\n+/*\n+ * Unit tests for JSON Parser error recovery\n+ *\n+ * Copyright 2026 Red Hat\n+ * Author: Paolo Bonzini \n+ *\n+ * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.\n+ * See the COPYING.LIB file in the top-level directory.\n+ */\n+\n+/*\n+ * Missing tests:\n+ * - multiple JSON values in a single stream\n+ * - multiple invocations of json_message_parser_feed()\n+ * (does not really matter much because of how\n+ * json_lexer_feed() is implemented)\n+ * - most JSON types are only covered by check-json.c.\n+ */\n+\n+#include \"qemu/osdep.h\"\n+\n+#include \"qapi/error.h\"\n+#include \"qobject/qbool.h\"\n+#include \"qobject/json-parser.h\"\n+\n+typedef struct ParseResult {\n+ int errors;\n+ QObject *result;\n+} ParseResult;\n+\n+static void parse_emit(void *opaque, QObject *json, Error *err)\n+{\n+ ParseResult *r = opaque;\n+\n+ g_assert_cmpint(!json, !=, !err);\n+ if (err) {\n+ r->errors++;\n+ error_free(err);\n+ } else {\n+ g_assert_null(r->result);\n+ r->result = json;\n+ }\n+}\n+\n+static ParseResult do_parse(const char *input)\n+{\n+ ParseResult r = { 0, NULL };\n+ JSONMessageParser parser;\n+\n+ json_message_parser_init(&parser, parse_emit, &r, NULL);\n+ json_message_parser_feed(&parser, input, strlen(input));\n+ json_message_parser_flush(&parser);\n+ json_message_parser_destroy(&parser);\n+ return r;\n+}\n+\n+static void check_result(const char *input, int expected_errors,\n+ QType expected_type)\n+{\n+ ParseResult r = do_parse(input);\n+\n+ g_assert_cmpint(r.errors, ==, expected_errors);\n+ g_assert_nonnull(r.result);\n+ g_assert_cmpint(qobject_type(r.result), ==, expected_type);\n+ qobject_unref(r.result);\n+}\n+\n+static void check_result_error(const char *input, int expected_errors)\n+{\n+ ParseResult r = do_parse(input);\n+\n+ g_assert_cmpint(r.errors, ==, expected_errors);\n+ g_assert_null(r.result);\n+}\n+\n+static void test_simple(void)\n+{\n+ check_result(\"false\", 0, QTYPE_QBOOL);\n+}\n+\n+static void test_whitespace(void)\n+{\n+ check_result(\" false\", 0, QTYPE_QBOOL);\n+}\n+\n+static void test_extra_closing_braces(void)\n+{\n+ check_result(\"}}false\", 2, QTYPE_QBOOL);\n+}\n+\n+static void test_bad_dict(void)\n+{\n+ check_result(\"{ 'abc' }false\", 1, QTYPE_QBOOL);\n+}\n+\n+static void test_trailing_comma(void)\n+{\n+ check_result(\"[ 'abc', ]false\", 1, QTYPE_QBOOL);\n+}\n+\n+static void test_lexer_recovery(void)\n+{\n+ check_result(\"\\f{}\", 1, QTYPE_QDICT);\n+ check_result(\"\\f[]\", 1, QTYPE_QLIST);\n+ check_result(\"\\f:false\", 2, QTYPE_QBOOL);\n+ check_result(\"\\f,false\", 2, QTYPE_QBOOL);\n+\n+ /*\n+ * Alphabetic characters do not start a new parsing. This is\n+ * slightly weird but it keeps the lexer simple and works well for\n+ * QMP (where valid input is a sequence of dictionaries).\n+ */\n+ check_result_error(\"\\ffalse\", 1);\n+ check_result_error(\"\\f'str'\", 1);\n+ check_result_error(\"\\f\\\"str\\\"\", 1);\n+}\n+\n+static void test_lexer_recovery_nested(void)\n+{\n+ check_result(\"{[{\\f{}\", 1, QTYPE_QDICT);\n+ check_result(\"{[{\\f[]\", 1, QTYPE_QLIST);\n+ check_result(\"{[{\\f:false\", 2, QTYPE_QBOOL);\n+ check_result(\"{[{\\f,false\", 2, QTYPE_QBOOL);\n+\n+ /*\n+ * As in test_lexer_recovery, these do not produce a successful\n+ * parse after \\f.\n+ */\n+ check_result_error(\"{[{\\ffalse\", 1);\n+ check_result_error(\"{[{\\f'str'\", 1);\n+ check_result_error(\"{[{\\f\\\"str\\\"\", 1);\n+}\n+\n+static void test_nested(void)\n+{\n+ check_result(\"[{'a']}false\", 1, QTYPE_QBOOL);\n+}\n+\n+static void test_nested_multiple(void)\n+{\n+ check_result(\"[{'a']}[{'a']}false\", 2, QTYPE_QBOOL);\n+}\n+\n+int main(int argc, char **argv)\n+{\n+ g_test_init(&argc, &argv, NULL);\n+\n+ g_test_add_func(\"/json-parser/simple\", test_simple);\n+ g_test_add_func(\"/json-parser/whitespace\", test_whitespace);\n+ g_test_add_func(\"/json-parser/error-recovery/extra-closing-braces\", test_extra_closing_braces);\n+ g_test_add_func(\"/json-parser/error-recovery/bad-dict\", test_bad_dict);\n+ g_test_add_func(\"/json-parser/error-recovery/trailing-comma\", test_trailing_comma);\n+ g_test_add_func(\"/json-parser/error-recovery/lexer\", test_lexer_recovery);\n+ g_test_add_func(\"/json-parser/error-recovery/lexer/nested\", test_lexer_recovery_nested);\n+ g_test_add_func(\"/json-parser/error-recovery/nested\", test_nested);\n+ g_test_add_func(\"/json-parser/error-recovery/nested/multiple\", test_nested_multiple);\n+\n+ return g_test_run();\n+}\ndiff --git a/tests/unit/meson.build b/tests/unit/meson.build\nindex 41e8b06c339..03d36748c73 100644\n--- a/tests/unit/meson.build\n+++ b/tests/unit/meson.build\n@@ -10,6 +10,7 @@ tests = {\n 'check-qnull': [],\n 'check-qobject': [],\n 'check-qjson': [],\n+ 'check-json-parser': [],\n 'check-qlit': [],\n 'test-error-report': [],\n 'test-qobject-output-visitor': [testqapi],\n","prefixes":["PULL","04/58"]}