{"id":2231409,"url":"http://patchwork.ozlabs.org/api/patches/2231409/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430172204.1006673-9-pbonzini@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430172204.1006673-9-pbonzini@redhat.com>","list_archive_url":null,"date":"2026-04-30T17:21:14","name":"[PULL,08/58] minikconf: small cleanups and dead code removal","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"825ee0b257199bb9b613c22ff197ee125fdf66b4","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/?format=json","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430172204.1006673-9-pbonzini@redhat.com/mbox/","series":[{"id":502347,"url":"http://patchwork.ozlabs.org/api/series/502347/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502347","date":"2026-04-30T17:21:16","name":"[PULL,01/58] pythondeps: bump to meson 1.11.1","version":1,"mbox":"http://patchwork.ozlabs.org/series/502347/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231409/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231409/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KY/2RjJ+;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=oPFXLr4p;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g61Gb4TVtz1xqf\n\tfor ; Fri, 01 May 2026 03:23:14 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIV65-0004er-0C; Thu, 30 Apr 2026 13:22:45 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIV62-0004dr-3v\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 13:22:42 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIV60-0004Et-Hk\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 13:22:41 -0400","from mail-qv1-f72.google.com (mail-qv1-f72.google.com\n [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-637-i1o91YZ_PQGYHFFf_lh9yg-1; Thu, 30 Apr 2026 13:22:38 -0400","by mail-qv1-f72.google.com with SMTP id\n 6a1803df08f44-8acb26fbbb2so19343626d6.2\n for ; Thu, 30 Apr 2026 10:22:38 -0700 (PDT)","from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b3ff335ccdsm22777456d6.20.2026.04.30.10.22.34\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 10:22:35 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777569759;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=H1c1ijwUc7ufXMrkyywVeD81tZX1EKRChOVW214SFpU=;\n b=KY/2RjJ+4hHiMQFJ+VGI/6fV/tqmv1RQQUJNtVSIHfWpummkA2IrKb7P/THlCu32GXic8F\n arnDNZ2K7JL0EQ/YPrMP4MPlnQKXmBYpNCxrrK7D3TxVZ8sF/sT4+qw6fPHShL3iKjSWy/\n i3VZboN3igUFJoRSGMS+h5VB+HehKbg=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777569757; x=1778174557; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=H1c1ijwUc7ufXMrkyywVeD81tZX1EKRChOVW214SFpU=;\n b=oPFXLr4p8aUiNOmZ1ooiYTUxVnJA+q90KHAK18XQVqVMMdzIeTeZ7eMS5VGKMzMvTP\n 0Te3vuvQ0dV0XyIBcFArHmdlh1mD7qT/GsqHAgIGfEXLplwyOs2lq07rHtulyu/01t3j\n S6cfcXBDCk77uh+MTnsdmmwExMMtHJBdAl5VpcP5vwnZ0n2f6x3xhTK1ke5P0ClXEB99\n dIT7sPkBcZSPE4ZnRdzNixqhf1p0pXqeIWFWBxUe5fJuWz7AsuRFcFxYv+HBhlsxvw6w\n aaA496xS6AexFkVA91/VX5VWGko11KuVs+A6j5LNlqa+Y3NRyQskxILl1CaDLkrg8HIx\n 8ILQ=="],"X-MC-Unique":"i1o91YZ_PQGYHFFf_lh9yg-1","X-Mimecast-MFC-AGG-ID":"i1o91YZ_PQGYHFFf_lh9yg_1777569758","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777569757; x=1778174557;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=H1c1ijwUc7ufXMrkyywVeD81tZX1EKRChOVW214SFpU=;\n b=A6sf+/GSx+vOIGBqyRrP45pytC+vb0rXlfh3ZiolyrpKlkVanxT1sF9KRkpIkQw9eV\n RfP59nF1ClewL/Phtt9hSEbkRjZksLt1LNK5/SJJ9UGGNTBRRdgomxmw6DB52IIN1sOv\n VJc6a3TfJr0fTdmlEq5YHTVa7QtUeg7PfuUlrQun/aEmqS9EfVqn9GDJTGbswsws9PkV\n uTkVUUoCUtq4JJ+zicHvbwK4ZeCgD7uueWjAGvdFImtoKGQHdmR6fPrMUeXwK7xITlJE\n XnJOLKMRrnK39NjoZjS2GMelr4a45MdeNWbtdSaEIh1GwIgfPkMV8iG/0GRGF1b1tBqx\n wo6A==","X-Gm-Message-State":"AOJu0YxiYjFntP/ereaAIrKv6PIIfYY6j+Mp/A2awkJPOKKE5fLgw2iP\n 6tDNzyZxSgpsxI63OZZdk6Djxuvq5RuvJVLn0+W3oypnO2XvwKhzU+jUkfeZ6nsJXE20PSP2efl\n Qz9yKoJqZCPgtwFNbiUCFW/3YOZKu+JMIcIFYvgjKEbYx9wSFffhswcsXrappHIdVN4iPTbyuCp\n eUly9K1wAudZJP9m1kLxmdDRULnaEDvyyWIMkgDWzw","X-Gm-Gg":"AeBDieuMRcWBeqXgVK0q8+kYZRxn0cPHNt3/mWc+e/jO+AGjPQittjf54DJC0JPx+Zv\n sV+1jY+yiI214hEAqS/iIFPbGfMvFcfjiVoXPaOWksk5/+dN1+bsDstTIUhgplNIJXqwdv/ba2g\n yPTq1OX/YIGIJgsFjB6aDF4gfhmpyWccjH7EFkJPTcCMwyLFVg2uDBArTCCRZp6OSPlBTdB4yO+\n tVrHJYrDndCgNAot+hFQHX8Al03r/Hp+MJRDBEIsGP5kM4tTjp3OlwVuiVtwMLFn099TlNSwl05\n EOnV7loIuCxXRS2SECbxMVkyioTWVl1wIWMsPS0IMsWQW6uZnKCSG/78vf2GokOUYeXaQjxZJQs\n k0Jcqs/W6fqSwm5lw22oYqzJA05ShxAYgfkngD7LULKEjFOCre55IDWapKoi7ppPuXKUJh/xsEV\n rxUI7pgZCtiikc/VftLVydWUvwqp/xBfvqgt0=","X-Received":["by 2002:a05:6214:e66:b0:8ac:a914:c2da with SMTP id\n 6a1803df08f44-8b3fe6e666emr58369636d6.2.1777569756903;\n Thu, 30 Apr 2026 10:22:36 -0700 (PDT)","by 2002:a05:6214:e66:b0:8ac:a914:c2da with SMTP id\n 6a1803df08f44-8b3fe6e666emr58368616d6.2.1777569756130;\n Thu, 30 Apr 2026 10:22:36 -0700 (PDT)"],"From":"Paolo Bonzini ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Subject":"[PULL 08/58] minikconf: small cleanups and dead code removal","Date":"Thu, 30 Apr 2026 19:21:14 +0200","Message-ID":"<20260430172204.1006673-9-pbonzini@redhat.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260430172204.1006673-1-pbonzini@redhat.com>","References":"<20260430172204.1006673-1-pbonzini@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Reviewed-by: Marc-André Lureau \nSigned-off-by: Paolo Bonzini \n---\n scripts/minikconf.py | 21 ++++++++++-----------\n 1 file changed, 10 insertions(+), 11 deletions(-)","diff":"diff --git a/scripts/minikconf.py b/scripts/minikconf.py\nindex 24389763db0..08df8d5dabb 100644\n--- a/scripts/minikconf.py\n+++ b/scripts/minikconf.py\n@@ -108,7 +108,7 @@ def __str__(self):\n return self.name\n \n def has_value(self):\n- return not (self.value is None)\n+ return self.value is not None\n def set_value(self, val, clause):\n self.clauses_for_var.append(clause)\n if self.has_value() and self.value != val:\n@@ -158,7 +158,7 @@ def __init__(self, dest, value, cond=None):\n KconfigData.Clause.__init__(self, dest)\n self.value = value\n self.cond = cond\n- if not (self.cond is None):\n+ if self.cond is not None:\n self.cond.add_edges_to(self.dest)\n def __str__(self):\n value = 'y' if self.value else 'n'\n@@ -212,7 +212,7 @@ def __init__(self, value_mangler=defconfig):\n def check_undefined(self):\n undef = False\n for i in self.referenced_vars:\n- if not (i in self.defined_vars):\n+ if i not in self.defined_vars:\n print(\"undefined symbol %s\" % (i), file=sys.stderr)\n undef = True\n return undef\n@@ -220,7 +220,6 @@ def check_undefined(self):\n def compute_config(self):\n if self.check_undefined():\n raise KconfigDataError(\"there were undefined symbols\")\n- return None\n \n debug_print(\"Input:\")\n for clause in self.clauses:\n@@ -270,7 +269,7 @@ def do_declaration(self, var):\n \n # var is a string with the variable's name.\n def do_var(self, var):\n- if (var in self.referenced_vars):\n+ if var in self.referenced_vars:\n return self.referenced_vars[var]\n \n var_obj = self.referenced_vars[var] = KconfigData.Var(var)\n@@ -339,9 +338,9 @@ def __str__(self):\n class KconfigParser:\n \n @classmethod\n- def parse(self, fp, mode=None):\n+ def parse(cls, fp, mode=None):\n data = KconfigData(mode or defconfig)\n- parser = KconfigParser(data)\n+ parser = cls(data)\n parser.parse_file(fp)\n return data\n \n@@ -352,9 +351,10 @@ def parse_file(self, fp):\n self.abs_fname = os.path.abspath(fp.name)\n self.fname = fp.name\n self.data.previously_included.append(self.abs_fname)\n- self.src = fp.read()\n- if self.src == '' or self.src[-1] != '\\n':\n- self.src += '\\n'\n+ src = fp.read()\n+ if src == '' or src[-1] != '\\n':\n+ src += '\\n'\n+ self.src = src\n self.cursor = 0\n self.line = 1\n self.line_pos = 0\n@@ -534,7 +534,6 @@ def parse_property(self, var):\n # properties: properties property\n # | /* empty */\n def parse_properties(self, var):\n- had_default = False\n while self.tok == TOK_DEFAULT or self.tok == TOK_DEPENDS or \\\n self.tok == TOK_SELECT or self.tok == TOK_BOOL or \\\n self.tok == TOK_IMPLY:\n","prefixes":["PULL","08/58"]}