{"id":2231407,"url":"http://patchwork.ozlabs.org/api/patches/2231407/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430172204.1006673-11-pbonzini@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430172204.1006673-11-pbonzini@redhat.com>","list_archive_url":null,"date":"2026-04-30T17:21:16","name":"[PULL,10/58] minikconf: fix type mismatch in do_declaration","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"edae488ea47a8c733a4f0538b8693c24638d4383","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/?format=json","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430172204.1006673-11-pbonzini@redhat.com/mbox/","series":[{"id":502347,"url":"http://patchwork.ozlabs.org/api/series/502347/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502347","date":"2026-04-30T17:21:16","name":"[PULL,01/58] pythondeps: bump to meson 1.11.1","version":1,"mbox":"http://patchwork.ozlabs.org/series/502347/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231407/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231407/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=U7NbaLLo;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=Y8Mk6CUB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g61GZ3p2Rz1xqf\n\tfor ; Fri, 01 May 2026 03:23:15 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIV69-0004gX-S0; Thu, 30 Apr 2026 13:22:49 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIV67-0004fy-DQ\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 13:22:47 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIV65-0004GS-VO\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 13:22:47 -0400","from mail-qt1-f198.google.com (mail-qt1-f198.google.com\n [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-329-dY1Mu_1mOsySOkMc1UEhvA-1; Thu, 30 Apr 2026 13:22:43 -0400","by mail-qt1-f198.google.com with SMTP id\n d75a77b69052e-50d812c898cso28614581cf.1\n for ; Thu, 30 Apr 2026 10:22:43 -0700 (PDT)","from [192.168.10.48] ([151.49.85.67])\n by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-5103d2f8080sm282451cf.17.2026.04.30.10.22.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 10:22:41 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777569765;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7sLEO/HdwvhM9eov1goIg+f1P573AH4+S4G4nVnNMjM=;\n b=U7NbaLLoMkgGMvyholvoQfhwZL8Q8MFcRMjnmG3t4+dJbosiSlyyM49WdJ+PExq/GldYq0\n nlaqhoEz2yj3Lnyequ1go0GlORrdw3p68DlBRhDnRd96he+o6nrEPo3ucA5pJ1NhVe5lh0\n 0QDr3smQYgGGtrSr2SDQuAD3TOlsIFM=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777569762; x=1778174562; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7sLEO/HdwvhM9eov1goIg+f1P573AH4+S4G4nVnNMjM=;\n b=Y8Mk6CUBrova1yO3dleamEo+o50h8uz+Kgp2g3HxXj0Jh1kJ9kZ6yBaD6cLPq6f9Ky\n mOxqlWjTyuMRbM82PDpaQVFUq9BJpupAVyUPMKx+hFtXEtl15Fx5thJu89VDiOWYJrE3\n ouRMrkJ0K06LXLN7h0NHV1XoPS+Odr97UnU/iBP5ABc2porBXTw4+r+oXmYo+3XBMGVN\n vUz4cuzrbLwBqzhUBiiKTq0WS9dfFEyJIjB9/pTIyMqPCD/tQA/HrX6Xz1drdSzIk7Nr\n ArqTVOVsLXPsVDtyiIiMm8gnYJqS7aqMDQHCF8Jz+b0Skapk89Yf8a274s41oXBKG/bL\n pf4w=="],"X-MC-Unique":"dY1Mu_1mOsySOkMc1UEhvA-1","X-Mimecast-MFC-AGG-ID":"dY1Mu_1mOsySOkMc1UEhvA_1777569763","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777569763; x=1778174563;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=7sLEO/HdwvhM9eov1goIg+f1P573AH4+S4G4nVnNMjM=;\n b=OvH13j0zyMUvfqozGUzU23fc4aO46xP4n5iySrAZ+b2jtT9LKiY1ZmHff+YMnj4yne\n huvc5eeymVw6yd+TRbj4AzJUHVAErmYYyCKuQ95NuSr24m4BuouxhAkvRnepXR1NRJ3j\n IrOaBGtOo3rtNeY5boRe6Us6wdkXZ4HsoJD5abHICdWXYeQpzfDisUmqtrAYxwU7UQic\n 1J7moVsHejYpJUGKDC//oUAo8fIas0PRhhkEdaUZx35Em9do/8AKB1XQVbDhMe0rxv5w\n ZNvX9m1DCNzRoyHl+MNkHOlYTW72BzcXa6Uym+PeoT65EYxh4STh3BNZU3d5XCsaldSu\n 0fNQ==","X-Gm-Message-State":"AOJu0Yxrz9jTzaAiP4TzyJnaZQXs4jJuFiXFEo3KWGC8saD1BUpKNtM3\n cZQzHXsNKC1vE8XHitEJAAIeQ5PAlTfBIM3vAXmhgQSs3C1wNykL10W5WgV8vl4NRD69I4U7pA1\n wP750If+8tl/ZwDa5rnYchiUCP5tLCWkYjy71yg0Z3YZ/G3dhPtBMS9BOJn+xscUhSq4bPGTwlZ\n rpoSiDug0fUnMpyF/EOyYoSdcBDHFxW+64z0FPAXKZ","X-Gm-Gg":"AeBDiesEb1qoJq0ueB+xw+1H977CsWFrMxYvMaoDDTvfVD/OS0/RmfsgATkOcfEV3A9\n piKtSjPCldVBDCEKcJje5Cvq/Qbsk8XntYuMdySAQbw6r1cX6C3kCsfBBNUg5PvRKKX86+SVafW\n qrRChxkbZA0l35dpZ1k2pXYDiy0XJcoYulkdJ+FjfKamwPppqvcBwyPl78BK5V8VOs2pdPfvAec\n aKxbc1oVyYusMF7ncBad/YwmgrUTQhVQDlH/PgP6pXz3kB4wDHkHqNf7U8aOgfCM8hqWcUHCJ0Q\n eCM4Q8WnidoAhQA3TRhObckfya/ffDjrh0LWgC/u4tz3TAJkiwlv6QniANpCYVpWNWEmx6eFbLb\n bpSKL1nXu4HK/Jmer18VvB3HyXFph5Owntqo66wDZMhI9yXghLm/GO+YkhBcjxVLLYWY3ewb//n\n Sy+DPf25u4TyTqOP2YzUHalAKwNWdx56oPSoc=","X-Received":["by 2002:a05:622a:a:b0:50f:b67c:a5fe with SMTP id\n d75a77b69052e-5102adf16d2mr53504121cf.48.1777569762619;\n Thu, 30 Apr 2026 10:22:42 -0700 (PDT)","by 2002:a05:622a:a:b0:50f:b67c:a5fe with SMTP id\n d75a77b69052e-5102adf16d2mr53503691cf.48.1777569762061;\n Thu, 30 Apr 2026 10:22:42 -0700 (PDT)"],"From":"Paolo Bonzini ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Subject":"[PULL 10/58] minikconf: fix type mismatch in do_declaration","Date":"Thu, 30 Apr 2026 19:21:16 +0200","Message-ID":"<20260430172204.1006673-11-pbonzini@redhat.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260430172204.1006673-1-pbonzini@redhat.com>","References":"<20260430172204.1006673-1-pbonzini@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The set stores strings, not Vars. Because of this the duplicate\ndefinition check did not work.\n\nReviewed-by: Marc-André Lureau \nSigned-off-by: Paolo Bonzini \n---\n scripts/minikconf.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/scripts/minikconf.py b/scripts/minikconf.py\nindex 668de577d09..2656d364920 100644\n--- a/scripts/minikconf.py\n+++ b/scripts/minikconf.py\n@@ -262,8 +262,8 @@ def visit_fn(var):\n # semantic actions -------------\n \n def do_declaration(self, var):\n- if (var in self.defined_vars):\n- raise KconfigDataError('variable \"' + var + '\" defined twice')\n+ if var.name in self.defined_vars:\n+ raise KconfigDataError('variable \"%s\" defined twice' % var.name)\n \n self.defined_vars.add(var.name)\n \n","prefixes":["PULL","10/58"]}