{"id":2231382,"url":"http://patchwork.ozlabs.org/api/patches/2231382/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260430162420.42839-13-18255117159@163.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430162420.42839-13-18255117159@163.com>","list_archive_url":null,"date":"2026-04-30T16:24:16","name":"[RESEND,12/16] PCI: tegra194: Use FIELD_MODIFY()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8382859f0714c11ea93dea2ee67330eb37611776","submitter":{"id":89937,"url":"http://patchwork.ozlabs.org/api/people/89937/?format=json","name":"Hans Zhang","email":"18255117159@163.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260430162420.42839-13-18255117159@163.com/mbox/","series":[{"id":502340,"url":"http://patchwork.ozlabs.org/api/series/502340/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=502340","date":"2026-04-30T16:24:06","name":"PCI: Use FIELD_MODIFY() to simplify bitfield operations","version":1,"mbox":"http://patchwork.ozlabs.org/series/502340/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231382/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231382/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=WO4IMcMT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-53515-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=\"WO4IMcMT\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=220.197.31.3","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=163.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g600j6GqDz1yHZ\n\tfor ; Fri, 01 May 2026 02:26:13 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 5C4393046F0F\n\tfor ; Thu, 30 Apr 2026 16:25:10 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id DFC5B47276E;\n\tThu, 30 Apr 2026 16:24:57 +0000 (UTC)","from m16.mail.163.com (m16.mail.163.com [220.197.31.3])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 559EC4657DA;\n\tThu, 30 Apr 2026 16:24:52 +0000 (UTC)","from zhb.. (unknown [])\n\tby gzga-smtp-mtada-g1-2 (Coremail) with SMTP id\n _____wA3Df0_gvNpcypXCg--.51103S6;\n\tFri, 01 May 2026 00:24:34 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777566297; cv=none;\n b=DHBEC3W87rOUCpN8WpMw4WhNkaHhkfoyveG/AyCVujbZWpbb+VsUrNF7qTp5dxlpz/hodCxZC2l0zJT6wKlNt0ZYccVx6TqumpmaF89YZso+CEzZWer1yuQIpkK1ap4pYprN+NbOc+ZNwtLNqYF0w06ebpof3/5l+CYtbmvG8eg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777566297; c=relaxed/simple;\n\tbh=LyXom0aI8oDNr/p2BhEGgEUfHTYWhiQHz9+4J4UuULk=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=hJLvd7U2RcAwAq5cCKPbG/XWzrfJiH8px35MjOZiyI8s5za7oxYSEeoh/A5+9lEtifQKfWH+zjxO+SurT+/MnLjwBlv+QxG+OMEUKtDhoAWjkdIeut90e/UjPUD9NYre6trwjozgBIcq+1plQysODGPkKWy6+Bc5sbM04y92fXk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com;\n spf=pass smtp.mailfrom=163.com;\n dkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=WO4IMcMT; arc=none smtp.client-ip=220.197.31.3","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=um\n\teHWMzUl4hSLDTxJcBfG2g3uyThkvisFMrecN3+PaA=; b=WO4IMcMTa9WnYBmaTn\n\tCqr8Ie7Y9j2+myzalTATRs2341UlSFTHtDj/tDedR/FQ3pPRvvrT5q9N4gFK4VOz\n\t9tSxX+91qq0ty3NtucJxbBNNNlM9X+wV+xH+nf6nf6DAAaTw/qg9YzHP40yfGhVM\n\tfTLejK4e/MRdJ+i7OMFJ0bOI4=","From":"Hans Zhang <18255117159@163.com>","To":"bhelgaas@google.com,\n\tlpieralisi@kernel.org,\n\tkwilczynski@kernel.org,\n\tmani@kernel.org,\n\tjingoohan1@gmail.com","Cc":"robh@kernel.org,\n\ts32@nxp.com,\n\tlinux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tHans Zhang <18255117159@163.com>","Subject":"[RESEND PATCH 12/16] PCI: tegra194: Use FIELD_MODIFY()","Date":"Fri, 1 May 2026 00:24:16 +0800","Message-Id":"<20260430162420.42839-13-18255117159@163.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260430162420.42839-1-18255117159@163.com>","References":"<20260430162420.42839-1-18255117159@163.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"_____wA3Df0_gvNpcypXCg--.51103S6","X-Coremail-Antispam":"1Uf129KBjvJXoW7urW7uF4xJF18JFy7XF1rXrb_yoW8Wry7pa\n\t47tw4FvF1DJF4YvF18Aa4DCr15Kr909ryUCwsxKw1Iva1kCr9Fg395ta4FgFn7AFZrtF45\n\tG3yvya47GF43ZrUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pRBpB-UUUUU=","X-CM-SenderInfo":"rpryjkyvrrlimvzbiqqrwthudrp/xtbC6wIIq2nzgkJELgAA36"},"content":"Use FIELD_MODIFY() to remove open-coded bit manipulation.\nNo functional change intended.\n\nSigned-off-by: Hans Zhang <18255117159@163.com>\n---\n drivers/pci/controller/dwc/pcie-tegra194.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c\nindex 9dcfa194050e..3c831331338e 100644\n--- a/drivers/pci/controller/dwc/pcie-tegra194.c\n+++ b/drivers/pci/controller/dwc/pcie-tegra194.c\n@@ -872,8 +872,7 @@ static void config_gen3_gen4_eq_presets(struct tegra_pcie_dw *pcie)\n \tdw_pcie_writel_dbi(pci, GEN3_RELATED_OFF, val);\n \n \tval = dw_pcie_readl_dbi(pci, GEN3_EQ_CONTROL_OFF);\n-\tval &= ~GEN3_EQ_CONTROL_OFF_PSET_REQ_VEC;\n-\tval |= FIELD_PREP(GEN3_EQ_CONTROL_OFF_PSET_REQ_VEC, 0x3ff);\n+\tFIELD_MODIFY(GEN3_EQ_CONTROL_OFF_PSET_REQ_VEC, &val, 0x3ff);\n \tval &= ~GEN3_EQ_CONTROL_OFF_FB_MODE;\n \tdw_pcie_writel_dbi(pci, GEN3_EQ_CONTROL_OFF, val);\n \n@@ -883,9 +882,8 @@ static void config_gen3_gen4_eq_presets(struct tegra_pcie_dw *pcie)\n \tdw_pcie_writel_dbi(pci, GEN3_RELATED_OFF, val);\n \n \tval = dw_pcie_readl_dbi(pci, GEN3_EQ_CONTROL_OFF);\n-\tval &= ~GEN3_EQ_CONTROL_OFF_PSET_REQ_VEC;\n-\tval |= FIELD_PREP(GEN3_EQ_CONTROL_OFF_PSET_REQ_VEC,\n-\t\t\t pcie->of_data->gen4_preset_vec);\n+\tFIELD_MODIFY(GEN3_EQ_CONTROL_OFF_PSET_REQ_VEC, &val,\n+\t\t pcie->of_data->gen4_preset_vec);\n \tval &= ~GEN3_EQ_CONTROL_OFF_FB_MODE;\n \tdw_pcie_writel_dbi(pci, GEN3_EQ_CONTROL_OFF, val);\n \n","prefixes":["RESEND","12/16"]}