{"id":2231363,"url":"http://patchwork.ozlabs.org/api/patches/2231363/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260430161254.40278-10-18255117159@163.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430161254.40278-10-18255117159@163.com>","list_archive_url":null,"date":"2026-04-30T16:12:47","name":"[09/16] PCI: al: Use FIELD_MODIFY()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"696284ef6f7ebdae9adcdad550daae80acafa95f","submitter":{"id":89937,"url":"http://patchwork.ozlabs.org/api/people/89937/?format=json","name":"Hans Zhang","email":"18255117159@163.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260430161254.40278-10-18255117159@163.com/mbox/","series":[{"id":502337,"url":"http://patchwork.ozlabs.org/api/series/502337/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=502337","date":"2026-04-30T16:12:44","name":"PCI: Use FIELD_MODIFY() to simplify bitfield operations","version":1,"mbox":"http://patchwork.ozlabs.org/series/502337/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231363/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231363/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=FfAhrNzc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-53503-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=\"FfAhrNzc\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=220.197.31.4","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=163.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5ztQ4Lb9z1xqf\n\tfor ; Fri, 01 May 2026 02:20:46 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 0B03F30A57D9\n\tfor ; Thu, 30 Apr 2026 16:14:46 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0F3B1478E34;\n\tThu, 30 Apr 2026 16:13:58 +0000 (UTC)","from m16.mail.163.com (m16.mail.163.com [220.197.31.4])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 817D347279B;\n\tThu, 30 Apr 2026 16:13:53 +0000 (UTC)","from zhb.. (unknown [])\n\tby gzga-smtp-mtada-g0-4 (Coremail) with SMTP id\n _____wDnbymkf_NpTNe+Cg--.31297S11;\n\tFri, 01 May 2026 00:13:30 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777565637; cv=none;\n b=s+r922hD6lUNlOvbkLVuy5EaCW2SVZAm6A/TxPQx5kl56GgB0wcLw4Vgvcuke2yVghc2xOmUiNj7xoLa4I+E/ZITfsxP0AtlQ+rr4iP/1bct7JFMA11LuWzndgZo7Q/6tSJADimdrU2XEQb0M56/fxx8F1Ax17FhqkpvkRpnTxU=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777565637; c=relaxed/simple;\n\tbh=Lofv0m2TVDTTvL1dhch4RPqqM1I+CGS49Izpi9Bn9Jw=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=L8cvfGOYFjyKPNhAb2ZiZEK/wrQxgAgHlg/MW+oOUg8iNTxqQH/nbzUKd2G2M4f2+R63M9cpioKhmfUsjCbnSSUyC4XZpj6Ae+2+dcpdMKuswjiJtagMk4XIImUkSvFM7k4QIBANVtAmnnKf2Kj/JXpwJ5bhpOkG+Zu/y5olGXo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com;\n spf=pass smtp.mailfrom=163.com;\n dkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=FfAhrNzc; arc=none smtp.client-ip=220.197.31.4","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=qd\n\t4cKyzmhIsbMqkW+nUXtTuM7vNhmRU2nO8tao3v4TY=; b=FfAhrNzcOtjoVjQTKl\n\tv7NziKjRXaA9pCXIHXIubmq5jC33sW0AAT8Hb+wgRpUJN6z/CKij9p05bEdE5/KW\n\tAclF/rxXWHgAaRLuilTWaLOZccqKYakOjpnKnOLG7xQD9LT4nFPDCW7btuGr/rqr\n\tpWpzjIUN+otmSylZ1aosELo24=","From":"Hans Zhang <18255117159@163.com>","To":"bhelgaas@google.com,\n\tlpieralisi@kernel.org,\n\tkwilczynski@kernel.org,\n\tmani@kernel.org,\n\tjingoohan1@gmail.com","Cc":"robh@kernel.org,\n\ts32@nxp.com,\n\tlinux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tHans Zhang <18255117159@163.com>","Subject":"[PATCH 09/16] PCI: al: Use FIELD_MODIFY()","Date":"Fri, 1 May 2026 00:12:47 +0800","Message-Id":"<20260430161254.40278-10-18255117159@163.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260430161254.40278-1-18255117159@163.com>","References":"<20260430161254.40278-1-18255117159@163.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"_____wDnbymkf_NpTNe+Cg--.31297S11","X-Coremail-Antispam":"1Uf129KBjvJXoW7urW7uF43ur13KryDArWUJwb_yoW8Xr47pr\n\tW5Ja1xJF18ta1Y9F48K3WkWF1YqFnFvFyDt39xGwna9a1Sy34DW3yFyasYqa47GFW8Zr15\n\ttw4Yv3WxGan3ZFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pRkOzsUUUUU=","X-CM-SenderInfo":"rpryjkyvrrlimvzbiqqrwthudrp/xtbC7AphBWnzf6r0TwAA32"},"content":"Use FIELD_MODIFY() to remove open-coded bit manipulation.\nNo functional change intended.\n\nSigned-off-by: Hans Zhang <18255117159@163.com>\n---\n drivers/pci/controller/dwc/pcie-al.c | 12 +++---------\n 1 file changed, 3 insertions(+), 9 deletions(-)","diff":"diff --git a/drivers/pci/controller/dwc/pcie-al.c b/drivers/pci/controller/dwc/pcie-al.c\nindex 345c281c74fe..ef8c8ce7c78c 100644\n--- a/drivers/pci/controller/dwc/pcie-al.c\n+++ b/drivers/pci/controller/dwc/pcie-al.c\n@@ -253,7 +253,6 @@ static int al_pcie_config_prepare(struct al_pcie *pcie)\n \tu8 subordinate_bus;\n \tu8 secondary_bus;\n \tu32 cfg_control;\n-\tu32 reg;\n \n \tft = resource_list_first_type(&pp->bridge->windows, IORESOURCE_BUS);\n \tif (!ft)\n@@ -285,14 +284,9 @@ static int al_pcie_config_prepare(struct al_pcie *pcie)\n \t\t\t CFG_CONTROL;\n \n \tcfg_control = al_pcie_controller_readl(pcie, cfg_control_offset);\n-\n-\treg = cfg_control &\n-\t ~(CFG_CONTROL_SEC_BUS_MASK | CFG_CONTROL_SUBBUS_MASK);\n-\n-\treg |= FIELD_PREP(CFG_CONTROL_SUBBUS_MASK, subordinate_bus) |\n-\t FIELD_PREP(CFG_CONTROL_SEC_BUS_MASK, secondary_bus);\n-\n-\tal_pcie_controller_writel(pcie, cfg_control_offset, reg);\n+\tFIELD_MODIFY(CFG_CONTROL_SUBBUS_MASK, &cfg_control, subordinate_bus);\n+\tFIELD_MODIFY(CFG_CONTROL_SEC_BUS_MASK, &cfg_control, secondary_bus);\n+\tal_pcie_controller_writel(pcie, cfg_control_offset, cfg_control);\n \n \treturn 0;\n }\n","prefixes":["09/16"]}