{"id":2231360,"url":"http://patchwork.ozlabs.org/api/patches/2231360/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260430161254.40278-6-18255117159@163.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430161254.40278-6-18255117159@163.com>","list_archive_url":null,"date":"2026-04-30T16:12:43","name":"[05/16] PCI/TPH: Use FIELD_MODIFY()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2318f6073296c074ff8d4299620fe540235700b6","submitter":{"id":89937,"url":"http://patchwork.ozlabs.org/api/people/89937/?format=json","name":"Hans Zhang","email":"18255117159@163.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260430161254.40278-6-18255117159@163.com/mbox/","series":[{"id":502337,"url":"http://patchwork.ozlabs.org/api/series/502337/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=502337","date":"2026-04-30T16:12:44","name":"PCI: Use FIELD_MODIFY() to simplify bitfield operations","version":1,"mbox":"http://patchwork.ozlabs.org/series/502337/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231360/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231360/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=aZ6rsasI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-53501-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=\"aZ6rsasI\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=117.135.210.3","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=163.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5zsQ726Hz1yGq\n\tfor ; Fri, 01 May 2026 02:19:54 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 0B6713051ABC\n\tfor ; Thu, 30 Apr 2026 16:14:10 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7D213472793;\n\tThu, 30 Apr 2026 16:13:53 +0000 (UTC)","from m16.mail.163.com (m16.mail.163.com [117.135.210.3])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id DEC5B428846;\n\tThu, 30 Apr 2026 16:13:50 +0000 (UTC)","from zhb.. (unknown [])\n\tby gzga-smtp-mtada-g0-4 (Coremail) with SMTP id\n _____wDnbymkf_NpTNe+Cg--.31297S7;\n\tFri, 01 May 2026 00:13:28 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777565633; cv=none;\n b=Rbw4/A0h53zsII8gr3nJUc1eCiEqNvr0UVLRBjIhLBl//SmIMKZI2DenN9OVuOoQoAEBLEowF5SE7Gfpn4EIH1W+QvYf3ApiYuBpHC/30mvcuJv+X3RZy8rSojqtb1tC1EJm9pseUo4UmJh9UjF2Ou8ge5T2kPvs1tAZZasvAUA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777565633; c=relaxed/simple;\n\tbh=mKRbDHHs0pBDmNClLmPUI/k8yIq84PMezI+ZfgY5vhM=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=I5H1mIpIB0QMk8hmrCk/yXWkUnyHwlY5IHXj+AEHQPSomQ07PgWf6o7o4sFvWfk6IT37aoIJ7ZhHst5Z4+lm+foH8mWXh7yGAqj9EVVA4p/e7pYi7Yq0K5AH0HcdcLO3kezcWVg2S2tqQZ41xade3NnLSkduIiTrV2FesiTvD4o=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com;\n spf=pass smtp.mailfrom=163.com;\n dkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=aZ6rsasI; arc=none smtp.client-ip=117.135.210.3","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=MK\n\t0nueE9kuPh+C6bezt4QBz2BNnFpiu2HHOSbx6DsC8=; b=aZ6rsasI7ujYDvUTIu\n\tsPRpVd/Pl10MsbVr073EEOEFPrBLeiQsLQbMwSSr1SkD+Uwb87e4AzGq7ckQfBx0\n\tkZvUskUdcVh22ugrgGoP2dUQILBn2pWrEhjoW8MP1boQm//MoTsyhRw3pwz5MKFt\n\tEtrGt2hjGrPqikjrAMuCeSy1w=","From":"Hans Zhang <18255117159@163.com>","To":"bhelgaas@google.com,\n\tlpieralisi@kernel.org,\n\tkwilczynski@kernel.org,\n\tmani@kernel.org,\n\tjingoohan1@gmail.com","Cc":"robh@kernel.org,\n\ts32@nxp.com,\n\tlinux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tHans Zhang <18255117159@163.com>","Subject":"[PATCH 05/16] PCI/TPH: Use FIELD_MODIFY()","Date":"Fri, 1 May 2026 00:12:43 +0800","Message-Id":"<20260430161254.40278-6-18255117159@163.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260430161254.40278-1-18255117159@163.com>","References":"<20260430161254.40278-1-18255117159@163.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"_____wDnbymkf_NpTNe+Cg--.31297S7","X-Coremail-Antispam":"1Uf129KBjvJXoW7urW7uF4xGF1fZr48AF1xuFg_yoW8Xr1Upa\n\tyrJa4fKF9rtr1jyF4DXa1DXrn0gF9aqF97A34Ut39FgF47AF4xXasYyrnxtr18ZFWvvFWf\n\tua9xtryjgFyUA3JanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pRkOzsUUUUU=","X-CM-SenderInfo":"rpryjkyvrrlimvzbiqqrwthudrp/xtbCwwhhBWnzf6j1+wAA3s"},"content":"Use FIELD_MODIFY() to remove open-coded bit manipulation.\nNo functional change intended.\n\nSigned-off-by: Hans Zhang <18255117159@163.com>\n---\n drivers/pci/tph.c | 10 +++-------\n 1 file changed, 3 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/pci/tph.c b/drivers/pci/tph.c\nindex 91145e8d9d95..655ffd60e62f 100644\n--- a/drivers/pci/tph.c\n+++ b/drivers/pci/tph.c\n@@ -139,8 +139,7 @@ static void set_ctrl_reg_req_en(struct pci_dev *pdev, u8 req_type)\n \n \tpci_read_config_dword(pdev, pdev->tph_cap + PCI_TPH_CTRL, ®);\n \n-\treg &= ~PCI_TPH_CTRL_REQ_EN_MASK;\n-\treg |= FIELD_PREP(PCI_TPH_CTRL_REQ_EN_MASK, req_type);\n+\tFIELD_MODIFY(PCI_TPH_CTRL_REQ_EN_MASK, ®, req_type);\n \n \tpci_write_config_dword(pdev, pdev->tph_cap + PCI_TPH_CTRL, reg);\n }\n@@ -427,11 +426,8 @@ int pcie_enable_tph(struct pci_dev *pdev, int mode)\n \t/* Write them into TPH control register */\n \tpci_read_config_dword(pdev, pdev->tph_cap + PCI_TPH_CTRL, ®);\n \n-\treg &= ~PCI_TPH_CTRL_MODE_SEL_MASK;\n-\treg |= FIELD_PREP(PCI_TPH_CTRL_MODE_SEL_MASK, pdev->tph_mode);\n-\n-\treg &= ~PCI_TPH_CTRL_REQ_EN_MASK;\n-\treg |= FIELD_PREP(PCI_TPH_CTRL_REQ_EN_MASK, pdev->tph_req_type);\n+\tFIELD_MODIFY(PCI_TPH_CTRL_MODE_SEL_MASK, ®, pdev->tph_mode);\n+\tFIELD_MODIFY(PCI_TPH_CTRL_REQ_EN_MASK, ®, pdev->tph_req_type);\n \n \tpci_write_config_dword(pdev, pdev->tph_cap + PCI_TPH_CTRL, reg);\n \n","prefixes":["05/16"]}