{"id":2231358,"url":"http://patchwork.ozlabs.org/api/patches/2231358/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260430161254.40278-4-18255117159@163.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430161254.40278-4-18255117159@163.com>","list_archive_url":null,"date":"2026-04-30T16:12:41","name":"[03/16] PCI/IDE: Use FIELD_MODIFY()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"971dacc5106c78a416f58eb246afb45d38d41a26","submitter":{"id":89937,"url":"http://patchwork.ozlabs.org/api/people/89937/?format=json","name":"Hans Zhang","email":"18255117159@163.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260430161254.40278-4-18255117159@163.com/mbox/","series":[{"id":502337,"url":"http://patchwork.ozlabs.org/api/series/502337/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=502337","date":"2026-04-30T16:12:44","name":"PCI: Use FIELD_MODIFY() to simplify bitfield operations","version":1,"mbox":"http://patchwork.ozlabs.org/series/502337/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231358/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231358/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=JAecVmDY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-53498-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=\"JAecVmDY\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=220.197.31.3","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=163.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5zsM2FYMz1yGq\n\tfor ; Fri, 01 May 2026 02:19:51 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 0B93A3016B3D\n\tfor ; Thu, 30 Apr 2026 16:13:58 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 17C9046AF1E;\n\tThu, 30 Apr 2026 16:13:52 +0000 (UTC)","from m16.mail.163.com (m16.mail.163.com [220.197.31.3])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E90B63E314D;\n\tThu, 30 Apr 2026 16:13:49 +0000 (UTC)","from zhb.. (unknown [])\n\tby gzga-smtp-mtada-g0-4 (Coremail) with SMTP id\n _____wDnbymkf_NpTNe+Cg--.31297S5;\n\tFri, 01 May 2026 00:13:27 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777565632; cv=none;\n b=UnzJWZ3h5iWJyuMb4D641c/5qVGx75neSJNBXQ7HEYP6v1ULQddZhmNAd/vPJfKrBJxHVOcQ6ZEp+g5CtVnMjIxneBJuBautzapQmo7EezdQI1ncE0qnG5hdp0IW3zC986BK2DMF88+NEOHV0YqUP640Qkd/N3+10fsTWxbMF7o=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777565632; c=relaxed/simple;\n\tbh=//g/gfYin1BYZPPEXv047fnhk6hs7IC+Kacx/LUCRgs=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=aJsX1P1PojqhZfkhb3SHPpz8BcIi2XP975Ao70Q8+vwYNSgxxFXhz3OG1rXu2udyiaHFZ5Gb4S5phhjp/tRPVjhzuvFUY3HQxNEM3H1K+lJug4G9nwjrJsuS0z01Zh6ikwJ/gMvB8wJ5T13pQS+vCgRpGfJ76LKM1rzreHdYZO0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com;\n spf=pass smtp.mailfrom=163.com;\n dkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=JAecVmDY; arc=none smtp.client-ip=220.197.31.3","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=lQ\n\tfUqpcdUHp737uvF57WjW/GDdEjm5esbQrm+jqJ1Bw=; b=JAecVmDYLJp79ogwO+\n\tXADTkEiIFyOt7v9d1d7Z0q0YYAn27PJqpXpzqJXdL83I9ktgKCG48RB+HmaHGyoV\n\tzr7VfgLFidP+5rZYNbWRsHcSujJ7VV4oI+XTwnSCdgFDb7HmbHglThJWYT5ArdcT\n\twxs/PN0U1twbxHwfWED3HQAvE=","From":"Hans Zhang <18255117159@163.com>","To":"bhelgaas@google.com,\n\tlpieralisi@kernel.org,\n\tkwilczynski@kernel.org,\n\tmani@kernel.org,\n\tjingoohan1@gmail.com","Cc":"robh@kernel.org,\n\ts32@nxp.com,\n\tlinux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tHans Zhang <18255117159@163.com>","Subject":"[PATCH 03/16] PCI/IDE: Use FIELD_MODIFY()","Date":"Fri, 1 May 2026 00:12:41 +0800","Message-Id":"<20260430161254.40278-4-18255117159@163.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260430161254.40278-1-18255117159@163.com>","References":"<20260430161254.40278-1-18255117159@163.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"_____wDnbymkf_NpTNe+Cg--.31297S5","X-Coremail-Antispam":"1Uf129KBjvdXoWrur17Kr1rWryUZr47GFWfXwb_yoWkKwc_ur\n\ty29r97uFyUAFyxC3Wakr1fJr95uw4qqa1rAa1DtF1Sk343Jwn5WwnYyry8C3y0gFsxZrW5\n\tKrWDXa4rZr1jkjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT\n\t9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRleHDUUUUUU==","X-CM-SenderInfo":"rpryjkyvrrlimvzbiqqrwthudrp/xtbCwwdgBGnzf6f10AAA3H"},"content":"Use FIELD_MODIFY() to remove open-coded bit manipulation.\nNo functional change intended.\n\nSigned-off-by: Hans Zhang <18255117159@163.com>\n---\n drivers/pci/ide.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/pci/ide.c b/drivers/pci/ide.c\nindex be74e8f0ae21..beb67b8fb5c5 100644\n--- a/drivers/pci/ide.c\n+++ b/drivers/pci/ide.c\n@@ -170,8 +170,7 @@ void pci_ide_init(struct pci_dev *pdev)\n \t\tpci_read_config_dword(pdev, pos + PCI_IDE_SEL_CTL, &val);\n \t\tif (val & PCI_IDE_SEL_CTL_EN)\n \t\t\tcontinue;\n-\t\tval &= ~PCI_IDE_SEL_CTL_ID;\n-\t\tval |= FIELD_PREP(PCI_IDE_SEL_CTL_ID, PCI_IDE_RESERVED_STREAM_ID);\n+\t\tFIELD_MODIFY(PCI_IDE_SEL_CTL_ID, &val, PCI_IDE_RESERVED_STREAM_ID);\n \t\tpci_write_config_dword(pdev, pos + PCI_IDE_SEL_CTL, val);\n \t}\n \n@@ -182,8 +181,7 @@ void pci_ide_init(struct pci_dev *pdev)\n \t\tpci_read_config_dword(pdev, pos, &val);\n \t\tif (val & PCI_IDE_LINK_CTL_EN)\n \t\t\tcontinue;\n-\t\tval &= ~PCI_IDE_LINK_CTL_ID;\n-\t\tval |= FIELD_PREP(PCI_IDE_LINK_CTL_ID, PCI_IDE_RESERVED_STREAM_ID);\n+\t\tFIELD_MODIFY(PCI_IDE_LINK_CTL_ID, &val, PCI_IDE_RESERVED_STREAM_ID);\n \t\tpci_write_config_dword(pdev, pos, val);\n \t}\n \n","prefixes":["03/16"]}