{"id":2231356,"url":"http://patchwork.ozlabs.org/api/patches/2231356/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260430161254.40278-8-18255117159@163.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430161254.40278-8-18255117159@163.com>","list_archive_url":null,"date":"2026-04-30T16:12:45","name":"[07/16] PCI/REBAR: Use FIELD_MODIFY()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e1f20c0751cdb552389e476c69b736c8f74ac747","submitter":{"id":89937,"url":"http://patchwork.ozlabs.org/api/people/89937/?format=json","name":"Hans Zhang","email":"18255117159@163.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260430161254.40278-8-18255117159@163.com/mbox/","series":[{"id":502337,"url":"http://patchwork.ozlabs.org/api/series/502337/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=502337","date":"2026-04-30T16:12:44","name":"PCI: Use FIELD_MODIFY() to simplify bitfield operations","version":1,"mbox":"http://patchwork.ozlabs.org/series/502337/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231356/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231356/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=163.com header.i=@163.com header.a=rsa-sha256\n header.s=s110527 header.b=iXo3TSnL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-53506-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=\"iXo3TSnL\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=117.135.210.3","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=163.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5zmt4ghzz1yGq\n\tfor ; Fri, 01 May 2026 02:15:58 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 4BB6A3018615\n\tfor ; Thu, 30 Apr 2026 16:15:12 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D73B746AF38;\n\tThu, 30 Apr 2026 16:14:06 +0000 (UTC)","from m16.mail.163.com (m16.mail.163.com [117.135.210.3])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D26247A0D0;\n\tThu, 30 Apr 2026 16:14:02 +0000 (UTC)","from zhb.. (unknown [])\n\tby gzga-smtp-mtada-g0-4 (Coremail) with SMTP id\n _____wDnbymkf_NpTNe+Cg--.31297S9;\n\tFri, 01 May 2026 00:13:29 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777565646; cv=none;\n b=ECr59bZplPMHnEvxiAwY1yzbfrk/qgMFpjiRdmQH85o103VKOcf0Z4qof7rDljEmlUKO+he5Lcgwa+msQb2MAFURURbFU/pPg2hXeKFQLBThJ/Rb/O9Pecetd9qeCeJmpmVvFCRupuT38sIHATsja2mv7DE5G3kD3ee4P53TTBk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777565646; c=relaxed/simple;\n\tbh=nPMKN1Fe1bsfz1xlPQMcwLjyp7UGawQC2SNZYnNmcWo=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=qZhfuzn1lbIycW7JdHjat+l/1wEPXeXCOs6RD2UU24xVT7bnZrpC/Rfg2uZSnUiSsNHh6jiR4NNSbcWHmffUGI6XQ2/bZ2IuDye2sD/EUQNThdNAdQhP8IiouOqtAMU/eqF8zmKolF0UVqihLBfJGmnqLh64QZaAw67py21zIkc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=163.com;\n spf=pass smtp.mailfrom=163.com;\n dkim=pass (1024-bit key) header.d=163.com header.i=@163.com\n header.b=iXo3TSnL; arc=none smtp.client-ip=117.135.210.3","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n\ts=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=0K\n\tC3Cmy2ZLsYR50fE71ZJySGEQ83dgNo/ZzhAx1nNYw=; b=iXo3TSnLAYoVfP9EXa\n\tj7YD0MlyGrWw62VdpRFOIwTXexayveFu0eStd+9wUjhhlwbIDw+6bZEY7ZOIil1h\n\tpiGE8Obear/uvo0ywoF7oBsCqDl3q0haeaApeBQJjs4XFiKHn4vLHup1AKY+V8pb\n\tHW1nfVzr+pt6PiOsbMyEsDT04=","From":"Hans Zhang <18255117159@163.com>","To":"bhelgaas@google.com,\n\tlpieralisi@kernel.org,\n\tkwilczynski@kernel.org,\n\tmani@kernel.org,\n\tjingoohan1@gmail.com","Cc":"robh@kernel.org,\n\ts32@nxp.com,\n\tlinux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tHans Zhang <18255117159@163.com>","Subject":"[PATCH 07/16] PCI/REBAR: Use FIELD_MODIFY()","Date":"Fri, 1 May 2026 00:12:45 +0800","Message-Id":"<20260430161254.40278-8-18255117159@163.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260430161254.40278-1-18255117159@163.com>","References":"<20260430161254.40278-1-18255117159@163.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"_____wDnbymkf_NpTNe+Cg--.31297S9","X-Coremail-Antispam":"1Uf129KBjvJXoWrur17tw47JFWrXw1rAFWrKrg_yoW8JF1kpr\n\tZ5C3ZrGr18JFnrtr1DWa1jkwn0gaykX3srGF9Ik39xZF98twnFv39Ikas5Gr4rJFWkZr45\n\tCFn5try3uF98JaUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pRkOzsUUUUU=","X-CM-SenderInfo":"rpryjkyvrrlimvzbiqqrwthudrp/xtbC7AlhBWnzf6n0JgAA3f"},"content":"Use FIELD_MODIFY() to remove open-coded bit manipulation.\nNo functional change intended.\n\nSigned-off-by: Hans Zhang <18255117159@163.com>\n---\n drivers/pci/rebar.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/pci/rebar.c b/drivers/pci/rebar.c\nindex 39f8cf3b70d5..e3e0415fc29a 100644\n--- a/drivers/pci/rebar.c\n+++ b/drivers/pci/rebar.c\n@@ -211,8 +211,7 @@ int pci_rebar_set_size(struct pci_dev *pdev, int bar, int size)\n \t\treturn pos;\n \n \tpci_read_config_dword(pdev, pos + PCI_REBAR_CTRL, &ctrl);\n-\tctrl &= ~PCI_REBAR_CTRL_BAR_SIZE;\n-\tctrl |= FIELD_PREP(PCI_REBAR_CTRL_BAR_SIZE, size);\n+\tFIELD_MODIFY(PCI_REBAR_CTRL_BAR_SIZE, &ctrl, size);\n \tpci_write_config_dword(pdev, pos + PCI_REBAR_CTRL, ctrl);\n \n \tif (pci_resource_is_iov(bar))\n@@ -241,8 +240,7 @@ void pci_restore_rebar_state(struct pci_dev *pdev)\n \t\tbar_idx = ctrl & PCI_REBAR_CTRL_BAR_IDX;\n \t\tres = pci_resource_n(pdev, bar_idx);\n \t\tsize = pci_rebar_bytes_to_size(resource_size(res));\n-\t\tctrl &= ~PCI_REBAR_CTRL_BAR_SIZE;\n-\t\tctrl |= FIELD_PREP(PCI_REBAR_CTRL_BAR_SIZE, size);\n+\t\tFIELD_MODIFY(PCI_REBAR_CTRL_BAR_SIZE, &ctrl, size);\n \t\tpci_write_config_dword(pdev, pos + PCI_REBAR_CTRL, ctrl);\n \t}\n }\n","prefixes":["07/16"]}