{"id":2231272,"url":"http://patchwork.ozlabs.org/api/patches/2231272/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260430123154.132072-1-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430123154.132072-1-aleksandr.loktionov@intel.com>","list_archive_url":null,"date":"2026-04-30T12:31:53","name":"[net] ixgbe: fix X550 AQ PHY identification returning ixgbe_phy_unknown","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f5ada371f6331dcd6765a2116ab34f8253a81014","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/?format=json","name":"Aleksandr Loktionov","email":"aleksandr.loktionov@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260430123154.132072-1-aleksandr.loktionov@intel.com/mbox/","series":[{"id":502301,"url":"http://patchwork.ozlabs.org/api/series/502301/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=502301","date":"2026-04-30T12:31:53","name":"[net] ixgbe: fix X550 AQ PHY identification returning ixgbe_phy_unknown","version":1,"mbox":"http://patchwork.ozlabs.org/series/502301/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231272/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231272/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=sW9+QoJ9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5tpZ456nz1yK1\n\tfor ; Thu, 30 Apr 2026 22:32:04 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 14D8560EA8;\n\tThu, 30 Apr 2026 12:32:02 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id mhF1JYRLQRdn; Thu, 30 Apr 2026 12:32:00 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 2211760E5D;\n\tThu, 30 Apr 2026 12:32:00 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 8699718F\n for ; Thu, 30 Apr 2026 12:31:59 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 787764297C\n for ; Thu, 30 Apr 2026 12:31:59 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id YKMgAPx6GLcv for ;\n Thu, 30 Apr 2026 12:31:57 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.17])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 045FB42977\n for ; Thu, 30 Apr 2026 12:31:56 +0000 (UTC)","from fmviesa004.fm.intel.com ([10.60.135.144])\n by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Apr 2026 05:31:56 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by fmviesa004.fm.intel.com with ESMTP; 30 Apr 2026 05:31:55 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2211760E5D","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 045FB42977"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777552320;\n\tbh=Nl+wXRXxBVxXlXEUmTotrp6g7Naav3Th296LsGNxIBQ=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=sW9+QoJ9k6jEJVPO1sbKVw/DpraWikPqW/9a0CE4gPnU6JxCoWPTMTAczRLXgPHMH\n\t EsQtTwRjZKpo9nZtKvlnhaOCaWnnLqx8D926sZGKhh6mBOBDzLETWtvZXUKzyr3Mjh\n\t 3TnVS/u4HeO8siOVxy6KGDsaB6h6afc1X1pbxu+nFcI9WUJd6nchLyGYSqA9Kag5S0\n\t rQQqdW2RA7i3IrtuJ1GypIAuUnM79ixZC1at1W1Mv8p86uuiap/pggYUEUJ0vSSC88\n\t aAPa8J8wty1jCj/XF+LRyAb+XwgcSlT6g8snLHDkT/pAB5943ysaf7u+lsE+qo3I9w\n\t qZnAGEQjB+QsA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.17;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 045FB42977","X-CSE-ConnectionGUID":["gUWFDYOFQyGfY2nXwdojKw==","HoLNcZzvQ6icQ3rD2c9NCA=="],"X-CSE-MsgGUID":["gK8kv1pqRVS1PQvyApIzOA==","OtfPuoPHRcKyXdb1fTk7Dg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11771\"; a=\"78487640\"","E=Sophos;i=\"6.23,208,1770624000\"; d=\"scan'208\";a=\"78487640\"","E=Sophos;i=\"6.23,208,1770624000\"; d=\"scan'208\";a=\"236353093\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov ","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org","Date":"Thu, 30 Apr 2026 14:31:53 +0200","Message-ID":"<20260430123154.132072-1-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777552317; x=1809088317;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=wZ/elesy/7o01ujF9sto27cSfGzsZbuvXwSSNlM4CXE=;\n b=dkZvQ6IdJFx93pPxOlh0sSa2DzFrYyy4X70zQFbwM2KM3B3OIt3/9YSz\n kzFIvf+DPiL+MTjtTq66Ca7lpg4ZTWvXGjqShXO3Tag3H/nDFj0ZOqAfF\n WlITjEGf11cQTqsmb8QQbXj62P/bB0LcPaZ4zrpBNQSIDSnO3aKtQsioj\n 3cQOWwt146lhUbut6myK+pvsmOjUK/KPPne72MdIFb4QlwHIrqJxju/eh\n JjmTh6F3aW3cebZSBECHDCsQPJl/25EQ2qG9vb1WkcRhmlDAGtfIMtBqN\n 2rvpVW0i694oUD2s/eC/Jscj+s7yWiGkGqiIAClCBRBrUN1arZa/VBWWU\n Q==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=dkZvQ6Id"],"Subject":"[Intel-wired-lan] [PATCH net] ixgbe: fix X550 AQ PHY identification\n returning ixgbe_phy_unknown","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"ixgbe_get_phy_id() reads the two MII_PHYSID registers and combines them\ninto hw->phy.id with the lower 4 revision bits masked out by\nIXGBE_PHY_REVISION_MASK (0xFFFFFFF0).\n\nCommit 5f1c3589b0f0 (\"ixgbe: Correct X550 phy ID\") replaced\nX550_PHY_ID (0x01540220) with X550_PHY_ID2 (0x01540223) and\nX550_PHY_ID3 (0x01540221). These are the raw values read directly off\nhardware, but after revision-bit masking both reduce to 0x01540220.\nThe switch cases in ixgbe_get_phy_type_from_id() therefore never match,\nand X550 AQ PHY devices always fall through to ixgbe_phy_unknown. A\nwrong PHY type means the wrong ops vector is selected, resulting in\nfailed PHY initialization and no link.\n\nRestore X550_PHY_ID (0x01540220) as the match value -- the\nrevision-stripped ID that the driver actually stores. Keep X550_PHY_ID2\nand X550_PHY_ID3 as documentation of the hardware-reported values.\n\nFixes: 5f1c3589b0f0 (\"ixgbe: Correct X550 phy ID\")\nSigned-off-by: Aleksandr Loktionov \n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 3 +--\n drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 1 +\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\nindex ab733e7..ca98dad 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n@@ -364,8 +364,7 @@ static enum ixgbe_phy_type ixgbe_get_phy_type_from_id(u32 phy_id)\n \tcase TN1010_PHY_ID:\n \t\tphy_type = ixgbe_phy_tn;\n \t\tbreak;\n-\tcase X550_PHY_ID2:\n-\tcase X550_PHY_ID3:\n+\tcase X550_PHY_ID:\n \tcase X540_PHY_ID:\n \t\tphy_type = ixgbe_phy_aq;\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\nindex 61f2ef6..0d47622 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\n@@ -1412,6 +1412,7 @@ struct ixgbe_nvm_version {\n #define TN1010_PHY_ID 0x00A19410\n #define TNX_FW_REV 0xB\n #define X540_PHY_ID 0x01540200\n+#define X550_PHY_ID 0x01540220\n #define X550_PHY_ID2\t0x01540223\n #define X550_PHY_ID3\t0x01540221\n #define X557_PHY_ID 0x01540240\n","prefixes":["net"]}