{"id":2231237,"url":"http://patchwork.ozlabs.org/api/patches/2231237/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260430122602.126722-3-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430122602.126722-3-aleksandr.loktionov@intel.com>","list_archive_url":null,"date":"2026-04-30T12:25:59","name":"[2/5] ice: remove unnecessary PF_SB_REM_DEV_CTL write for E82X","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"24f384da5522808c01bdaba47e3fbe8b0bd86ff8","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/?format=json","name":"Aleksandr Loktionov","email":"aleksandr.loktionov@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260430122602.126722-3-aleksandr.loktionov@intel.com/mbox/","series":[{"id":502294,"url":"http://patchwork.ozlabs.org/api/series/502294/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=502294","date":"2026-04-30T12:25:58","name":"ice: five small fixes and cleanups","version":1,"mbox":"http://patchwork.ozlabs.org/series/502294/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2231237/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2231237/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=7UQ4hLl8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5tgn6xVfz1yHZ\n\tfor ; Thu, 30 Apr 2026 22:26:13 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 1BD946178F;\n\tThu, 30 Apr 2026 12:26:12 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 4Gfkq9NEC6kl; Thu, 30 Apr 2026 12:26:10 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 4C3A26179F;\n\tThu, 30 Apr 2026 12:26:10 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id D8D5B18F\n for ; Thu, 30 Apr 2026 12:26:08 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id BF3AC4073C\n for ; Thu, 30 Apr 2026 12:26:08 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id mlwUHGMoiqGf for ;\n Thu, 30 Apr 2026 12:26:07 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by smtp2.osuosl.org (Postfix) with ESMTPS id C957E403D6\n for ; Thu, 30 Apr 2026 12:26:07 +0000 (UTC)","from orviesa006.jf.intel.com ([10.64.159.146])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Apr 2026 05:26:07 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa006.jf.intel.com with ESMTP; 30 Apr 2026 05:26:06 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4C3A26179F","OpenDKIM Filter v2.11.0 smtp2.osuosl.org C957E403D6"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777551970;\n\tbh=TKDljZ5Zu2iCNLZber9hYnJTEZa7j4BMIymWcM6yW9Y=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=7UQ4hLl8FQJ7PsNiD9zeGG8K20UixYbdOKg3dnM0MOeOu14EsNc5fkVL3uVvlGiAu\n\t lNBpwaybyGEEnF+Kidmc3NNTNw1OsBK24qaeQp8Wikadr9XQ2FjfYLNfPN76YyjsWu\n\t aYIG8zyxFWvvzqsLQcIxR0lxqX2BF9HpOFXKQg5dPRKNQBSLikYphpr3z5LaF4IVtB\n\t iZjjNOsdZse5wiULVZf+t/NgAiJIDIunStOpMsjvWV8GsXgTx4+PoMz93T2IjCKP1U\n\t VlrfBQXqCbKP6d9/URa+cxNT3cs1GVFtyxsJTJCMQIt9YavWej1r6YLqYPYS+qCrtN\n\t vWgkrr+lw2aaw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org C957E403D6","X-CSE-ConnectionGUID":["2CvoTBj2SK20e8XQhm+YdQ==","MAPtY//6SAC9yo/g4nHqNA=="],"X-CSE-MsgGUID":["uFBgeATMT8CZxxjC/maqpg==","KMYtALv/QB+btlJa445l+Q=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11771\"; a=\"78689186\"","E=Sophos;i=\"6.23,208,1770624000\"; d=\"scan'208\";a=\"78689186\"","E=Sophos;i=\"6.23,208,1770624000\"; d=\"scan'208\";a=\"233538429\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov ","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org","Date":"Thu, 30 Apr 2026 14:25:59 +0200","Message-ID":"<20260430122602.126722-3-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260430122602.126722-1-aleksandr.loktionov@intel.com>","References":"<20260430122602.126722-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777551968; x=1809087968;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=WmUk/hzZFJcKObTRWjUXnGHFK9+dUHG3QByEE5jydN8=;\n b=PCe9/GJJpZWaa9+ShBlk3xpBCGXvj73i6/pnu3bdNbawmxyaGU+XK+fz\n BzTHT2RvaJjFM6iplWaUalaVJmy3iJdeOwM41QiWSuZMCXp7EqimPJiGI\n xcfp9IxapYV/ft7Py20ivHgYxwKJz4mLyXAq3ZSQozRJVEzSbCdrh7jpd\n qaEaTMwpHJ7jWc3o/qHN0cUXjPXILaW2uMx31ZX49P5n1JasyHWtsSWZn\n KOVZrY/a988Lt4Z+Qj0SCaLz80HpSkd1ZYr52fFKw3rdkbWv/MpjQENTY\n rsSEnODJdv+99P+AxKPz2dItphaR+BeLIEqnG3ly6zw9dqClDQFHRUsqU\n A==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=PCe9/GJJ"],"Subject":"[Intel-wired-lan] [PATCH 2/5] ice: remove unnecessary\n PF_SB_REM_DEV_CTL write for E82X","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Karol Kolacinski \n\nRemove the PF_SB_REM_DEV_CTL register write from ice_ptp_init_phc_e82x().\nPHY access is enabled by default on E82X devices and the driver does not\nneed to configure switch device access. The register write was a\nremnant of an earlier SWITCH_MODE workaround for a FIFO issue and is\nno longer needed.\n\nAlso update the kernel-doc comment to refer to the E82X family rather than\nE822.\n\nSigned-off-by: Karol Kolacinski \nSigned-off-by: Aleksandr Loktionov \n---\n drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 13 ++-----------\n 1 file changed, 2 insertions(+), 11 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c\nindex 61c0a0d..7b1b402 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c\n@@ -2767,22 +2767,13 @@ static int ice_ptp_set_vernier_wl(struct ice_hw *hw)\n }\n \n /**\n- * ice_ptp_init_phc_e82x - Perform E822 specific PHC initialization\n+ * ice_ptp_init_phc_e82x - Perform E82X specific PHC initialization\n * @hw: pointer to HW struct\n *\n- * Perform PHC initialization steps specific to E822 devices.\n+ * Perform PHC initialization steps specific to E82X devices.\n */\n static int ice_ptp_init_phc_e82x(struct ice_hw *hw)\n {\n-\tu32 val;\n-\n-\t/* Enable reading switch and PHY registers over the sideband queue */\n-#define PF_SB_REM_DEV_CTL_SWITCH_READ BIT(1)\n-#define PF_SB_REM_DEV_CTL_PHY0 BIT(2)\n-\tval = rd32(hw, PF_SB_REM_DEV_CTL);\n-\tval |= (PF_SB_REM_DEV_CTL_SWITCH_READ | PF_SB_REM_DEV_CTL_PHY0);\n-\twr32(hw, PF_SB_REM_DEV_CTL, val);\n-\n \t/* Set window length for all the ports */\n \treturn ice_ptp_set_vernier_wl(hw);\n }\n","prefixes":["2/5"]}