{"id":2230871,"url":"http://patchwork.ozlabs.org/api/patches/2230871/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430071315.354333-6-zhenzhong.duan@intel.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430071315.354333-6-zhenzhong.duan@intel.com>","list_archive_url":null,"date":"2026-04-30T07:13:01","name":"[v4,05/15] intel_iommu: Change pasid property from bool to uint8","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"87a94ea92d0814db21f7c6545e466f4fc467f1b0","submitter":{"id":81636,"url":"http://patchwork.ozlabs.org/api/people/81636/?format=json","name":"Duan, Zhenzhong","email":"zhenzhong.duan@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430071315.354333-6-zhenzhong.duan@intel.com/mbox/","series":[{"id":502222,"url":"http://patchwork.ozlabs.org/api/series/502222/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502222","date":"2026-04-30T07:12:57","name":"intel_iommu: Enable PASID support for passthrough device","version":4,"mbox":"http://patchwork.ozlabs.org/series/502222/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230871/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2230871/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=mMvt3v9i;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5lmc59hyz1yHv\n\tfor ; Thu, 30 Apr 2026 17:14:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wILbS-0005TD-Ss; Thu, 30 Apr 2026 03:14:31 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wILav-00059Y-3y\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 03:14:00 -0400","from mgamail.intel.com ([192.198.163.13])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wILaq-0008OM-NM\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 03:13:55 -0400","from orviesa007.jf.intel.com ([10.64.159.147])\n by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Apr 2026 00:13:50 -0700","from unknown (HELO gnr-sp-2s-612.sh.intel.com) ([10.112.230.229])\n by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Apr 2026 00:13:47 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777533232; x=1809069232;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=/fC8XQk85iHmQCX9DcJIIJqvK6Yi4PUzajnId/1UAKs=;\n b=mMvt3v9icgPiUhemnxDQ1WcByq5JfjW7gkCjGSzFXC+HgG65eNYWcn39\n JL6uqieljButBdM8/nidisyY1LihALid9ZVYENQbwf0vMZ8vmUefM6BYv\n YMjn/ZBewhIvJTeZEGN+qXhFM0eFdpTcajn+/Fsko+T4lpKLWlznBIQmQ\n j4v2bJom+H7pvosE59tLcvsnwCvshpdmoy99TyEcwMiv2p6zyYbd17YKz\n R+MsXyPl9w5eO8x1i2vswll/LS6XlqrD9ClcOvDyoR1lq0UHr7LX2rePu\n oDSx+6bNTozBPVB13Q1QjTWpbPIggpNCYaQtBSDf6lWzJPxhxdpTyFJpM g==;","X-CSE-ConnectionGUID":["ZoRyM+tOTKW8hhPwOyLJcQ==","DDt/SqrfTgO2ejkRiDIC8Q=="],"X-CSE-MsgGUID":["KFvZoOvkTPSXV7Ok5ReYgg==","3ZK4pXCURm6SZEAvjVeVhw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11771\"; a=\"81051604\"","E=Sophos;i=\"6.23,207,1770624000\"; d=\"scan'208\";a=\"81051604\"","E=Sophos;i=\"6.23,207,1770624000\"; d=\"scan'208\";a=\"234771489\""],"X-ExtLoop1":"1","From":"Zhenzhong Duan ","To":"qemu-devel@nongnu.org","Cc":"alex@shazbot.org, clg@redhat.com, eric.auger@redhat.com, mst@redhat.com,\n jasowang@redhat.com, jgg@nvidia.com, nicolinc@nvidia.com,\n skolothumtho@nvidia.com, joao.m.martins@oracle.com,\n clement.mathieu--drif@bull.com, kevin.tian@intel.com, yi.l.liu@intel.com,\n xudong.hao@intel.com, Zhenzhong Duan ","Subject":"[PATCH v4 05/15] intel_iommu: Change pasid property from bool to\n uint8","Date":"Thu, 30 Apr 2026 03:13:01 -0400","Message-ID":"<20260430071315.354333-6-zhenzhong.duan@intel.com>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260430071315.354333-1-zhenzhong.duan@intel.com>","References":"<20260430071315.354333-1-zhenzhong.duan@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=192.198.163.13;\n envelope-from=zhenzhong.duan@intel.com; helo=mgamail.intel.com","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"'x-pasid-mode' is a bool property, we need an extra 'pss' property to\nrepresent PASID size supported. Because there is no any device in QEMU\nsupporting pasid capability yet, no guest could use the pasid feature\nuntil now, 'x-pasid-mode' takes no effect.\n\nSo instead of an extra 'pss' property we can use a single 'pasid'\nproperty of uint8 type to represent if pasid is supported and the PASID\nbits size. A value of N > 0 means pasid is supported and N - 1 is the\nvalue in PSS field in ECAP register.\n\nPASID bits size should also be no more than 20 bits according to PCI spec.\n\nSigned-off-by: Zhenzhong Duan \nReviewed-by: Clement Mathieu--Drif \nTested-by: Xudong Hao \n---\n hw/i386/intel_iommu_internal.h | 2 +-\n include/hw/i386/intel_iommu.h | 2 +-\n hw/i386/intel_iommu.c | 11 +++++++++--\n 3 files changed, 11 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h\nindex 11a53aa369..db4f186a3e 100644\n--- a/hw/i386/intel_iommu_internal.h\n+++ b/hw/i386/intel_iommu_internal.h\n@@ -195,7 +195,7 @@\n #define VTD_ECAP_MHMV (15ULL << 20)\n #define VTD_ECAP_SRS (1ULL << 31)\n #define VTD_ECAP_NWFS (1ULL << 33)\n-#define VTD_ECAP_PSS (7ULL << 35) /* limit: MemTxAttrs::pid */\n+#define VTD_ECAP_SET_PSS(x, v) ((x)->ecap = deposit64((x)->ecap, 35, 5, v))\n #define VTD_ECAP_PASID (1ULL << 40)\n #define VTD_ECAP_PDS (1ULL << 42)\n #define VTD_ECAP_SMTS (1ULL << 43)\ndiff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h\nindex e44ce31841..95c76015e4 100644\n--- a/include/hw/i386/intel_iommu.h\n+++ b/include/hw/i386/intel_iommu.h\n@@ -314,7 +314,7 @@ struct IntelIOMMUState {\n bool intr_eime; /* Extended interrupt mode enabled */\n OnOffAuto intr_eim; /* Toggle for EIM cabability */\n uint8_t aw_bits; /* Host/IOVA address width (in bits) */\n- bool pasid; /* Whether to support PASID */\n+ uint8_t pasid; /* PASID supported in bits, 0 if not */\n bool fs1gp; /* First Stage 1-GByte Page Support */\n \n /* Transient Mapping, Reserved(0) since VTD spec revision 3.2 */\ndiff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c\nindex b784c5f10a..d1946e3a59 100644\n--- a/hw/i386/intel_iommu.c\n+++ b/hw/i386/intel_iommu.c\n@@ -4203,7 +4203,7 @@ static const Property vtd_properties[] = {\n DEFINE_PROP_BOOL(\"x-scalable-mode\", IntelIOMMUState, scalable_mode, FALSE),\n DEFINE_PROP_BOOL(\"x-flts\", IntelIOMMUState, fsts, FALSE),\n DEFINE_PROP_BOOL(\"snoop-control\", IntelIOMMUState, snoop_control, false),\n- DEFINE_PROP_BOOL(\"x-pasid-mode\", IntelIOMMUState, pasid, false),\n+ DEFINE_PROP_UINT8(\"pasid\", IntelIOMMUState, pasid, 0),\n DEFINE_PROP_BOOL(\"svm\", IntelIOMMUState, svm, false),\n DEFINE_PROP_BOOL(\"stale-tm\", IntelIOMMUState, stale_tm, false),\n DEFINE_PROP_BOOL(\"fs1gp\", IntelIOMMUState, fs1gp, true),\n@@ -5045,7 +5045,8 @@ static void vtd_cap_init(IntelIOMMUState *s)\n }\n \n if (s->pasid) {\n- s->ecap |= VTD_ECAP_PASID | VTD_ECAP_PSS;\n+ VTD_ECAP_SET_PSS(s, s->pasid - 1);\n+ s->ecap |= VTD_ECAP_PASID;\n }\n }\n \n@@ -5586,6 +5587,12 @@ static bool vtd_decide_config(IntelIOMMUState *s, Error **errp)\n return false;\n }\n \n+ if (s->pasid > PCI_EXT_CAP_PASID_MAX_WIDTH) {\n+ error_setg(errp, \"PASID width %d exceeds Max PASID Width %d allowed \"\n+ \"in PCI spec\", s->pasid, PCI_EXT_CAP_PASID_MAX_WIDTH);\n+ return false;\n+ }\n+\n if (s->svm) {\n if (!x86_iommu->dt_supported) {\n error_setg(errp, \"Need to set device IOTLB for svm\");\n","prefixes":["v4","05/15"]}