{"id":2230784,"url":"http://patchwork.ozlabs.org/api/patches/2230784/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/patch/20260430034724.1628-1-wegao@suse.com/","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260430034724.1628-1-wegao@suse.com>","list_archive_url":null,"date":"2026-04-30T03:47:16","name":"[v4] shmctl03: Fix 32-bit compat mode failure by adjusting comparisons for compat mode truncation","commit_ref":null,"pull_url":null,"state":"needs-review-ack","archived":false,"hash":"c23e7adf9d9572d6f7fe50200fe69243b7cd8a2d","submitter":{"id":85577,"url":"http://patchwork.ozlabs.org/api/people/85577/?format=json","name":"Wei Gao","email":"wegao@suse.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260430034724.1628-1-wegao@suse.com/mbox/","series":[{"id":502181,"url":"http://patchwork.ozlabs.org/api/series/502181/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/list/?series=502181","date":"2026-04-30T03:47:16","name":"[v4] shmctl03: Fix 32-bit compat mode failure by adjusting comparisons for compat mode truncation","version":4,"mbox":"http://patchwork.ozlabs.org/series/502181/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2230784/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2230784/checks/","tags":{},"related":[],"headers":{"Return-Path":"<ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=W0ISlmHJ;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=QfP8ydOT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5g9Z5Mb9z1yGq\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 13:47:43 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 2A7313E9295\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 05:47:41 +0200 (CEST)","from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id DD7853E1630\n for <ltp@lists.linux.it>; Thu, 30 Apr 2026 05:47:34 +0200 (CEST)","from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n [IPv6:2a00:1450:4864:20::436])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 5ECAF1000740\n for <ltp@lists.linux.it>; Thu, 30 Apr 2026 05:47:34 +0200 (CEST)","by mail-wr1-x436.google.com with SMTP id\n ffacd0b85a97d-43cfd1f9fd1so223913f8f.3\n for <ltp@lists.linux.it>; Wed, 29 Apr 2026 20:47:34 -0700 (PDT)","from localhost ([2a07:de40:b240:0:2ad6:ed42:2ad6:ed42])\n by smtp.gmail.com with UTF8SMTPSA id\n ffacd0b85a97d-447b3d482d3sm9704239f8f.1.2026.04.29.20.47.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 20:47:33 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1777520861; h=to : date :\n message-id : in-reply-to : references : mime-version : subject :\n list-id : list-unsubscribe : list-archive : list-post : list-help :\n list-subscribe : from : reply-to : cc : content-type :\n content-transfer-encoding : sender : from;\n bh=0BDyr1MKism39JyWa+VOHAQAXMCJNkuTy/DCm2V841A=;\n b=W0ISlmHJaV/drbXAx7xKFzKIF1pspsxT77qo69RqHf2eYCzPkpY+G/r7is6FgJphvgNh+\n ihQiLKmmE2trChGkj9tEaJevLF/7QLDK+zKiE52aoCtOIXWe3li2DIl2usXYwVEhomwA/lD\n Ed6vIMrz+uwW/hQGPNHfw+HmfaBgP+o=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1777520853; x=1778125653; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=S9ANyz8nyqtDXFuJAYKKsaQDXzPVdfxC0VzaUiaG40E=;\n b=QfP8ydOTRY/6KO/VO4KIsSt+oSc9LzkaxqKg7IY4JQG3PCqRQKqMccXD/o7iycZ86X\n t7L9S5QIKn9TtllZH62nta1RLfkhsnfavVavfowN2y9wK0A7qz3ZrBfjYNj7IE0U4Bn2\n G+bwyrLwLuLvsI1lI5MlrjHfDTlfrho77yHADeQiqTgrKoIXWp8ctdhxQFPLvMwJj/26\n p4VfZJxNLgUdFEuaXBCzcN0kNMpwqQkGmLg3XtyckyzZn9tFyuVyurNaenFelB6BVbbw\n WBQsS3Ikcv67i5leWQ7UdkMQQQ6ZJy6QHfRzIWcSIEb7gsxz9JLkxZhTdBfzj707gUfw\n 1gng=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777520853; x=1778125653;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=S9ANyz8nyqtDXFuJAYKKsaQDXzPVdfxC0VzaUiaG40E=;\n b=amj5zVX+wFB3JejlSfXd2VIdp6AXq33837WJOy57MPDvuUxCeO5+zOouUWRnt67fkF\n l2bG/Q+7Qt+sr/KalZkcHsEc/Nssd6p+EafRcH7FF/gvJ7rGHg5wDc6BynVRmxkQexCp\n a0VuKahvbTl/lz06eaCd84Ho5qdLHhvditqwF5b3RUXzOoke+Z4dkNDjTngrhq6DDLQp\n e2P5j4uk17Xa6rGIvmsM+1fb/L1kveSGscFSL4+3TneUw9Dct07JWZqSiOne8Cl267nU\n Gn8K824fIrfHxqqV/OW+7zQgPr+XfH1v9XKCkuszCZdRZAk4Tp3WT6gl8TS4MC0Iwx8K\n MyMA==","X-Gm-Message-State":"AOJu0Yx4sEd8je19qmTfBYy6MS/bwbIMnshvuz10HoNuUOZRYfIGb0xH\n adpObcM2yNIWJ7GI67lHOBxVPz7lGsyYXvera8Rk2LLh8R+kgEnKWUntxB6FMRCQqrWlHm0wc1C\n 7U4k=","X-Gm-Gg":"AeBDietcwW2KFh9a6jggiGlKhGKS2lkYONFtG+sxhRp30SHk/k1tv2OXcvUIKi+CyIJ\n T7zS8o7sq0x/Mnk8FW09YPoMjAnQiGllsfAf3n6/THgce/sVyR5xTB4qoPMnrNXYjboTi2MU4nY\n j/I1uFsyJTvxkJRwmSlAuE95K9Q0EJ5jmUij4/uusbmx+jIQRRdXWV9e7HMzTzJkiMsRg0Q2+Qk\n W7AL6MZLBjZT5fIxwVTESBk5WRkrIGHjj5EJvmChQoigmb4DMUjNmkNH3l7IoPeds8K6lFzFccn\n hKzLqyWnx+dXBNrb5XbqKtK2X/LWSzUQ1V69tGaNAWf6CRce1j9IfAS86p0xLmezTkUFi+ZmII6\n 4hTyHSfkDm5e68nA2/c05faAnTmq6CGTxIN6QErgtWIpHFaAFjWOB3KrqzblQzhxBkQYN9P38op\n ePbfPKdY2Lxhpj6DzImxnOyg==","X-Received":"by 2002:a05:6000:2385:b0:43d:70de:1c68 with SMTP id\n ffacd0b85a97d-4493fa01907mr1570493f8f.30.1777520853362;\n Wed, 29 Apr 2026 20:47:33 -0700 (PDT)","To":"ltp@lists.linux.it","Date":"Thu, 30 Apr 2026 03:47:16 +0000","Message-ID":"<20260430034724.1628-1-wegao@suse.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260429111823.1046-1-wegao@suse.com>","References":"<20260429111823.1046-1-wegao@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-4.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-4.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH v4] shmctl03: Fix 32-bit compat mode failure by\n adjusting comparisons for compat mode truncation","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project <ltp.lists.linux.it>","List-Unsubscribe":"<https://lists.linux.it/options/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=unsubscribe>","List-Archive":"<http://lists.linux.it/pipermail/ltp/>","List-Post":"<mailto:ltp@lists.linux.it>","List-Help":"<mailto:ltp-request@lists.linux.it?subject=help>","List-Subscribe":"<https://lists.linux.it/listinfo/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=subscribe>","From":"Wei Gao via ltp <ltp@lists.linux.it>","Reply-To":"Wei Gao <wegao@suse.com>","Cc":"Dan Carpenter <dan.carpenter@linaro.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>"},"content":"On 64-bit kernels, the default shmmax and shmall values often exceed\nthe range of a 32-bit unsigned long or are clipped differently by the\nkernel's compat syscall layer than they appear in /proc.\n\nLink: https://lore.kernel.org/ltp/aJm5SBOaRoe1e0PB@yuki.lan/\nSigned-off-by: Wei Gao <wegao@suse.com>\nSuggested-by: Cyril Hrubis <chrubis@suse.cz>\nReported-by: Dan Carpenter <dan.carpenter@linaro.org>\n---\n include/tst_assert.h                          |  9 ++++---\n lib/tst_assert.c                              | 27 ++++++++++++++-----\n .../kernel/syscalls/ipc/shmctl/shmctl03.c     | 17 +++++++++---\n 3 files changed, 41 insertions(+), 12 deletions(-)","diff":"diff --git a/include/tst_assert.h b/include/tst_assert.h\nindex dcb62dfea..2f1051270 100644\n--- a/include/tst_assert.h\n+++ b/include/tst_assert.h\n@@ -21,14 +21,17 @@ void tst_assert_int(const char *file, const int lineno,\n #define TST_ASSERT_FILE_INT(path, prefix, val) \\\n \ttst_assert_file_int(__FILE__, __LINE__, path, prefix, val)\n \n+#define TST_ASSERT_SATURATED_INT   0x01\n+#define TST_ASSERT_BITWISE         0x02\n+\n /*\n  * Same as tst_assert_int() but for unsigned long.\n  */\n void tst_assert_ulong(const char *file, const int lineno,\n-                      const char *path, unsigned long val);\n+                      const char *path, unsigned long val, int flags);\n \n-#define TST_ASSERT_ULONG(path, val) \\\n-\ttst_assert_ulong(__FILE__, __LINE__, path, val)\n+#define TST_ASSERT_ULONG(path, val, ...) \\\n+\ttst_assert_ulong(__FILE__, __LINE__, path, val, (0, ##__VA_ARGS__))\n \n /*\n  * Asserts that integer value stored in the prefix field of file pointed by path\ndiff --git a/lib/tst_assert.c b/lib/tst_assert.c\nindex b68bd5d39..fd651f53a 100644\n--- a/lib/tst_assert.c\n+++ b/lib/tst_assert.c\n@@ -5,6 +5,7 @@\n  * Copyright (c) 2020 Cyril Hrubis <chrubis@suse.cz>\n  */\n #include <stdio.h>\n+#include <limits.h>\n #define TST_NO_DEFAULT_MAIN\n #include \"tst_assert.h\"\n #include \"tst_test.h\"\n@@ -23,18 +24,32 @@ void tst_assert_int(const char *file, const int lineno, const char *path, int va\n \ttst_res_(file, lineno, TFAIL, \"%s != %d got %d\", path, val, sys_val);\n }\n \n-void tst_assert_ulong(const char *file, const int lineno, const char *path, unsigned long val)\n+void tst_assert_ulong(const char *file, const int lineno, const char *path,\n+\t\t      unsigned long val, int flags)\n {\n-\tunsigned long sys_val;\n-\n-\tsafe_file_scanf(file, lineno, NULL, path, \"%lu\", &sys_val);\n+\tunsigned long long sys_val_64;\n+\tunsigned long expected_val;\n+\n+\tsafe_file_scanf(file, lineno, NULL, path, \"%llu\", &sys_val_64);\n+\n+\tif (flags & TST_ASSERT_SATURATED_INT) {\n+\t\tif (sys_val_64 > (unsigned long long)INT_MAX)\n+\t\t\texpected_val = (unsigned long)INT_MAX;\n+\t\telse\n+\t\t\texpected_val = (unsigned long)sys_val_64;\n+\t} else if (flags & TST_ASSERT_BITWISE) {\n+\t\texpected_val = (unsigned long)(sys_val_64 & 0xFFFFFFFFULL);\n+\t} else {\n+\t\texpected_val = (unsigned long)sys_val_64;\n+\t}\n \n-\tif (val == sys_val) {\n+\tif (val == expected_val) {\n \t\ttst_res_(file, lineno, TPASS, \"%s = %lu\", path, val);\n \t\treturn;\n \t}\n \n-\ttst_res_(file, lineno, TFAIL, \"%s != %lu got %lu\", path, val, sys_val);\n+\ttst_res_(file, lineno, TFAIL, \"%s != %lu got %lu (raw: %llu)\",\n+\t\tpath, val, expected_val, sys_val_64);\n }\n \n void tst_assert_file_int(const char *file, const int lineno, const char *path, const char *prefix, int val)\ndiff --git a/testcases/kernel/syscalls/ipc/shmctl/shmctl03.c b/testcases/kernel/syscalls/ipc/shmctl/shmctl03.c\nindex a1f53e7c1..e6c7a8027 100644\n--- a/testcases/kernel/syscalls/ipc/shmctl/shmctl03.c\n+++ b/testcases/kernel/syscalls/ipc/shmctl/shmctl03.c\n@@ -30,9 +30,20 @@ static void verify_ipcinfo(void)\n \telse\n \t\ttst_res(TPASS, \"shmmin = 1\");\n \n-\tTST_ASSERT_ULONG(\"/proc/sys/kernel/shmmax\", info.shmmax);\n-\tTST_ASSERT_ULONG(\"/proc/sys/kernel/shmmni\", info.shmmni);\n-\tTST_ASSERT_ULONG(\"/proc/sys/kernel/shmall\", info.shmall);\n+\tif (tst_is_compat_mode()) {\n+\t\t/*\n+\t\t * On 64-bit kernel, shmmax is clamped to INT_MAX for 32-bit\n+\t\t * compat syscall, while shmmni and shmall are truncated\n+\t\t * to 32-bit.\n+\t\t */\n+\t\tTST_ASSERT_ULONG(\"/proc/sys/kernel/shmmax\", info.shmmax, TST_ASSERT_SATURATED_INT);\n+\t\tTST_ASSERT_ULONG(\"/proc/sys/kernel/shmmni\", info.shmmni, TST_ASSERT_BITWISE);\n+\t\tTST_ASSERT_ULONG(\"/proc/sys/kernel/shmall\", info.shmall, TST_ASSERT_BITWISE);\n+\t} else {\n+\t\tTST_ASSERT_ULONG(\"/proc/sys/kernel/shmmax\", info.shmmax);\n+\t\tTST_ASSERT_ULONG(\"/proc/sys/kernel/shmmni\", info.shmmni);\n+\t\tTST_ASSERT_ULONG(\"/proc/sys/kernel/shmall\", info.shmall);\n+\t}\n }\n \n static struct tst_test test = {\n","prefixes":["v4"]}